Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127911/ --- (Updated May 16, 2016, 9:21 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

> On May 15, 2016, 8:03 p.m., Kåre Särs wrote: > > Looks good :) A couple of questions: > > > > - If we create the .rcc do we also want to install the icons? > > - I creates a similar solution for Kate on Windows (in a separate repo), > > but I needed to add a program to replace the symlinked f

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127911/ --- (Updated May 16, 2016, 9:16 a.m.) Review request for KDE Frameworks. Ch

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 40 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 15 May 2016 22:55:12 + Build duration: 1 min 52 sec CHANGE SET Revision f82de1626f8efdb56ca810fc827d40b

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 40 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 15 May 2016 22:55:12 + Build duration: 1 min 52 sec CHANGE SET Revision f82de1626f8efdb56ca810fc827d40b

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 41 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 15 May 2016 22:55:12 + Build duration: 1 min 59 sec CHANGE SET Revision f82de1626f8efdb56ca810fc827d40bf7eed4

Review Request 127935: Call kdoctools_create_handbook only for index.docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127935/ --- Review request for Documentation, KDE Frameworks and Elvis Angelaccio. Bu

Re: Review Request 127934: Rename docs/kjsembed directory to docs/kjsembed5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127934/#review95495 --- Ship it! Ship It! - David Faure On mai 15, 2016, 9:13 a

Re: Review Request 127933: Rename docs/kjs directory to docs/kjs5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127933/#review95494 --- Ship it! Ship It! - David Faure On mai 15, 2016, 9 aprè

Review Request 127934: Rename docs/kjsembed directory to docs/kjsembed5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127934/ --- Review request for KDE Frameworks, Localization and Translation (l10n) and

Review Request 127933: Rename docs/kjs directory to docs/kjs5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127933/ --- Review request for KDE Frameworks, Localization and Translation (l10n) and

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95492 --- src/kiconloader.cpp (line 820)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 40 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 15 May 2016 19:09:55 + Build duration: 3 min 2 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 39 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 15 May 2016 19:07:45 + Build duration: 2 min 57 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 36 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 15 May 2016 19:07:45 + Build duration: 59 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 127931: Kdelibs4ConfigMigrator: skip reparsing if nothing was migrated.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127931/ --- (Updated May 15, 2016, 7:04 p.m.) Status -- This change has been mar

Re: Review Request 127931: Kdelibs4ConfigMigrator: skip reparsing if nothing was migrated.

> On May 15, 2016, 5:52 p.m., Laurent Montel wrote: > > Seems ok for me. > > Could you convert qDebug() to qCDebug ? > > > > After fixing it ship it :) > > > > Regards. The qDebug was already there (I only fixed the white spaces) so this is unrelated to the commit. But OK I'll convert that fi

Re: Review Request 127897: Update documentation of kdoctools_install macro

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127897/#review95488 --- Ship it! Thanks. Now that Frameworks 5.22 is released, it

Re: Review Request 127931: Kdelibs4ConfigMigrator: skip reparsing if nothing was migrated.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127931/#review95486 --- Ship it! Seems ok for me. Could you convert qDebug() to qC

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127911/#review95485 --- Looks good :) A couple of questions: - If we create the .rcc

Review Request 127931: Kdelibs4ConfigMigrator: skip reparsing if nothing was migrated.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127931/ --- Review request for KDE Frameworks and Laurent Montel. Repository: kcoread

Review Request 127929: K4TimeZoneWidget: flag images not displayed because of incorrect path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127929/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript

Review Request 127928: Rename docs/kioslave directory to docs/kioslave5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127928/ --- Review request for KDE Frameworks, Localization and Translation (l10n) and

Review Request 127927: Move kcm_ssl kcm docs to subdir docs/kcontrol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127927/ --- Review request for KDE Frameworks, Localization and Translation (l10n) and

Re: Review Request 127906: Remove qt5options manpage docbook

> On Mai 13, 2016, 2:16 nachm., Luigi Toscano wrote: > > Then we need to remove all references to qt5options (for example from > > kf5options). > > We have the question about kf5options which comes immediately after. > > > > It would be interesting to know if the (updated) content of qt5options

Re: Review Request 127906: Remove qt5options manpage docbook

> On Mai 13, 2016, 2:14 nachm., David Faure wrote: > > I don't have a strong opinion on whether to keep it or not, but note that > > your reasoning is incomplete. A lot of command-line options have moved up > > to the base classes QGuiApplication and QCoreApplication. Thanks for the hint David

Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127926/ --- Review request for KDE Frameworks, David Edmundson and Olivier Goffart. B

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 36 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 15 May 2016 10:06:29 + Build duration: 6 min 25 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 32 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 15 May 2016 10:05:19 + Build duration: 8 min 20 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 30 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 15 May 2016 10:06:29 + Build duration: 6 min 11 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: LGPL for Breeze QStyle and qtquickcontrols?

On Monday, 9 May 2016, Martin Graesslin wrote: > On Saturday, May 7, 2016 10:10:50 PM CEST Jaroslaw Staniek wrote: >> Hi, >> Is relicensing Breeze QStyle to LGPL from GPL for possible and acceptable? >> I've found cases when bits of the code beyond QStyle/KStyle API need >> to be reused. One examp

Review Request 127925: KWalletd migration: fix error handling.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127925/ --- Review request for KDE Frameworks. Repository: kwallet Description

Re: Review Request 127923: Add support for custom emoticon sizes

> On Mayo 15, 2016, 8:34 a.m., David Gil Oliva wrote: > > +1 > > > > Looks ok to me :-) ... when issue is fixed, of course - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127923

Re: Review Request 127923: Add support for custom emoticon sizes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127923/#review95477 --- +1 Looks ok to me :-) - David Gil Oliva On Mayo 15, 2016,

Re: KConfig compiler. GenerateProperties and Mutable.

On Fri, May 13, 2016 at 1:02 PM, Artem Fedoskin wrote: > Hi Aleix, > > I'm sorry for late reply. I was trying to compile KStars for Android and > struggled a bit with compiling KF5. > > 1. I don't know whether this is a problem or a feature - When I compile my app > for Android and use KConfig com

Re: Review Request 127923: Add support for custom emoticon sizes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127923/#review95476 --- +1 src/core/kemoticonsprovider.cpp (line 155)

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127911/#review95475 --- Looks good to me. +1 icons/CMakeLists.txt (line 27)