Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/ --- (Updated Май 18, 2016, 11:06 преди обяд) Review request for KDE Framework

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 36 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 08:11:54 + Build duration: 1 min 4 sec CHANGE SET Revision 9578e3c26c8d28b433d52a6b70f8d617ee96

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 36 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 08:11:54 + Build duration: 1 min 4 sec CHANGE SET Revision 9578e3c26c8d28b433d52a6b70f8d617ee96

Re: Review Request 127817: Don't make KIconThemes depend on Oxygen

> On Mai 17, 2016, 2:29 nachm., Wolfgang Bauer wrote: > > Sorry for coming late, I'm not subscribed to the list (and I'm not a > > maintainer either), just noticed the commit. > > > > I have nothing against the patch per se, and it apparently won't cause the > > wrong fallback to breeze either

Review Request 127952: add a function to override the current theme heuristics with a static value

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127952/ --- Review request for KDE Frameworks, Christoph Feck, David Edmundson, and Mar

Re: LGPL for Breeze QStyle and qtquickcontrols?

On 17 May 2016 at 20:48, Hugo Pereira Da Costa < hugo.pereira.da.co...@gmail.com> wrote: > Hi, > > [snip] > >> >> ​Architecturally, the eventual solution would be that breeze.git becomes >> layered, and routines beyond what QStyle defines are provided by an LGPL >> lib. It worked with libOxygen th

Re: LGPL for Breeze QStyle and qtquickcontrols?

On 05/18/2016 11:13 AM, Jaroslaw Staniek wrote: On 17 May 2016 at 20:48, Hugo Pereira Da Costa > wrote: Hi, [snip] ​Architecturally, the eventual solution would be that breeze.git becomes layered, and routines beyond

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 47 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/47/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 18 May 2016 09:39:10 + Build duration: 2 min 34 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 47 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/47/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 18 May 2016 09:39:10 + Build duration: 2 min 34 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 48 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/48/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 18 May 2016 09:39:10 + Build duration: 6 min 10 sec CHANGE SET Revisio

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 48 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/48/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 18 May 2016 09:39:10 + Build duration: 6 min 14 sec CHANGE SET Revision 48

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 48 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/48/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 18 May 2016 09:39:10 + Build duration: 6 min 10 sec CHANGE SET Revisio

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 47 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/47/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 18 May 2016 09:39:10 + Build duration: 5 min 43 sec CHANGE SET Revi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 48 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/48/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 18 May 2016 09:39:10 + Build duration: 6 min 14 sec CHANGE SET Revision 48

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 47 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/47/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 18 May 2016 09:39:10 + Build duration: 5 min 43 sec CHANGE SET Revi

Jenkins-kde-ci: kdewebkit master stable-kf5-qt5 » Linux,gcc - Build # 62 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdewebkit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/62/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 09:54:14 + Build duration: 19 sec CHANGE SET No changes __

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127952/#review95579 --- src/kicontheme.h (line 223)

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

> On May 18, 2016, 9:58 a.m., Marco Martin wrote: > > src/kicontheme.h, line 223 > > > > > > what about just a testmode bool like qstandardpaths? That would be the other approach I talk about in the description.

Re: Review Request 127887: Improve usage of Qt APIs

> On May 17, 2016, 10:46 p.m., Gregor Mi wrote: > > src/core/installation.cpp, line 383 > > > > > > I don't know if this does the same but also didn't test. It uses QStandardPaths to actively look-up instead of

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

> On May 18, 2016, 9:58 a.m., Marco Martin wrote: > > src/kicontheme.h, line 223 > > > > > > what about just a testmode bool like qstandardpaths? > > Harald Sitter wrote: > That would be the other approach I

Re: LGPL for Breeze QStyle and qtquickcontrols?

On Wed, May 18, 2016 at 11:36 AM, Hugo Pereira Da Costa wrote: > On 05/18/2016 11:13 AM, Jaroslaw Staniek wrote: > > > > On 17 May 2016 at 20:48, Hugo Pereira Da Costa > wrote: >> >> Hi, >> >> [snip] >>> >>> >>> Architecturally, the eventual solution would be that breeze.git becomes >>> layered,

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127952/ --- (Updated May 18, 2016, 10:30 a.m.) Review request for KDE Frameworks and

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

> On May 18, 2016, 9:58 a.m., Marco Martin wrote: > > src/kicontheme.h, line 223 > > > > > > what about just a testmode bool like qstandardpaths? > > Harald Sitter wrote: > That would be the other approach I

Re: LGPL for Breeze QStyle and qtquickcontrols?

On 17 May 2016 at 20:38, Martin Graesslin wrote: > On Tuesday, May 17, 2016 6:23:10 PM CEST Jaroslaw Staniek wrote: > > > If you show me why it needs to be a framework and I agree with it, > > > I might be willing to consider to allow to relicense the code I wrote > for > > > it. > > > > There's

Review Request 127953: rename fake icon set to hicolor as oxygen is no longer a fallback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127953/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kxm

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127952/#review95585 --- Ship it! Ship It! - Marco Martin On May 18, 2016, 10:30

Re: Review Request 127953: rename fake icon set to hicolor as oxygen is no longer a fallback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127953/#review95586 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 18, 2016,

Re: Review Request 127953: rename fake icon set to hicolor as oxygen is no longer a fallback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127953/ --- (Updated May 18, 2016, 11:22 a.m.) Status -- This change has been ma

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 73 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/73/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 11:35:24 + Build duration: 5.8 sec CHANGE SET No changes _

Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux,gcc - Build # 63 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/63/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 11:35:24 + Build duration: 6.3 sec CHANGE SET No changes

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 62 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/62/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 11:35:24 + Build duration: 6.8 sec CHANGE SET No changes

Review Request 127954: force icon themes explicitly via new testing helper function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127954/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: p

Re: Review Request 127954: force icon themes explicitly via new testing helper function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127954/#review95587 --- Ship it! Ship It! - Marco Martin On May 18, 2016, 11:40

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127952/ --- (Updated May 18, 2016, 11:50 a.m.) Status -- This change has been ma

Re: Review Request 127954: force icon themes explicitly via new testing helper function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127954/ --- (Updated May 18, 2016, 12:53 p.m.) Status -- This change has been ma

Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127926/#review95588 --- A better approach I think would be to have a simple checkbox,

Re: LGPL for Breeze QStyle and qtquickcontrols?

On Wednesday, May 18, 2016 12:41:49 PM CEST Jaroslaw Staniek wrote: > On 17 May 2016 at 20:38, Martin Graesslin wrote: > > On Tuesday, May 17, 2016 6:23:10 PM CEST Jaroslaw Staniek wrote: > > > > If you show me why it needs to be a framework and I agree with it, > > > > I might be willing to consi

Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method

> On May 18, 2016, 2:16 p.m., Martin Klapetek wrote: > > A better approach I think would be to have a simple checkbox, store > > that in a config and then have KNotification/NotifyByAudio simply > > do nothing if that config/value is present. > > > > Or even have KNotificationManager::notify(..)

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 74 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/74/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 17:44:00 + Build duration: 5 min 24 sec CHANGE SET Revision cee0c38ca3e11803b2b694300c98a212be

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 74 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/74/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 17:44:00 + Build duration: 5 min 24 sec CHANGE SET Revision cee0c38ca3e11803b2b694300c98a212be

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/#review95595 --- Ping - Anthony Fieroni On Май 4, 2016, 8:06 след обяд, Ant

Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux,gcc - Build # 64 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 21:19:47 + Build duration: 50 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux,gcc - Build # 64 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 21:19:47 + Build duration: 50 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 38 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/38/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 21:54:52 + Build duration: 56 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 43 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/43/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 21:58:18 + Build duration: 2 min 9 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 39 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 22:26:39 + Build duration: 56 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 39 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 22:26:39 + Build duration: 56 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 44 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/44/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 22:24:49 + Build duration: 2 min 40 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 47 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 22:26:33 + Build duration: 2 min 39 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 48 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 18 May 2016 22:30:03 + Build duration: 2 min 3 sec CHANGE SET No changes JUNIT RESULTS Name: (root