Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-05-20 Thread Pino Toscano
> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote: > > Do you still have the sample application you made to test/verify this? I'd > > like to try it and it should probably be committed too. No I don't :-/ I remember it was just removing indexes with associated widgets. - Pino

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread Pino Toscano
> On May 20, 2016, 11:43 p.m., Nicolás Alvarez wrote: > > Not only I approve of this change, but I also wish it was done over all > > other KDE software using flex/bison. Yup, I will take care of othe cases like this one (they are just a few, luckly). - Pino

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread Pino Toscano
> On May 20, 2016, 11:21 p.m., René J.V. Bertin wrote: > > I've done some testing with Solid 5.20.0 .The patch applies cleanly, but > > I'm getting the error below. I'd write that down to using the older Solid > > version if it weren't for that fact I'm quite sure I've seen this kind of > > er

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2016-05-20 Thread Gleb Popov
> On April 5, 2015, 5:26 p.m., David Faure wrote: > > Well, +1 for the idea. But I wonder what the apidox will look like, the > > macro+template probably don't make it work. > > > > Also missing @since 5.10. > > > > Ship it from me once the apidox issue is resolved. What apidox issue is being

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread René J . V . Bertin
> On May 21, 2016, 1:21 a.m., René J.V. Bertin wrote: > > I've done some testing with Solid 5.20.0 .The patch applies cleanly, but > > I'm getting the error below. I'd write that down to using the older Solid > > version if it weren't for that fact I'm quite sure I've seen this kind of > > err

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95658 --- Ship it! Not only I approve of this change, but I also wis

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95657 --- I've done some testing with Solid 5.20.0 .The patch applies c

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

2016-05-20 Thread Ben Cooksley
> On May 20, 2016, 1:50 a.m., Michael Pyne wrote: > > I've looked at the code itself and it seems reasonable, so from that > > perspective and given the length of time there's been no -1's, I think it's > > safe to commit. > > > > However you mentioned in the description that this isn't safe t

Re: Review Request 127968: kshareddatacache: Fix invalid use of & to avoid unaligned reads

2016-05-20 Thread Michael Pyne
> On May 19, 2016, 11:17 p.m., Michael Pyne wrote: > > This is an error upstream in the MurmurHash 1.0 aligned implementation > > (which still contains the error, see > > https://sites.google.com/site/murmurhash/MurmurHashAligned.cpp?attredirects=0 > > ) > > > > In our case KSharedDataCache w

Re: Review Request 127896: make dbus optional on osx: kauth

2016-05-20 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/ --- (Updated May 20, 2016, 9:13 p.m.) Review request for KDE Software on Mac

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

2016-05-20 Thread Olivier Churlaud
> On May 20, 2016, 3:50 a.m., Michael Pyne wrote: > > I've looked at the code itself and it seems reasonable, so from that > > perspective and given the length of time there's been no -1's, I think it's > > safe to commit. > > > > However you mentioned in the description that this isn't safe t

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread Pino Toscano
> On May 20, 2016, 8:39 a.m., René J.V. Bertin wrote: > > Looks good but I'll try to do a test-build during one of my next "lost > > moments". > > > > Is there a minimum required version for either of the parser/generators? > Is there a minimum required version for either of the parser/generat

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 57 - Unstable!

2016-05-20 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/57/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 20 May 2016 16:00:06 + Build duration: 3 min 11 sec CHANGE SET Revisi

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

2016-05-20 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/ --- (Updated May 20, 2016, 6:54 p.m.) Status -- This change has been mar

Re: Review Request 127976: Support selected state

2016-05-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127976/ --- (Updated May 20, 2016, 2:38 p.m.) Status -- This change has been mar

Re: Review Request 127976: Support selected state

2016-05-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127976/#review95650 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 20, 2016,

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-05-20 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/ --- (Updated May 20, 2016, 3:33 p.m.) Status -- This change has been mar

Review Request 127976: Support selected state

2016-05-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127976/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 56 - Fixed!

2016-05-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/56/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 3 min 21 sec CHANGE SET Revisio

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 56 - Fixed!

2016-05-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/56/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 3 min 21 sec CHANGE SET Revisio

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 55 - Fixed!

2016-05-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/55/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 2 min 57 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 56 - Fixed!

2016-05-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/56/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 2 min 50 sec CHANGE SET Revision 1d

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 56 - Fixed!

2016-05-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/56/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 2 min 50 sec CHANGE SET Revision 1d

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 55 - Fixed!

2016-05-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/55/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 2 min 57 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 55 - Fixed!

2016-05-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/55/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 2 min 38 sec CHANGE SET Revi

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 55 - Fixed!

2016-05-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/55/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 2 min 38 sec CHANGE SET Revi

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95644 --- Looks good but I'll try to do a test-build during one of my n

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 45 - Fixed!

2016-05-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/45/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 May 2016 08:12:21 + Build duration: 4 min 56 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 45 - Fixed!

2016-05-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/45/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 May 2016 08:12:21 + Build duration: 4 min 56 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 49 - Fixed!

2016-05-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/49/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 May 2016 08:14:01 + Build duration: 1 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 49 - Fixed!

2016-05-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/49/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 May 2016 08:14:01 + Build duration: 1 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 40 - Unstable!

2016-05-20 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 May 2016 08:14:01 + Build duration: 1 min 0 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 40 - Unstable!

2016-05-20 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 May 2016 08:12:21 + Build duration: 3 min 36 sec CHANGE SET No changes JUNIT RESULTS Name: (

Re: Review Request 127968: kshareddatacache: Fix invalid use of & to avoid unaligned reads

2016-05-20 Thread Fabian Vogt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127968/ --- (Updated May 20, 2016, 11:08 a.m.) Status -- This change has been ma

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-20 Thread Hannah von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95643 --- >From the windows side, we have flex and bison. +1 - Hannah

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-20 Thread René J . V . Bertin
> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >