Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

2016-05-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127971/ --- (Updated May 25, 2016, 11:03 a.m.) Status -- This change has been ma

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 75 - Fixed!

2016-05-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/75/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 25 May 2016 09:11:21 + Build duration: 6 min 55 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fai

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 75 - Fixed!

2016-05-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/75/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 25 May 2016 09:11:21 + Build duration: 6 min 55 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fai

Re: Review Request 127843: Properly remove composed characters

2016-05-25 Thread Jan Grulich
> On Kvě. 24, 2016, 10:05 odp., Milian Wolff wrote: > > Jan, I think you've not yet uploaded the updated patch? That's right, because I wasn't successfull fixing this in a way Dominik wanted me to fix and right now I don't have unfortunately time for that. - Jan

Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

2016-05-25 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128011/ --- Review request for KDE Frameworks, Alex Richardson and David Faure. Repos

Re: Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

2016-05-25 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128011/ --- (Updated May 25, 2016, 3:23 p.m.) Review request for KDE Frameworks, Alex

Re: Review Request 127843: Properly remove composed characters

2016-05-25 Thread Dominik Haumann
> On Mai 24, 2016, 10:05 nachm., Milian Wolff wrote: > > Jan, I think you've not yet uploaded the updated patch? > > Jan Grulich wrote: > That's right, because I wasn't successfull fixing this in a way Dominik > wanted me to fix and right now I don't have unfortunately time for that. hm, w

Review Request 128014: [KToggleToolBarAction] Honor action/options_show_toolbar restriction

2016-05-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128014/ --- Review request for KDE Frameworks and David Edmundson. Repository: kxmlgu

Re: Review Request 128014: [KToggleToolBarAction] Honor action/options_show_toolbar restriction

2016-05-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128014/#review95784 --- Ship it! Ship It! - David Edmundson On May 25, 2016, 3:

Review Request 128017: Add donate menu item to help menu of our apps

2016-05-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128017/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Review Request 128018: Add donate menu item to help menu of our apps

2016-05-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128018/ --- Review request for KDE Frameworks. Repository: kparts Description -

Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/ --- Review request for KDE Frameworks and KDE Usability. Repository: kconfig

Re: Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/#review95793 --- +1. After years of using KDE Software, I don't think any time

Re: Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/#review95795 --- +1 only hit it accidentally. If we were to provide Help on F

Re: Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-25 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/#review95797 --- I disagree, but I fear I will be the only one. - Luigi Tosca

Re: Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-25 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/#review95798 --- Is there any way to instead change it to an "F1, F1" sequence

Re: Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-25 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128019/#review95801 --- As Kai said: Activating the help cursor by pressing F1 (and a

Re: Review Request 128017: Add donate menu item to help menu of our apps

2016-05-25 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128017/#review95802 --- +1 From a technical side, it looks good to me (aside from the

Re: KConfig compiler. GenerateProperties and Mutable.

2016-05-25 Thread Artem Fedoskin
>>> We could also start with turning that into quint64, to already double the number of possible settings, right? Easy short term fix. Am I correct that with quint64 we will gain just 32 more additional unique signal bit masks? The problem is that my config file has more than 300. I managed to ma