Re: Review Request 128039: Fix the window type of the progress widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128039/#review95970 --- Maybe only do it when the parent is null? As far as i read t

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated May 29, 2016, 5:41 p.m.) Review request for KDE Software on Mac

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review95984 --- src/kstatusnotifieritem.cpp (line 902)

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Mai 29, 2016, 3:51 nachm., Kai Uwe Broulik wrote: > > Can you check whether QIcon::setIsMask works, OSX >= 10.10 tray icons are monochrome usually. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://

Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound file (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128043/ --- Review request for KDE Software on Mac OS X and KDE Frameworks. Repositor

Re: Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound file (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128043/#review95986 --- +1 src/notifybyaudio.cpp (line 58)

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 5:51 p.m., Kai Uwe Broulik wrote: > > > > Kai Uwe Broulik wrote: > Can you check whether QIcon::setIsMask works, OSX >= 10.10 tray icons are > monochrome usually. Most of Apple's own icons in the menubar have always been monochrome. This is not true for 3rd party applic

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Mai 29, 2016, 3:51 nachm., Kai Uwe Broulik wrote: > > > > Kai Uwe Broulik wrote: > Can you check whether QIcon::setIsMask works, OSX >= 10.10 tray icons are > monochrome usually. > > René J.V. Bertin wrote: > Most of Apple's own icons in the menubar have always been monochrome. >

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 5:51 p.m., Kai Uwe Broulik wrote: > > > > Kai Uwe Broulik wrote: > Can you check whether QIcon::setIsMask works, OSX >= 10.10 tray icons are > monochrome usually. > > René J.V. Bertin wrote: > Most of Apple's own icons in the menubar have always been monochrome. > T

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Mai 29, 2016, 3:51 nachm., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > i18nc please > > René J.V. Bertin wrote: > I'm not sure what to expect here, what effect is using

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 5:51 p.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > i18nc please > > René J.V. Bertin wrote: > I'm not sure what to expect here, what effect is using `i

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated May 29, 2016, 7:30 p.m.) Review request for KDE Software on Mac

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review95996 --- src/kstatusnotifieritem.cpp (line 955)

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 7:45 p.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 962 > > > > > > That's not what this is for. It's so it uses merely the "shape" of the > > icon. From your description i

Re: Review Request 128039: Fix the window type of the progress widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128039/ --- (Updated May 29, 2016, 6:04 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated May 29, 2016, 8:03 p.m.) Review request for KDE Software on Mac

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Mai 29, 2016, 3:51 nachm., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > i18nc please > > René J.V. Bertin wrote: > I'm not sure what to expect here, what effect is using

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 5:51 p.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > i18nc please > > René J.V. Bertin wrote: > I'm not sure what to expect here, what effect is using `i

Re: Review Request 128039: Fix the window type of the progress widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128039/#review96006 --- Not an expert in the area but this is my +1, if noone gives y

Re: KConfig compiler. GenerateProperties and Mutable.

On jeudi 26 mai 2016 02:31:29 CEST Artem Fedoskin wrote: > >>> We could also start with turning that into quint64, to already double > > the number of possible settings, right? Easy short term fix. > > Am I correct that with quint64 we will gain just 32 more additional unique > signal bit masks?

Re: LGPL for Breeze QStyle and qtquickcontrols?

On Mon, May 23, 2016 at 9:38 AM, Martin Graesslin wrote: > On Sunday, May 22, 2016 12:22:28 AM CEST Jaroslaw Staniek wrote: >> So we, in KDE, lack LGPL style code for our de-facto official look and feel. > > This is the crucial point. Breeze is not the de-facto official look and feel > of > KDE.

Re: Review Request 128017: Add donate menu item to help menu of our apps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128017/#review96015 --- Kind of unrelated: do you have ideas how we can integrate the