Re: Review Request 128057: Don't initialize KNS3::DownloadManager with the wrong categories

2016-05-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128057/ --- (Updated June 1, 2016, 1:14 a.m.) Status -- This change has been

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128056/ --- (Updated May 31, 2016, 11:22 p.m.) Review request for KDE Software on

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128056/ --- (Updated May 31, 2016, 11:21 p.m.) Review request for KDE Software on

Re: Review Request 128057: Don't initialize KNS3::DownloadManager with the wrong categories

2016-05-31 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128057/#review96108 --- Ship it! Ship It! - Jeremy Whiting On May 30, 2016,

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread Martin Gräßlin
> On May 31, 2016, 12:47 p.m., Martin Gräßlin wrote: > > I suggest to look at > > https://api.kde.org/frameworks/kconfigwidgets/html/classKColorSchemeManager.html > > which does something similar just for color schemes. Might make sense to > > have the API structured very similar > > René

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 44 - Still Unstable!

2016-05-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/44/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 14:47:42 + Build duration: 4 min 30 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

2016-05-31 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128011/ --- (Updated May 31, 2016, 2:44 p.m.) Status -- This change has been

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2016-05-31 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/ --- (Updated May 31, 2016, 2:44 p.m.) Status -- This change has been

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 29, 2016, 7:45 p.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 962 > > > > > > That's not what this is for. It's so it uses merely the "shape" of the > > icon. From your description

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 12:47 p.m., Martin Gräßlin wrote: > > I suggest to look at > > https://api.kde.org/frameworks/kconfigwidgets/html/classKColorSchemeManager.html > > which does something similar just for color schemes. Might make sense to > > have the API structured very similar > > René

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread Kai Uwe Broulik
> On Mai 31, 2016, 10:47 vorm., Martin Gräßlin wrote: > > I suggest to look at > > https://api.kde.org/frameworks/kconfigwidgets/html/classKColorSchemeManager.html > > which does something similar just for color schemes. Might make sense to > > have the API structured very similar > > René

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 12:47 p.m., Martin Gräßlin wrote: > > I suggest to look at > > https://api.kde.org/frameworks/kconfigwidgets/html/classKColorSchemeManager.html > > which does something similar just for color schemes. Might make sense to > > have the API structured very similar > > René

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 12:47 p.m., Martin Gräßlin wrote: > > I suggest to look at > > https://api.kde.org/frameworks/kconfigwidgets/html/classKColorSchemeManager.html > > which does something similar just for color schemes. Might make sense to > > have the API structured very similar > > René

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 10:51 a.m., Milian Wolff wrote: > > -2 > > > > kdevelop should use the global widget style. if you don't want that, change > > it via systemsettings > > Aleix Pol Gonzalez wrote: > Well, it's not far-fetching to understand that on non-plasma systems this > KCM will be

Re: Review Request 128065: move glass theme to kde-look.

2016-05-31 Thread Harald Sitter
> On May 31, 2016, 10:29 a.m., Aleix Pol Gonzalez wrote: > > where will Glass be developed now? Is a tarball enough? It hasn't been "developed" since 2004. All that's happened is 4 location changes, 2 name changes and bit of an expansion of the mappings in the xml. If someone wishes to do

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread Milian Wolff
> On May 31, 2016, 8:51 a.m., Milian Wolff wrote: > > -2 > > > > kdevelop should use the global widget style. if you don't want that, change > > it via systemsettings > > Aleix Pol Gonzalez wrote: > Well, it's not far-fetching to understand that on non-plasma systems this > KCM will be

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread Milian Wolff
> On May 31, 2016, 10:47 a.m., Martin Gräßlin wrote: > > I suggest to look at > > https://api.kde.org/frameworks/kconfigwidgets/html/classKColorSchemeManager.html > > which does something similar just for color schemes. Might make sense to > > have the API structured very similar > > René

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 12:47 p.m., Martin Gräßlin wrote: > > I suggest to look at > > https://api.kde.org/frameworks/kconfigwidgets/html/classKColorSchemeManager.html > > which does something similar just for color schemes. Might make sense to > > have the API structured very similar Yes, that

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 10:51 a.m., Milian Wolff wrote: > > -2 > > > > kdevelop should use the global widget style. if you don't want that, change > > it via systemsettings > > Aleix Pol Gonzalez wrote: > Well, it's not far-fetching to understand that on non-plasma systems this > KCM will be

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 1:38 a.m., Aleix Pol Gonzalez wrote: > > Would it be possible to get this as a KWidgetsAddons patch? It seems like > > it could easily be turned into a `KStyleSelectorMenu`. > > René J.V. Bertin wrote: > True, and the same would go for the "Theme" (colour palette) menu

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread Martin Gräßlin
> On May 31, 2016, 10:51 a.m., Milian Wolff wrote: > > -2 > > > > kdevelop should use the global widget style. if you don't want that, change > > it via systemsettings > > Aleix Pol Gonzalez wrote: > Well, it's not far-fetching to understand that on non-plasma systems this > KCM will be

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128056/#review96083 --- I suggest to look at

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 10:51 a.m., Milian Wolff wrote: > > -2 > > > > kdevelop should use the global widget style. if you don't want that, change > > it via systemsettings > > Aleix Pol Gonzalez wrote: > Well, it's not far-fetching to understand that on non-plasma systems this > KCM will be

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread Aleix Pol Gonzalez
> On May 31, 2016, 1:38 a.m., Aleix Pol Gonzalez wrote: > > Would it be possible to get this as a KWidgetsAddons patch? It seems like > > it could easily be turned into a `KStyleSelectorMenu`. > > René J.V. Bertin wrote: > True, and the same would go for the "Theme" (colour palette) menu

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread Aleix Pol Gonzalez
> On May 31, 2016, 10:51 a.m., Milian Wolff wrote: > > -2 > > > > kdevelop should use the global widget style. if you don't want that, change > > it via systemsettings Well, it's not far-fetching to understand that on non-plasma systems this KCM will be hidden or unavailable. Linux's Skype

Re: Review Request 128065: move glass theme to kde-look.

2016-05-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128065/#review96078 --- where will Glass be developed now? Is a tarball enough? -

Jenkins-kde-ci: kapidox master kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

2016-05-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kapidox%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 10:05:31 + Build duration: 2 min 32 sec CHANGE SET Revision

Jenkins-kde-ci: kapidox master kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

2016-05-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kapidox%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 10:05:31 + Build duration: 2 min 32 sec CHANGE SET Revision

Jenkins-kde-ci: kapidox master stable-kf5-qt5 » Linux,gcc - Build # 26 - Fixed!

2016-05-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kapidox%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/26/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 10:05:31 + Build duration: 24 sec CHANGE SET Revision

Jenkins-kde-ci: kapidox master stable-kf5-qt5 » Linux,gcc - Build # 26 - Fixed!

2016-05-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kapidox%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/26/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 10:05:31 + Build duration: 24 sec CHANGE SET Revision

Jenkins-kde-ci: kapidox master stable-kf5-qt5 » Linux,gcc - Build # 25 - Still Failing!

2016-05-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kapidox%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 10:02:46 + Build duration: 17 sec CHANGE SET Revision

Jenkins-kde-ci: kapidox master kf5-qt5 » Linux,gcc - Build # 24 - Still Failing!

2016-05-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kapidox%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 10:02:46 + Build duration: 18 sec CHANGE SET Revision 8f24b0c558df14e12b5b64a409c97975f3fddc76 by

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 63 - Unstable!

2016-05-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/63/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 31 May 2016 09:27:16 + Build duration: 2 min 58 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 63 - Unstable!

2016-05-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/63/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 31 May 2016 09:27:16 + Build duration: 2 min 52 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 62 - Unstable!

2016-05-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/62/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 31 May 2016 09:27:16 + Build duration: 2 min 41 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 62 - Unstable!

2016-05-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/62/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 31 May 2016 09:27:16 + Build duration: 2 min 32 sec CHANGE

Re: QGlobalStatic and windowing specific calls in dtor

2016-05-31 Thread Martin Graesslin
On Monday, May 30, 2016 5:50:23 PM CEST Aleix Pol wrote: > On Mon, May 30, 2016 at 4:25 PM, Martin Graesslin wrote: > > Hi frameworks-dev, > > > > I have a problem with my KWayland based plugin for KIdleTime. KIdleTime > > uses a QGlobalStatic, so it gets destroyed at

Jenkins-kde-ci: kapidox master kf5-qt5 » Linux,gcc - Build # 22 - Failure!

2016-05-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kapidox%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 08:55:30 + Build duration: 17 sec CHANGE SET Revision bb4063f5d9f9015b86dbc3a48a424c8cb1a8193f by

Jenkins-kde-ci: kapidox master stable-kf5-qt5 » Linux,gcc - Build # 23 - Failure!

2016-05-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kapidox%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 May 2016 08:55:30 + Build duration: 18 sec CHANGE SET Revision

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128056/#review96077 --- -2 kdevelop should use the global widget style. if you

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128056/ --- (Updated May 31, 2016, 10:48 a.m.) Review request for KDE Software on

Review Request 128065: move glass theme to kde-look.

2016-05-31 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128065/ --- Review request for KDE Frameworks and Andreas Kainz. Repository:

Re: The return of ASAN issues

2016-05-31 Thread Ben Cooksley
On Tue, May 31, 2016 at 9:36 AM, Albert Astals Cid wrote: > El dilluns, 30 de maig de 2016, a les 19:42:38 CEST, Ben Cooksley va escriure: >> Hi all, >> >> As you may recall, some time ago the CI scripts were adapted to >> forcibly inject ASAN into all test processes launched on

Re: The return of ASAN issues

2016-05-31 Thread Ben Cooksley
On Mon, May 30, 2016 at 10:51 PM, Friedrich W. H. Kossebau wrote: > Hi, Hi Friedrich, > > Am Montag, 30. Mai 2016, 19:42:38 CEST schrieb Ben Cooksley: >> As you may recall, some time ago the CI scripts were adapted to >> forcibly inject ASAN into all test processes launched on

Re: kwindowsystem crashes

2016-05-31 Thread Martin Graesslin
On Monday, May 30, 2016 11:36:54 AM CEST Kurt Hindenburg wrote: > There are a number of lines that division by zero could happen in > frameworks/kwindowsystem/src/platforms/xcb/kwindowsystem.cpp if > displayGeometry returns a 0 QRect. I think that is what is happening with > bug 349512. urgh.