Re: Review Request 128164: Use QIcon for background icon for folder thumbnails

2016-06-12 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128164/ --- (Updated June 13, 2016, 8:56 a.m.) Status -- This change has been ma

Re: Review Request 128161: Make epoxy optional instead of just hacking it out for Windows

2016-06-12 Thread Christoph Cullmann
> On June 13, 2016, 5:39 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 76-78 > > > > > > instead of adding a definition could you make it a configure file? Sure, is that the prefered way? I thought adding

Re: Review Request 128161: Make epoxy optional instead of just hacking it out for Windows

2016-06-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128161/#review96397 --- CMakeLists.txt (lines 74 - 76)

Re: Review Request 128102: Set encoding on kconfig_compiler generated cpp and headers to utf-8 ( reproducible )

2016-06-12 Thread Scarlett Clark
> On June 11, 2016, 6:20 p.m., Albert Astals Cid wrote: > > Have you tried if this is needed for the KDE Frameworks version of the > > kconfig_compiler? I will into that today, thank - Scarlett --- This is an automatically generated e-

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

2016-06-12 Thread Albert Astals Cid
El diumenge, 12 de juny de 2016, a les 20:29:56 CEST, Christoph Cullmann va escriure: > Hi, > > > Having KMessageBox "dontShowMeAgain" feature depend on an integration > > plugin is a very bad idea. > > > > Basically it means programs that use KMessageBox can never asusme it will > > work so bas

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

2016-06-12 Thread Mark Gaiser
On Sun, Jun 12, 2016 at 7:51 PM, Albert Astals Cid wrote: > Having KMessageBox "dontShowMeAgain" feature depend on an integration > plugin > is a very bad idea. > > Basically it means programs that use KMessageBox can never asusme it will > work > so basically they have to use alternative methods

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

2016-06-12 Thread Albert Astals Cid
El diumenge, 12 de juny de 2016, a les 20:38:28 CEST, Hugo Pereira Da Costa va escriure: > On 06/12/2016 07:51 PM, Albert Astals Cid wrote: > > Having KMessageBox "dontShowMeAgain" feature depend on an integration > > plugin is a very bad idea. > > > > Basically it means programs that use KMessag

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

2016-06-12 Thread Boudhayan Gupta
On 13 June 2016 at 00:08, Hugo Pereira Da Costa wrote: > On 06/12/2016 07:51 PM, Albert Astals Cid wrote: >> >> Having KMessageBox "dontShowMeAgain" feature depend on an integration >> plugin >> is a very bad idea. >> >> Basically it means programs that use KMessageBox can never asusme it will >>

Re: Review Request 128164: Use QIcon for background icon for folder thumbnails

2016-06-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128164/#review96386 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 12, 2016

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

2016-06-12 Thread Hugo Pereira Da Costa
On 06/12/2016 07:51 PM, Albert Astals Cid wrote: Having KMessageBox "dontShowMeAgain" feature depend on an integration plugin is a very bad idea. Basically it means programs that use KMessageBox can never asusme it will work so basically they have to use alternative methods to have the "dontShow

Review Request 128164: Use QIcon for background icon for folder thumbnails

2016-06-12 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128164/ --- Review request for KDE Frameworks and Plasma. Bugs: 364253 https://bu

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

2016-06-12 Thread Christoph Cullmann
Hi, > Having KMessageBox "dontShowMeAgain" feature depend on an integration plugin > is a very bad idea. > > Basically it means programs that use KMessageBox can never asusme it will work > so basically they have to use alternative methods to have the > "dontShowMeAgain" feature or not have it at

Re: The return of ASAN issues

2016-06-12 Thread Albert Astals Cid
El dimarts, 31 de maig de 2016, a les 18:49:29 CEST, Ben Cooksley va escriure: > On Tue, May 31, 2016 at 9:36 AM, Albert Astals Cid wrote: > > El dilluns, 30 de maig de 2016, a les 19:42:38 CEST, Ben Cooksley va escriure: > >> Hi all, > >> > >> As you may recall, some time ago the CI scripts wer

KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

2016-06-12 Thread Albert Astals Cid
Having KMessageBox "dontShowMeAgain" feature depend on an integration plugin is a very bad idea. Basically it means programs that use KMessageBox can never asusme it will work so basically they have to use alternative methods to have the "dontShowMeAgain" feature or not have it at all. I under

Re: Review Request 128083: Find CPUs by subsystem rather than driver

2016-06-12 Thread David Faure
On mardi 7 juin 2016 11:46:47 CEST Rohan Garg wrote: > > On June 7, 2016, 3:03 a.m., Rohan Garg wrote: > > > Hi > > > Could we get a shipit on these? I'd really appreciate it if we could > > > have these in Frameworks 5.23> > > Martin Gräßlin wrote: > > I don't want to disappoint you, but it's

Review Request 128159: Suggest to use setupGUI() instead of setXMLFile()

2016-06-12 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128159/ --- Review request for KDE Frameworks and David Faure. Repository: kparts D

Review Request 128161: Make epoxy optional instead of just hacking it out for Windows

2016-06-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128161/ --- Review request for KDE Frameworks and Marco Martin. Repository: kdeclarat

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 74 - Fixed!

2016-06-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/74/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 12 Jun 2016 14:31:47 + Build duration: 4 min 44 sec CHANGE SET Revisio

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 74 - Fixed!

2016-06-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/74/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 12 Jun 2016 14:31:47 + Build duration: 4 min 44 sec CHANGE SET Revisio

Re: Review Request 127694: Add a Find module for WaylandProtocols

2016-06-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127694/#review96376 --- What projects are wanting to use this? There should be at lea

Re: Review Request 127959: Adding missing license

2016-06-12 Thread Martin Tobias Holmedahl Sandsmark
> On May 19, 2016, 3:35 p.m., Martin Gräßlin wrote: > > I would prefer that we properly investigate each of the cases. E.g. > > plasma-framework showed that the files are just incorrectly licensed. this would probably be optimal, and there's some of those files that could probably be removed (

Re: Review Request 127959: Adding missing license

2016-06-12 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127959/#review96370 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark O