Re: Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

> On Jan. 15, 2016, 7:20 a.m., Martin Gräßlin wrote: > > > The KIconDialog itself works fine, but the "Browse..." sub dialog, which > > > is a grand child of the modal dialog, is opened in the background and > > > cannot be used > > > > this sounds like a Qt bug or a KFileDialog bug. The sub

[Differential] [Request, 2 lines] D1942: [KIconDialog] Do not clear search line when switching category

cfeck created this revision. cfeck added reviewers: Frameworks, htietze, colomar. REVISION SUMMARY The dialog to choose an icon has a "Search:" line. The search line is used when a user is trying to find an icon. When something is typed there, only icon with names containing the search string

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 147 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/147/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 23:56:40 + Build duration: 25 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 147 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/147/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 23:56:40 + Build duration: 25 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 63 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/63/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 22:20:53 + Build duration: 26 min CHANGE SET No changes JUNIT RESULTS

Review Request 128233: Don't trust files claiming to be created on unix more than other files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128233/ --- Review request for KDE Frameworks and David Faure. Repository: karchive

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 58 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 22:15:56 + Build duration: 2 min 9 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 58 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 22:15:56 + Build duration: 2 min 9 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 68 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/68/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 22:15:56 + Build duration: 6 min 0 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 72 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/72/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 22:15:12 + Build duration: 6 min 17 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 72 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/72/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 22:15:12 + Build duration: 6 min 17 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 146 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/146/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 21:32:16 + Build duration: 32 min CHANGE SET Revision

Releasing prison with next frameworks

Hi peoples After a final round of api changes in libprison, I think it is just a version number bump away from being release d with next round of framework releases, and thus going from the previous kdesupport area and into a real framework. What are the exact steps needed? /Sune

Re: Review Request 128120: Use KRun for open Url.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128120/#review96648 --- Ship it! Ship It! - David Faure On June 7, 2016, 3:07

Re: Adding Android Platform Availability to Frameworks

On jeudi 16 juin 2016 15:47:26 CEST Andreas Cord-Landwehr wrote: > Hi, after the recent preparations, finally I would like to get permission to > add the line " - name: Android" to the platforms section in the > metainfo.yaml files of the following frameworks: > > attica > kapidox > karchive >

Re: Review Request 127004: OpenFileManagerWindowJob

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127004/ --- (Updated June 17, 2016, 7:53 p.m.) Status -- This change has been

Re: Review Request 128225: Update KAbstractFileItemActionPlugin apidox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128225/ --- (Updated June 17, 2016, 7:22 p.m.) Status -- This change has been

Re: Review Request 128225: Update KAbstractFileItemActionPlugin apidox

> On June 17, 2016, 6:58 p.m., David Faure wrote: > > src/widgets/kabstractfileitemactionplugin.h, line 86 > > > > > > Is there even a reason to suggest this? Why would someone "want" to > > install it in

Re: Review Request 128225: Update KAbstractFileItemActionPlugin apidox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128225/#review96642 --- Fix it, then Ship it!

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

> On June 17, 2016, 1:36 a.m., David Faure wrote: > > src/core/installation.cpp, line 365 > > > > > > Should this code get support for "appdata" then? > > (typically share/kmyapp) > > > >

Re: Review Request 128225: Update KAbstractFileItemActionPlugin apidox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128225/ --- (Updated June 17, 2016, 4:17 p.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 142 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/142/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 12:09:48 + Build duration: 32 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 142 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/142/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 12:09:48 + Build duration: 32 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 138 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/138/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 11:22:39 + Build duration: 31 min CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 138 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/138/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 11:22:39 + Build duration: 31 min CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 141 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/141/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 11:17:45 + Build duration: 35 min CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 137 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/137/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 10:12:54 + Build duration: 32 min CHANGE SET No changes JUNIT RESULTS

Re: Review Request 127004: OpenFileManagerWindowJob

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127004/ --- (Updated Juni 17, 2016, 10:43 vorm.) Review request for KDE Frameworks,

Re: Review Request 128210: Enable Threadweaver to build on Android

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128210/ --- (Updated June 17, 2016, 10:36 a.m.) Status -- This change has been

Re: Review Request 128210: Enable Threadweaver to build on Android

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128210/#review96625 --- Ship it! Ship It! - Milian Wolff On June 16, 2016,

Re: Review Request 127004: WIP: OpenFileManagerWindowJob

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127004/#review96624 --- src/widgets/openfilemanagerwindowjob.h (line 44)

Re: Review Request 128216: [QueryMatch] Add iconName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128216/ --- (Updated June 17, 2016, 12:38 p.m.) Status -- This change has been

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 136 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/136/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 08:58:08 + Build duration: 30 min CHANGE SET Revision

[Differential] [Closed] D1924: KXMLGui: Fix merge indices when removing xmlgui clients with actions in groups.

dfaure closed this revision. dfaure marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D1924 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, svuorela, dhaumann Cc: kde-frameworks-devel

[Differential] [Updated] D1924: KXMLGui: Fix merge indices when removing xmlgui clients with actions in groups.

dfaure marked 2 inline comments as done. dfaure added inline comments. INLINE COMMENTS > dhaumann wrote in kxmlgui_unittest.cpp:305 > Interesting, this looks as if there were invalid reads before? Not exactly. QList's [i] asserts when called out of bounds. It didn't happen before, because when

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 135 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/135/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 08:18:30 + Build duration: 24 min CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 135 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/135/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 08:18:30 + Build duration: 24 min CHANGE SET Revision

[Differential] [Commented On] D1924: KXMLGui: Fix merge indices when removing xmlgui clients with actions in groups.

svuorela added inline comments. INLINE COMMENTS > kxmlgui_unittest.cpp:306 > +if (i >= actions.count()) > +break; > +QAction *action = actions.at(i); Isn't it better to move the last QCOMPARE(count,count); up first? Or is it to be able to easier debug if something

[Differential] [Accepted] D1924: KXMLGui: Fix merge indices when removing xmlgui clients with actions in groups.

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I think this patch looks good (given we sat in front of this issue together, I think I also know what's going on). There are still open questions, but that's rather unrelated to this

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128219/#review96621 --- src/core/installation.cpp (line 365)