Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

2016-07-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128300/ --- (Updated July 5, 2016, 6:08 a.m.) Status -- This change has been mar

Re: Review Request 127813: Reduce string modifications when calling translatePath

2016-07-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/ --- (Updated July 5, 2016, 12:36 a.m.) Review request for KDE Frameworks and

Re: Review Request 128369: Handle multiple gzip streams in a single file

2016-07-04 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128369/ --- (Updated July 4, 2016, 10:33 p.m.) Review request for KDE Frameworks and

Re: Review Request 128369: Handle multiple gzip streams in a single file

2016-07-04 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128369/ --- (Updated July 4, 2016, 10:33 p.m.) Review request for KDE Frameworks and

Re: Review Request 128369: Handle multiple gzip streams in a single file

2016-07-04 Thread Martin Tobias Holmedahl Sandsmark
> On July 4, 2016, 9:39 p.m., David Faure wrote: > > src/kgzipfilter.cpp, line 331 > > > > > > This is where you could add something like > > if (avail_in < 10) { > > return Ok; // come back

Re: Review Request 128369: Handle multiple gzip streams in a single file

2016-07-04 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128369/ --- (Updated July 4, 2016, 9:57 p.m.) Review request for KDE Frameworks and S

Re: Review Request 127813: Reduce string modifications when calling translatePath

2016-07-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/#review97083 --- src/core/kconfiggroup.cpp (line 426)

Re: Review Request 128369: Handle multiple gzip streams in a single file

2016-07-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128369/#review97103 --- Nice ! src/kgzipfilter.cpp (line 331)

Review Request 128369: Handle multiple gzip streams in a single file

2016-07-04 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128369/ --- Review request for KDE Frameworks and Sune Vuorela. Repository: karchive

Re: Review Request 128233: Don't trust files claiming to be created on unix more than other files

2016-07-04 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128233/ --- (Updated July 4, 2016, 6:38 p.m.) Status -- This change has been mar

Re: Review Request 128353: Unit tests of directory permissions in zip files

2016-07-04 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128353/ --- (Updated July 4, 2016, 6:27 p.m.) Status -- This change has been mar

Re: Review Request 128353: Unit tests of directory permissions in zip files

2016-07-04 Thread Sune Vuorela
> On July 3, 2016, 8:25 p.m., David Faure wrote: > > autotests/karchivetest.cpp, line 1118 > > > > > > Why QLatin1String("") and not just QString() ? Previous unit test does the same - Sune

Re: Review Request 127813: Reduce string modifications when calling translatePath

2016-07-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/ --- (Updated July 4, 2016, 4:05 p.m.) Review request for KDE Frameworks and M

Re: Review Request 128357: Fix warning from uic

2016-07-04 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128357/ --- (Updated July 4, 2016, 1:59 p.m.) Status -- This change has been mar

Re: Review Request 127813: Reduce string modifications when calling translatePath

2016-07-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/#review97082 --- src/core/kconfiggroup.cpp (line 420)

Re: Review Request 128357: Fix warning from uic

2016-07-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128357/#review97081 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 4, 2016,

Re: Review Request 127813: Reduce string modifications when calling translatePath

2016-07-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/ --- (Updated July 4, 2016, 3:48 p.m.) Review request for KDE Frameworks and M

Review Request 128357: Fix warning from uic

2016-07-04 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128357/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu

Re: Review Request 127093: Drop KDocTools requirement

2016-07-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127093/ --- (Updated July 4, 2016, 3:32 p.m.) Status -- This change has been dis

Re: Review Request 127110: Drop KF5DocTools dependency

2016-07-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127110/ --- (Updated July 4, 2016, 3:31 p.m.) Status -- This change has been dis

Re: Review Request 128316: Make use of QQuickItem::setSize instead of width and height indpedently.

2016-07-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128316/ --- (Updated July 4, 2016, 10:06 a.m.) Status -- This change has been ma

Re: Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

2016-07-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128300/#review97078 --- Ship it! Ship It! - Marco Martin On June 28, 2016, 11:4

Re: Review Request 128260: Verify that QWindow::fromWinId returned a QWindow before using it

2016-07-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128260/ --- (Updated July 4, 2016, 8:06 a.m.) Status -- This change has been mar

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 129 - Fixed!

2016-07-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/129/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 04 Jul 2016 07:36:40 + Build duration: 1 min 13 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 129 - Fixed!

2016-07-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/129/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 04 Jul 2016 07:36:40 + Build duration: 1 min 13 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 128 - Failure!

2016-07-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/128/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 04 Jul 2016 07:25:35 + Build duration: 12 sec CHANGE SET No changes