Re: Is it able to make kservice's weightedOffers public access?

2016-07-10 Thread Leslie Zhai
Hi David, Thanks for your suggestion ;-) https://github.com/isoft-linux/plasma-workspace/commit/bef267249ee99b0ac4eafaa75116bfda5d2c1daf On 2016年07月08日 19:14, David Faure wrote: On vendredi 8 juillet 2016 09:04:54 CEST zhaixiang wrote: KService::List services; const KServiceOfferList offers

Re: kded's cmake package

2016-07-10 Thread Christophe Giboudeaux
Hi, On mercredi 29 juin 2016 11:22:30 CEST Harald Sitter wrote: > Hola! > > So, I just noticed that KDED's cmake package is inconsistently named. > > cmake/KF5DocTools/ > versus > cmake/KDED/ > > Is there a reason for this? Are we going to change this for KF6? > No and that sounds curious.

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-07-10 Thread Thomas Pfeiffer
> On July 9, 2016, 1:05 p.m., Ragnar Thomsen wrote: > > Another post-commit suggestion: > > - The "Share" label is not obvious to me. This was also pointed out by > > another user on the [blog post](http://www.aelog.org/checksums-made-easy). > > Something like "Calculated checksums" would

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-10 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/#review97264 --- +1, makes it even easier! - Thomas Pfeiffer On July 9,

Re: Review Request 128420: Name supported platforms in YAML file.

2016-07-10 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128420/ --- (Updated July 10, 2016, 5:44 p.m.) Status -- This change has been

Re: Review Request 128420: Name supported platforms in YAML file.

2016-07-10 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128420/#review97259 --- Ship it! Ship It! - Sune Vuorela On July 10, 2016,

Re: Review Request 128412: Port away from NetAccess

2016-07-10 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128412/ --- (Updated July 10, 2016, 5:05 a.m.) Status -- This change has been

Re: Review Request 128412: Port away from NetAccess

2016-07-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128412/#review97254 --- Ship it! Thanks, that's already much better. - David

Re: Review Request 128412: Port away from NetAccess

2016-07-10 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128412/ --- (Updated July 10, 2016, 11:33 a.m.) Review request for KDE Frameworks,

Re: Review Request 128412: Port away from NetAccess

2016-07-10 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128412/ --- (Updated July 10, 2016, 11:32 a.m.) Review request for KDE Frameworks,

Review Request 128420: Name supported platforms in YAML file.

2016-07-10 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128420/ --- Review request for KDE Frameworks. Repository: knotifications

Re: Review Request 127106: applications.menu: remove references to unused categories

2016-07-10 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127106/ --- (Updated July 10, 2016, 9:38 a.m.) Status -- This change has been

Re: Review Request 128412: Port away from NetAccess

2016-07-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128412/#review97252 --- The port seems fine, you can commit it as is if you want,

Re: Review Request 127106: applications.menu: remove references to unused categories

2016-07-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127106/#review97251 --- Ship it! Ship It! - David Faure On March 28, 2016,

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-10 Thread Michel Hermier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/#review97249 --- I don't see the point of this change. From a user