Re: Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

2016-07-11 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128427/#review97303 --- Works here, thanks - Antonio Rojas On Jul. 12, 2016, 12:21

Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2016-07-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128426/#review97302 --- What about shader variants for GLES? There are also two versi

Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2016-07-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128426/#review97299 --- Looks like an interesting optimization oportunity! :) src/d

Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

2016-07-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128427/ --- Review request for Extra Cmake Modules, KDE Frameworks and Antonio Rojas.

Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2016-07-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128426/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

2016-07-11 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/#review97294 --- Is this same as https://bugs.kde.org/show_bug.cgi?id=365355

Re: Review Request 127204: [KHintSettings] Disable setting the palette on-the-fly

2016-07-11 Thread Anthony Fieroni
> On Feb. 28, 2016, 2:30 p.m., David Faure wrote: > > Why not fix this in Qt? What's the associated Qt bug report, at least? > > Anthony Fieroni wrote: > I can't find bug report. I can confirm this happens on radeon oss, i have > 2 systems on it. Only this -> > http://www.qtcentre.org/thre

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-07-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/ --- (Updated July 11, 2016, 4:15 p.m.) Status -- This change has been di

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-07-11 Thread Kevin Funk
> On April 18, 2016, 11:05 a.m., Gleb Popov wrote: > > Let's do something about this. I see two solutions for this: > > > > - Add another macro. If we go this route, can we put it in the same .cmake > > file? > > - Add a keyword parameter to the existing macro. Because macro uses > > `${ARGN}`

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 133 - Fixed!

2016-07-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/133/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jul 2016 10:18:51 + Build duration: 8 min 42 sec CHANGE SET Revision 85ce83300086e72fbfcba97ad49f3bd48a675378 b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 133 - Fixed!

2016-07-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/133/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 11 Jul 2016 10:18:51 + Build duration: 8 min 42 sec CHANGE SET Revision 85ce83300086e72fbfcba97ad49f3bd48a675378 b

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-11 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/#review97287 --- Ship it! Looks good to me. I suggest making a the calcula