Jenkins-kde-ci: kparts master kf5-qt5 » Linux,gcc - Build # 159 - Fixed!

2016-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/159/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 22:30:12 + Build duration: 3 min 9 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kparts master kf5-qt5 » Linux,gcc - Build # 159 - Fixed!

2016-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/159/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 22:30:12 + Build duration: 3 min 9 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

2016-07-24 Thread Garret Wassermann
> On July 23, 2016, 8:29 a.m., Olivier Churlaud wrote: > > It seems good to me. > > > > If you are not told to hold this patch before friday, take it for a "Ship > > it" (and don't forget to add a line "REVIEW: 12" in your commit message) Hi, I made the change. Also, I do not have commit r

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

2016-07-24 Thread Garret Wassermann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- (Updated July 24, 2016, 6:43 p.m.) Review request for KDE Frameworks and

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-24 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/ --- (Updated July 24, 2016, 10:07 p.m.) Status -- This change has been m

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-07-24 Thread David Faure
> On July 24, 2016, 9:26 p.m., Friedrich W. H. Kossebau wrote: > > Please also try those other smoke unit tests. > > I do not remember things detailed right now, but possibly > > `resetInternalData();` resulted in lots of signal emitted due to > > rowinserted or something, which broke at least

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-07-24 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/#review97808 --- Please also try those other smoke unit tests. I do not rememb

Re: Review Request 128477: Do not delete system relevant files in tests (if we might succeed)

2016-07-24 Thread David Faure
> On July 18, 2016, 9:30 p.m., David Faure wrote: > > Wow, it never occured to me that someone might run this test as root. I > > thought it was well known that development should not be done as root ;) > > But I can see how it might happen when creating packages with unittests > > enabled or s

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

2016-07-24 Thread David Faure
> On July 21, 2016, 5:43 a.m., Sune Vuorela wrote: > > I tried writing a small test for it, and it seemed like I could reproduce > > the issue. But my test didn't pass when I added this changeset. > > > > Maybe I should publish my test case somewhere... > > Sune Vuorela wrote: > https://gi

Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-07-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/ --- Review request for KDE Frameworks, Friedrich W. H. Kossebau, Stephen Kelly,

Re: Review Request 128513: Unittest for content test of kdescendantsproxymodel

2016-07-24 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128513/ --- (Updated July 24, 2016, 8:44 p.m.) Status -- This change has been ma

Jenkins-kde-ci: kparts master kf5-qt5 » Linux,gcc - Build # 158 - Unstable!

2016-07-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/158/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 15:24:34 + Build duration: 4 min 12 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Re: Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 58 - Still Unstable!

2016-07-24 Thread Christoph Feck
On Sunday 24 July 2016 16:06:52 no-re...@kde.org wrote: > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFO > RM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc > Date of build: Sun, 24 Jul 2016 13:32:28 + > Build duration: 5 min 41 sec

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 92 - Fixed!

2016-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/92/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 13:43:48 + Build duration: 3 min 22 sec CHANGE SET Revision 914db02a24e38997605a7199471d6fd71c6bf0

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 92 - Fixed!

2016-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/92/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 13:43:48 + Build duration: 3 min 22 sec CHANGE SET Revision 914db02a24e38997605a7199471d6fd71c6bf0

Jenkins-kde-ci: kdesignerplugin master kf5-qt5 » Linux,gcc - Build # 46 - Unstable!

2016-07-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdesignerplugin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/46/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 13:41:58 + Build duration: 1 min 7 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 91 - Fixed!

2016-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/91/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 13:39:18 + Build duration: 3 min 35 sec CHANGE SET Revision 914db02a24e38997605a7199471d6fd

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 91 - Fixed!

2016-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/91/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 13:39:18 + Build duration: 3 min 35 sec CHANGE SET Revision 914db02a24e38997605a7199471d6fd

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 58 - Still Unstable!

2016-07-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 13:32:28 + Build duration: 5 min 41 sec CHANGE SET Revision d151626183973d071e6c4f8ceaaf1b2

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 153 - Fixed!

2016-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/153/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 13:30:49 + Build duration: 5 min 22 sec CHANGE SET Revision a7ffccf1d8cbf4f641e28b4de679d027284bd1fd b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 153 - Fixed!

2016-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/153/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 13:30:49 + Build duration: 5 min 22 sec CHANGE SET Revision a7ffccf1d8cbf4f641e28b4de679d027284bd1fd b

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 91 - Still Unstable!

2016-07-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/91/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 13:26:37 + Build duration: 3 min 33 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 90 - Still Unstable!

2016-07-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/90/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 13:25:37 + Build duration: 3 min 25 sec CHANGE SET No changes JUNIT RESULTS Nam

Review Request 128514: KIconLoader: reduce number of lookups when doing fallbacks

2016-07-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128514/ --- Review request for KDE Frameworks, Aleix Pol Gonzalez and Christoph Feck.

Re: Review Request 128513: Unittest for content test of kdescendantsproxymodel

2016-07-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128513/#review97796 --- Fix it, then Ship it! I suggest running astyle-kdelibs ove

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 152 - Unstable!

2016-07-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/152/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 11:35:08 + Build duration: 9 min 41 sec CHANGE SET Revision 80ea2009095011e59a742815ee583e71cfc75756

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

2016-07-24 Thread Sune Vuorela
> On July 21, 2016, 5:43 a.m., Sune Vuorela wrote: > > I tried writing a small test for it, and it seemed like I could reproduce > > the issue. But my test didn't pass when I added this changeset. > > > > Maybe I should publish my test case somewhere... https://git.reviewboard.kde.org/r/128513

Review Request 128513: Unittest for content test of kdescendantsproxymodel

2016-07-24 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128513/ --- Review request for KDE Frameworks, David Faure, Friedrich W. H. Kossebau, a

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 150 - Fixed!

2016-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/150/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 10:06:28 + Build duration: 6 min 22 sec CHANGE SET Revision 09d6d77448fbb4d56877383cad7edd1ede8

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 150 - Fixed!

2016-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/150/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 10:06:28 + Build duration: 6 min 22 sec CHANGE SET Revision 09d6d77448fbb4d56877383cad7edd1ede8

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 150 - Fixed!

2016-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/150/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 10:06:28 + Build duration: 6 min 29 sec CHANGE SET Revision 09d6d77448fbb4d56877383cad7edd1ede825772 b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 150 - Fixed!

2016-07-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/150/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 10:06:28 + Build duration: 6 min 29 sec CHANGE SET Revision 09d6d77448fbb4d56877383cad7edd1ede825772 b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 149 - Still Unstable!

2016-07-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/149/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 09:51:29 + Build duration: 7 min 21 sec CHANGE SET Revision dc8588efe72a5ca7670d0371537d99a0d4c690f5

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 149 - Still Unstable!

2016-07-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/149/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 09:44:31 + Build duration: 6 min 42 sec CHANGE SET Revision dc8588efe72a5ca7670d0371537d99a0d4

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 148 - Unstable!

2016-07-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/148/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 09:38:49 + Build duration: 12 min CHANGE SET Revision 99e643bbb86684f7bc740944183bba11d608fb0e by Dav

Re: Review Request 128510: KNewFileMenu: fix copying template file from embedded resource

2016-07-24 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128510/ --- (Updated July 24, 2016, 9:44 a.m.) Status -- This change has been ma

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 148 - Still Unstable!

2016-07-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/148/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 24 Jul 2016 09:38:49 + Build duration: 4 min 41 sec CHANGE SET Revision 99e643bbb86684f7bc740944183bba11d6

Re: Review Request 128510: KNewFileMenu: fix copying template file from embedded resource

2016-07-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128510/#review97790 --- Ship it! OK the bug wasn't that storedPut can't handle qrc

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-24 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/#review97788 --- If there are no objections by today, I'm going to ship this.