Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-01 Thread Anthony Fieroni
> On Юли 31, 2016, 12:47 след обяд, David Faure wrote: > > src/widgets/fileundomanager.cpp, line 421 > > > > > > Why the isEmpty() check? > > Chinmoy Ranjan Pradhan wrote: > For KIO::SimpleJob opStack is emp

Review Request 128566: [xcb] Use a KSelectionWatcher to monitor the compositing selection

2016-08-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128566/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 128566: [xcb] Use a KSelectionWatcher to monitor the compositing selection

2016-08-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128566/#review97974 --- For testing against a stable version, please also include the

Re: Review Request 128566: [xcb] Use a KSelectionWatcher to monitor the compositing selection

2016-08-01 Thread Martin Gräßlin
> On Aug. 1, 2016, 3:42 p.m., Martin Gräßlin wrote: > > For testing against a stable version, please also include the following two > > commits: > > 7b24b834384a1524d8c2126416916a62048107cc > > e5b2a8b2506adbfa2a659afd5d8cb9aa28db22dd patch with those commits included: https://paste.kde.org/p

Re: Review Request 128566: [xcb] Use a KSelectionWatcher to monitor the compositing selection

2016-08-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128566/#review97976 --- I applied this RB ontop of kwindowsystem master, logged out a

Re: Review Request 128307: [KDeclarative] [KCMShell Proxy] Use KToolInvocation::kdeinitExec instead of QProcess::startDetached

2016-08-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128307/ --- (Updated Aug. 1, 2016, 3:12 nachm.) Status -- This change has been d

Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

2016-08-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128567/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

2016-08-01 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128567/#review97981 --- src/kwindowsystem.h (line 625)

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

2016-08-01 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128567/#review97984 --- I like the concept, and besides ivan's questions, I have also

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

2016-08-01 Thread Martin Gräßlin
> On Aug. 1, 2016, 10:36 p.m., Sune Vuorela wrote: > > src/kwindowsystem.h, line 587 > > > > > > Something about the word platform feels wrong here. But windowsystem > > also feels a bit wrong. But I guess Platf

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

2016-08-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128567/ --- (Updated Aug. 2, 2016, 7:47 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

2016-08-01 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128567/#review97991 --- No further comments from here. I'll give Ivan chance for him