Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-04 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/ --- (Updated Aug. 5, 2016, 1:32 a.m.) Review request for KDE Frameworks and D

Re: Review Request 128606: [kapidox] Read library fancyname from metainfo.yaml before parsing it from CMakeLists.txt

2016-08-04 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128606/ --- (Updated Aug. 5, 2016, 2:11 a.m.) Status -- This change has been mar

Re: Review Request 128606: [kapidox] Read library fancyname from metainfo.yaml before parsing it from CMakeLists.txt

2016-08-04 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128606/#review98123 --- Ship it! I was thinking of doing exactly this for cases wh

Review Request 128606: [kapidox] Read library fancyname from metainfo.yaml before parsing it from CMakeLists.txt

2016-08-04 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128606/ --- Review request for KDE Frameworks and Olivier Churlaud. Repository: kapid

Re: Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

2016-08-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128581/ --- (Updated Aug. 4, 2016, 10:40 p.m.) Review request for KDE Frameworks, Chr

Re: Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

2016-08-04 Thread Albert Astals Cid
> On Aug. 4, 2016, 6:12 a.m., Christoph Feck wrote: > > src/kmessagebox_p.cpp, line 45 > > > > > > If I understand the QGlobalStatic documentation correctly, the > > destructor is called after the QApplication ob

Re: Review Request 128597: support a size for adding applets

2016-08-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/#review98121 --- Ship it! Ship It! - David Edmundson On Aug. 4, 2016, 9:

Re: Review Request 128603: Infer the ParentApp from the PackageStructure plugin

2016-08-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128603/#review98120 --- Fix it, then Ship it! src/kpackagetool/kpackagetool.cpp (

Re: Review Request 128597: support a size for adding applets

2016-08-04 Thread Marco Martin
> On Aug. 4, 2016, 1:28 p.m., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 248 > > > > > > QSize::isNull > > > > "Returns true if both the width and height is

Re: Review Request 128597: support a size for adding applets

2016-08-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/ --- (Updated Aug. 4, 2016, 9:11 p.m.) Review request for KDE Frameworks and P

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

2016-08-04 Thread Kai Uwe Broulik
> On Aug. 3, 2016, 10:18 nachm., David Edmundson wrote: > > src/mass.cpp, line 268 > > > > > > one of these should be "%1 stones" (with extra 's') > > David Jarvie wrote: > No, it's normally 'stone' for the

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

2016-08-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128595/#review98117 --- Ship it! ship it! (with albert's comment addressed) - Da

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 123 - Fixed!

2016-08-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/123/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 04 Aug 2016 19:37:01 + Build duration: 14 min CHANGE SET Revision 3ba6efa

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 123 - Fixed!

2016-08-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/123/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 04 Aug 2016 19:37:01 + Build duration: 14 min CHANGE SET Revision 3ba6efa

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 123 - Fixed!

2016-08-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/123/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 04 Aug 2016 19:37:01 + Build duration: 14 min CHANGE SET Revision 3ba

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 123 - Fixed!

2016-08-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/123/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 04 Aug 2016 19:37:01 + Build duration: 14 min CHANGE SET Revision 3ba

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 124 - Fixed!

2016-08-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/124/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 04 Aug 2016 19:37:01 + Build duration: 9 min 26 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 124 - Fixed!

2016-08-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/124/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 04 Aug 2016 19:37:01 + Build duration: 9 min 26 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 124 - Fixed!

2016-08-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/124/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 04 Aug 2016 19:37:01 + Build duration: 2 min 31 sec CHANGE SET Rev

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 124 - Fixed!

2016-08-04 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/124/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 04 Aug 2016 19:37:01 + Build duration: 2 min 31 sec CHANGE SET Rev

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 123 - Failure!

2016-08-04 Thread Aleix Pol
On Thu, Aug 4, 2016 at 7:41 PM, wrote: > > GENERAL INFO > > BUILD FAILURE > Build URL: > https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/123/ > Project: PLATFORM=Linux,Variation=All,compiler=gcc > Date of build: Thu, 04 Aug 2016 17:3

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/#review98115 --- Fix it, then Ship it! Looks good, just one simplification

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 123 - Failure!

2016-08-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/123/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 04 Aug 2016 17:34:43 + Build duration: 5 min 30 sec CHANGE SET Rev

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 122 - Failure!

2016-08-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/122/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 04 Aug 2016 17:34:43 + Build duration: 4 min 31 sec CHANGE SET Revision 6

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 122 - Failure!

2016-08-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/122/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 04 Aug 2016 17:34:43 + Build duration: 3 min 58 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 123 - Failure!

2016-08-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/123/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 04 Aug 2016 17:34:43 + Build duration: 4 min 32 sec CHANGE SET

Review Request 128604: Define what Plasma packagestructures extend plasmashell

2016-08-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128604/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 128596: Define Plasma PackageStructure as regular KPackage PackageStructure plugins

2016-08-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128596/ --- (Updated Aug. 4, 2016, 8:34 p.m.) Status -- This change has been mar

Review Request 128603: Infer the ParentApp from the PackageStructure plugin

2016-08-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128603/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

2016-08-04 Thread David Edmundson
> On Aug. 3, 2016, 10:18 p.m., David Edmundson wrote: > > src/mass.cpp, line 268 > > > > > > one of these should be "%1 stones" (with extra 's') > > David Jarvie wrote: > No, it's normally 'stone' for the pl

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

2016-08-04 Thread David Jarvie
> On Aug. 3, 2016, 10:18 p.m., David Edmundson wrote: > > src/mass.cpp, line 268 > > > > > > one of these should be "%1 stones" (with extra 's') No, it's normally 'stone' for the plural as well. - David

Re: Review Request 128587: Move the QtScript backend into a separate directory

2016-08-04 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128587/ --- (Updated Aug. 4, 2016, 4:07 p.m.) Status -- This change has been mar

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-04 Thread Chinmoy Ranjan Pradhan
> On Aug. 3, 2016, 6:19 p.m., David Faure wrote: > > src/widgets/fileundomanager.cpp, line 421 > > > > > > "I guess" isn't good enough for me, it's the point I want to clarify :-) > > > > I now did some

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-04 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/ --- (Updated Aug. 4, 2016, 2:50 p.m.) Review request for KDE Frameworks and D

Re: Review Request 128597: support a size for adding applets

2016-08-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/#review98103 --- src/scriptengines/qml/plasmoid/containmentinterface.cpp (lin

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » Linux,gcc - Build # 85 - Failure!

2016-08-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/85/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 04 Aug 2016 12:58:59 + Build duration: 43 sec CHANGE SET Revision e5fa5cbc4fa7ebb96a2ec7803e2963038

Jenkins-kde-ci: kglobalaccel master kf5-qt5 » Linux,gcc - Build # 77 - Failure!

2016-08-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kglobalaccel%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/77/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 04 Aug 2016 12:58:59 + Build duration: 33 sec CHANGE SET Revision e5fa5cbc4fa7ebb96a2ec7803e2963038e3bf1a6

Re: Review Request 128597: support a size for adding applets

2016-08-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/ --- (Updated Aug. 4, 2016, 12:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 128599: Improve kpackage_install_package

2016-08-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128599/ --- (Updated Aug. 4, 2016, 12:33 p.m.) Status -- This change has been ma

Re: Review Request 128599: Improve kpackage_install_package

2016-08-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128599/#review98102 --- Ship it! Ship It! - Marco Martin On Aug. 4, 2016, 12:18

Review Request 128599: Improve kpackage_install_package

2016-08-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128599/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Review Request 128597: support a size for adding applets

2016-08-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/#review98101 --- I got to the signal and stopped reading. This is a trillion

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

2016-08-04 Thread Anthony Fieroni
> On Април 15, 2016, 6:59 преди обяд, Anthony Fieroni wrote: > > So as Thomas says in https://git.reviewboard.kde.org/r/127631/ it's a Qt > > issue, options are: > > 1. leave the code as is (i'm not prefer it, the bug is annoying) > > 2. do it on *right* way storing / restoring the position and

Re: Review Request 128597: support a size for adding applets

2016-08-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/ --- (Updated Aug. 4, 2016, 11:44 a.m.) Review request for KDE Frameworks and

Re: Review Request 128597: support a size for adding applets

2016-08-04 Thread Marco Martin
> On Aug. 4, 2016, 11:01 a.m., David Edmundson wrote: > > This makes no sense. > > > > An AppletInterface (which you're emitting the signal for) already has a > > width and height property. > > > > (it does have an x,y, but there're relative to the applet container not the > > containment) >

Re: Review Request 128533: Create a test that validates projects' appstream information

2016-08-04 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128533/#review98097 --- Ship it! Ship It! - Harald Sitter On Aug. 4, 2016, 11:0

Re: Review Request 128533: Create a test that validates projects' appstream information

2016-08-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128533/ --- (Updated Aug. 4, 2016, 1:03 p.m.) Review request for Build System, Extra

Re: Review Request 128597: support a size for adding applets

2016-08-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/#review98095 --- This makes no sense. An AppletInterface (which you're emitti

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

2016-08-04 Thread Anthony Fieroni
> On Авг. 3, 2016, 5:50 след обяд, Anthony Fieroni wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 500 > > > > > > This line must be > > if (s_d && wasCompositing != s_d->compositingEnable) { > > Martin

Re: Review Request 128597: support a size for adding applets

2016-08-04 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/#review98094 --- src/scriptengines/qml/plasmoid/containmentinterface.h (line

Review Request 128597: support a size for adding applets

2016-08-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 128596: Define Plasma PackageStructure as regular KPackage PackageStructure plugins

2016-08-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128596/#review98092 --- Ship it! Ship It! - Marco Martin On Aug. 4, 2016, 9:55

Review Request 128596: Define Plasma PackageStructure as regular KPackage PackageStructure plugins

2016-08-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128596/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 128533: Create a test that validates projects' appstream information

2016-08-04 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128533/#review98085 --- Fix it, then Ship it! I always get dizzy when I see code t

Re: Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

2016-08-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128581/#review98087 --- src/kmessagebox_p.cpp (line 92)

Re: Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

2016-08-04 Thread David Faure
> On Aug. 4, 2016, 6:12 a.m., Christoph Feck wrote: > > src/kmessagebox_p.cpp, line 45 > > > > > > If I understand the QGlobalStatic documentation correctly, the > > destructor is called after the QApplication ob