Review Request 128616: Fix wrong or missing "X-KDE-ParentApp" in desktop file definitions (and fix copy errors in API dox)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128616/ --- Review request for KDE Frameworks and Plasma. Repository:

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 226 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/226/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Aug 2016 21:00:23 + Build duration: 10 min CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 165 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/165/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Aug 2016 20:36:38 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 165 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/165/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Aug 2016 20:32:38 + Build duration: 14 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 128612: Add translation domain to wallpaper QML object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128612/#review98149 --- Ship it! thanks for looking into it - Marco Martin On

Re: Review Request 128612: Add translation domain to wallpaper QML object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128612/#review98145 --- Thanks for the quick reaction :) IMHO it makes sense, as it

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 126 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/126/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 05 Aug 2016 14:04:21 + Build duration: 2 min 21 sec CHANGE SET

Re: Review Request 128594: Add a kapptemplate for Plasma Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128594/ --- (Updated Aug. 5, 2016, 2:03 p.m.) Status -- This change has been

Review Request 128612: Add translation domain to wallpaper QML object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128612/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 128589: Take over maintainership; remove framework deprecation flags

> On Aug. 3, 2016, 3:32 a.m., Aleix Pol Gonzalez wrote: > > I think that changing maintainership is fine, I'm not convinced that the > > work done so far is enough to consider it up to speed. > > David Faure wrote: > Can you give more details about what you see as missing before the >

Re: Review Request 128604: Define what Plasma packagestructures extend plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128604/ --- (Updated Aug. 5, 2016, 3:34 p.m.) Status -- This change has been

Re: Review Request 128610: Fix tests not passing, make sure we separate paths properly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128610/ --- (Updated Aug. 5, 2016, 1:33 p.m.) Status -- This change has been

Re: Review Request 128610: Fix tests not passing, make sure we separate paths properly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128610/#review98141 --- Ship it! Ship It! - Marco Martin On Aug. 5, 2016, 1:31

Review Request 128610: Fix tests not passing, make sure we separate paths properly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128610/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Re: Review Request 128603: Infer the ParentApp from the PackageStructure plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128603/ --- (Updated Aug. 5, 2016, 1:29 p.m.) Status -- This change has been

Re: Review Request 128594: Add a kapptemplate for Plasma Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128594/#review98138 --- Ship it! Ship It! - Sebastian Kügler On Aug. 3, 2016,

Jenkins-kde-ci: kglobalaccel master kf5-qt5 » Linux,gcc - Build # 78 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kglobalaccel%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/78/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Aug 2016 10:36:17 + Build duration: 1 min 54 sec CHANGE SET Revision

Jenkins-kde-ci: kglobalaccel master kf5-qt5 » Linux,gcc - Build # 78 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kglobalaccel%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/78/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Aug 2016 10:36:17 + Build duration: 1 min 54 sec CHANGE SET Revision

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » Linux,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Aug 2016 10:36:17 + Build duration: 1 min 19 sec CHANGE SET Revision

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » Linux,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Aug 2016 10:36:17 + Build duration: 1 min 19 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 164 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/164/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Aug 2016 10:28:51 + Build duration: 8 min 1 sec CHANGE SET Revision 116d7dfddbfc4b3433954f79711a4f19ee32d48b

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 164 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/164/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Aug 2016 10:28:51 + Build duration: 5 min 2 sec CHANGE SET Revision

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/ --- (Updated Aug. 5, 2016, 10:28 a.m.) Status -- This change has been

Re: Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

> On Aug. 5, 2016, 8:23 a.m., David Faure wrote: > > src/kmessagebox_p.cpp, line 40 > > > > > > space after foreach -- or use range for > > Mark Gaiser wrote: > You don't want to do range for on Qt

Re: Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

> On aug 5, 2016, 8:23 a.m., David Faure wrote: > > src/kmessagebox_p.cpp, line 40 > > > > > > space after foreach -- or use range for You don't want to do range for on Qt containers. Rule of thumb: range-for on

Review Request 128609: Add Donate action to KStandardAction

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128609/ --- Review request for KDE Frameworks. Repository: kconfigwidgets

Review Request 128608: Add Donate entry to KStandardShortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128608/ --- Review request for KDE Frameworks and Matthew Dawson. Repository:

Re: Review Request 128589: Take over maintainership; remove framework deprecation flags

> On Aug. 3, 2016, 1:32 a.m., Aleix Pol Gonzalez wrote: > > I think that changing maintainership is fine, I'm not convinced that the > > work done so far is enough to consider it up to speed. Can you give more details about what you see as missing before the framework can be non-deprecated?

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/#review98132 --- Ship it! Ship It! - David Faure On Aug. 5, 2016, 1:32

Re: Review Request 128597: support a size for adding applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/ --- (Updated Aug. 5, 2016, 10:02 a.m.) Status -- This change has been

Re: Review Request 128604: Define what Plasma packagestructures extend plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128604/#review98127 --- Ship it! Ship It! - Marco Martin On Aug. 4, 2016, 5:36