Jenkins-kde-ci: kio master kf5-qt5 ยป Linux,gcc - Build # 174 - Unstable!

2016-08-08 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/174/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 08 Aug 2016 19:35:08 + Build duration: 6 min 39 sec CHANGE SET Revision bd235d2c54a7965f36d850ba14903a0541906583

Re: Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

2016-08-08 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128627/ --- (Updated Aug. 8, 2016, 7:34 p.m.) Status -- This change has been mar

Re: Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

2016-08-08 Thread David Faure
> On Aug. 8, 2016, 2:53 p.m., Anthony Fieroni wrote: > > src/widgets/kurlrequester.cpp, line 307 > > > > > > Here is setted sender, it cannot be nullptr. This code isn't called when combo is non-null (as set on

Re: Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

2016-08-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128627/#review98206 --- Ship it! OK now I understand, KUrlComboRequester features

Re: Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

2016-08-08 Thread David Faure
> On Aug. 8, 2016, 12:53 p.m., David Faure wrote: > > I don't get it, how can there be no lineedit in a KUrlRequester? Is this > > simply called too early? > > Jaime Torres Amate wrote: > Oh, I'm sorry I missed to copy part of the backtrace: > > #7 0x77ef2465 in KUrlReques

Re: Failing unittests

2016-08-08 Thread Aleix Pol
On Sat, Aug 6, 2016 at 8:12 PM, David Faure wrote: > Today is KF 5.25 tagging day, but the CI isn't green... > > https://build.kde.org/view/Frameworks%20kf5-qt5/ > > kpackage: the appstream unittests fails (see my comment in reviewboard) Should be fixed now, problem was that the files got translat

Re: Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

2016-08-08 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128627/#review98201 --- src/widgets/kurlrequester.cpp (line 307)

Re: Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

2016-08-08 Thread Jaime Torres Amate
> On Aug. 8, 2016, 12:53 p.m., David Faure wrote: > > I don't get it, how can there be no lineedit in a KUrlRequester? Is this > > simply called too early? Oh, I'm sorry I missed to copy part of the backtrace: #7 0x77ef2465 in KUrlRequester::KUrlRequesterPrivate::init() (receiver=0xb

Re: Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

2016-08-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128627/#review98199 --- I don't get it, how can there be no lineedit in a KUrlRequest

Re: Review Request 128629: Only require Xattr if the operating system is Linux

2016-08-08 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128629/ --- (Updated Aug. 8, 2016, 12:05 p.m.) Review request for KDE Frameworks and

Re: Review Request 128609: Add Donate action to KStandardAction

2016-08-08 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128609/ --- (Updated Aug. 8, 2016, 9:06 a.m.) Review request for KDE Frameworks and A

Re: Review Request 128608: Add Donate entry to KStandardShortcut

2016-08-08 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128608/ --- (Updated Aug. 8, 2016, 9:05 a.m.) Review request for KDE Frameworks and M

Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

2016-08-08 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128627/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 128626: silence contentHash deprecation warnings

2016-08-08 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128626/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc