[Differential] [Accepted] D2545: Cleanup KSharedUiServerProxy before qApp exists

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I would prefer if we could fix these kind of issues in Qt itself, but I've had a difficult time doing that (*), this stuff is tricky. (*) for other dbus-thread related problems, not nec

Re: Review Request 128680: [KCharSelect] Add ToolButton for dimming characters not available in selected font

> On Aug. 25, 2016, 1:59 a.m., Christoph Feck wrote: > > Ping? Can someone please review? It already missed the tr deadline for > > 5.26, but maybe we can get this into 5.27. > > Heiko Tietze wrote: > As far as I understand the change it will show tofu'ed characters in > their intended app

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk added a comment. Bump? REVISION DETAIL https://phabricator.kde.org/D2545 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth Cc: #frameworks

[Differential] [Commented On] D2546: Cleanup DBus-related resources before qApp exits

kfunk added a comment. Bump? REVISION DETAIL https://phabricator.kde.org/D2546 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth Cc: #frameworks

Review Request 128773: Revert "Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128773/ --- Review request for KDE Frameworks. Repository: kcmutils Description ---

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

> On Aug. 26, 2016, 11:16 a.m., Martin Gräßlin wrote: > > Ship It! Not merging yet as someone (loa) on IRC reports a crash with this - I'm quite sure I know what it'll be, the runnable trying to access WindowThumbnail after it's been deleted. I think I'll have to split all the vars that I mark

Re: Review Request 128767: Fix crash when no QApplication is available.

> On Aug. 26, 2016, 1:06 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qmenu.cpp, line 91 > > > > > > and these ones? Not called by qmlpluginscanner, but yeah if you prefer I can add if

Re: Review Request 128767: Fix crash when no QApplication is available.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128767/#review98691 --- src/declarativeimports/plasmacomponents/qmenu.cpp (line 91)

Re: Review Request 128759: Show shortcut for New Folder action

> On Aug. 25, 2016, 10:53 p.m., Albert Astals Cid wrote: > > src/filewidgets/knewfilemenu.cpp, line 804 > > > > > > Previously createDirectory was called unconditionally and now it is > > not, isn't that a probl

Re: Review Request 128759: Show shortcut for New Folder action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128759/ --- (Updated Aug. 26, 2016, 12:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/#review98684 --- Ship it! Ship It! - Martin Gräßlin On Aug. 26, 2016, 3:

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

> On Aug. 26, 2016, 9:49 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.cpp, lines 682-686 > > > > > > we probably need to do the same for EGL, don't we? > > David Edmundson wrote: >

Re: Review Request 128765: Fix cannot assign undefined to double warning in DayDelegate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128765/ --- (Updated Aug. 26, 2016, 11:14 a.m.) Status -- This change has been m

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

> On Aug. 26, 2016, 7:49 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.cpp, lines 682-686 > > > > > > we probably need to do the same for EGL, don't we? GLX and ELG are the same. I

Re: Review Request 128767: Fix crash when no QApplication is available.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128767/#review98676 --- Ship it! Ship It! - Marco Martin On Aug. 26, 2016, 7:05

Re: Review Request 128765: Fix cannot assign undefined to double warning in DayDelegate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128765/#review98675 --- Ship it! Ship It! - Marco Martin On Aug. 26, 2016, 2:14

Re: Review Request 128764: Load QtQuick rendering settings from a config file and set default QQuickWindow settings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128764/#review98674 --- Ship it! Ship It! - Martin Gräßlin On Aug. 26, 2016, 4:

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/#review98673 --- src/declarativeimports/core/windowthumbnail.cpp (lines 680 -

Review Request 128767: Fix crash when no QApplication is available.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128767/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor