Re: Review Request 128792: Fix choose other icon

2016-08-28 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128792/#review98760 --- Thanks for looking at the issue. We also have

Review Request 128792: Fix choose other icon

2016-08-28 Thread Tomaz Canabrava
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128792/ --- Review request for KDE Frameworks and Christoph Feck. Repository:

Re: Review Request 128790: Call utempter manually

2016-08-28 Thread Martin Tobias Holmedahl Sandsmark
> On Aug. 28, 2016, 3:24 p.m., Oswald Buddenhagen wrote: > > src/kpty.cpp, line 165 > > > > > > hmpf, i'd really prefer this to be a configure/cmake thing rather than > > a runtime detection. less runtime code,

Re: Review Request 128790: Call utempter manually

2016-08-28 Thread Oswald Buddenhagen
> On Aug. 28, 2016, 3:24 p.m., Oswald Buddenhagen wrote: > > src/kpty.cpp, line 165 > > > > > > hmpf, i'd really prefer this to be a configure/cmake thing rather than > > a runtime detection. less runtime code,

Re: Review Request 128790: Call utempter manually

2016-08-28 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/ --- (Updated Aug. 28, 2016, 5:36 p.m.) Review request for KDE Frameworks,

Re: Review Request 128790: Call utempter manually

2016-08-28 Thread Martin Tobias Holmedahl Sandsmark
> On Aug. 28, 2016, 3:24 p.m., Oswald Buddenhagen wrote: > > src/kpty.cpp, line 165 > > > > > > hmpf, i'd really prefer this to be a configure/cmake thing rather than > > a runtime detection. less runtime code,

Re: Review Request 128790: Call utempter manually

2016-08-28 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/#review98749 --- src/kpty.cpp (line 165)

Re: Review Request 128790: Call utempter manually

2016-08-28 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/ --- (Updated Aug. 28, 2016, 2:58 p.m.) Review request for KDE Frameworks,

Re: Review Request 128790: Remove usage of utempter

2016-08-28 Thread Martin Tobias Holmedahl Sandsmark
> On Aug. 28, 2016, 1:41 p.m., Oswald Buddenhagen wrote: > > uhm, and why do you think utempter is the preferred choice? > > last time i checked, nobody was shipping konsole setgid utmp. with kdeinit, > > that's not even an option. > > > > there are several options how to deal with this: > > -

Re: Review Request 128790: Remove usage of utempter

2016-08-28 Thread Oswald Buddenhagen
> On Aug. 28, 2016, 1:41 p.m., Oswald Buddenhagen wrote: > > uhm, and why do you think utempter is the preferred choice? > > last time i checked, nobody was shipping konsole setgid utmp. with kdeinit, > > that's not even an option. > > > > there are several options how to deal with this: > > -

Re: Review Request 128790: Remove usage of utempter

2016-08-28 Thread Martin Tobias Holmedahl Sandsmark
> On Aug. 28, 2016, 1:41 p.m., Oswald Buddenhagen wrote: > > uhm, and why do you think utempter is the preferred choice? > > last time i checked, nobody was shipping konsole setgid utmp. with kdeinit, > > that's not even an option. > > > > there are several options how to deal with this: > > -

Re: Review Request 128790: Remove usage of utempter

2016-08-28 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/#review98742 --- uhm, and why do you think utempter is the preferred choice?

Review Request 128790: Remove usage of utempter

2016-08-28 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/ --- Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Rex

Review Request 128788: KMountPoint::probablySlow() => fixes for current NFS version + FUSE mounts

2016-08-28 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128788/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 127805: Backup Remote Files: Treat mounted files also as remote files

2016-08-28 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127805/ --- (Updated Aug. 28, 2016, 12:25 p.m.) Status -- This change has been