Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129396/ --- (Updated Lis. 15, 2016, 7:58 dop.) Review request for KDE Frameworks and

Re: Review Request 129397: Set environment variables from KLaunchRequest when starting new process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129397/ --- (Updated Lis. 15, 2016, 7:57 dop.) Review request for KDE Frameworks,

Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129389/#review100846 --- src/krecentfilesaction.h (line 146)

Re: To C++11 or not?

On Mon, Nov 14, 2016 at 7:21 PM, Dominik Haumann wrote: > Hi, > > On Mon, Nov 14, 2016 at 10:45 AM, Martin Gräßlin wrote: >> Hi framework devs, >> >> recently we started to see the first patches for frameworks to silence >> warnings for not used features of

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129396/#review100845 --- src/kdeinit/ktoolinvocation.cpp (line 107)

Re: Review Request 129397: Set environment variables from KLaunchRequest when starting new process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129397/#review100844 --- Fix it, then Ship it! src/klauncher/klauncher.cpp (line

Re: To C++11 or not?

Hi, On Mon, Nov 14, 2016 at 10:45 AM, Martin Gräßlin wrote: > Hi framework devs, > > recently we started to see the first patches for frameworks to silence > warnings for not used features of C++11. In particular to add override to > methods of inheriting classes. > > Now I

Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/ --- Review request for KDE Frameworks, Christoph Feck and David Edmundson.

Problems managing KIO::Jobs

Hi, since there is no frameworks-users list and kde-devel seems less appropriate I'm asking here. I'm currently working on adding a job manager (similar to Plasma's notification widget) for KIO jobs to Krusader. While doing that I came across two issues which couldn't be solved yet. 1.

Re: To C++11 or not?

Hi all, I find it strange (not to say disappointing) that we are even talking about C++11 in 2016. +1 for the proposal. I wanted to start discussions about C++14 (the "bugfix" release of C++), but I'll wait until this discussion is finished. :) Cheers, Ivan

Re: Review Request 129400: Avoid potential access of .last() on empty list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129400/#review100834 --- src/kpackagetool/kpackagetool.cpp (line 502)

Review Request 129400: Avoid potential access of .last() on empty list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129400/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

[Differential] [Commented On] D3314: Properly test environment variable

apol added a comment. ping? REVISION DETAIL https://phabricator.kde.org/D3314 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks

Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox

> On Nov. 13, 2016, 11:26 p.m., Aleix Pol Gonzalez wrote: > > I'm not sure that it makes sense, or maybe it just reads weird. What about putting it in a @note below? Or do you want a different wording? - Elvis --- This is an

Re: To C++11 or not?

On 14 November 2016 at 10:45, Martin Gräßlin wrote: > Hi framework devs, > > recently we started to see the first patches for frameworks to silence > warnings for not used features of C++11. In particular to add override to > methods of inheriting classes. > > Now I find this

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 85 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/85/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 14 Nov 2016 10:35:34 + Build duration: 15 min CHANGE SET No changes JUNIT

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,NoX11,gcc - Build # 85 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/85/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Nov 2016 10:35:34 + Build duration: 8 min 51 sec CHANGE SET No

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,NoX11,gcc - Build # 85 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/85/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Nov 2016 10:35:34 + Build duration: 8 min 51 sec CHANGE SET No

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,NoX11,gcc - Build # 84 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/84/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Nov 2016 10:20:14 + Build duration: 52 sec CHANGE SET Revision

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 84 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/84/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 14 Nov 2016 10:20:14 + Build duration: 30 sec CHANGE SET Revision

Re: Review Request 129362: [KWindowInfo] Add pid()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129362/ --- (Updated Nov. 14, 2016, 11:19 a.m.) Status -- This change has been

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129396/ --- (Updated Lis. 14, 2016, 10:01 dop.) Review request for KDE Frameworks

Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129399/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129395/ --- (Updated Lis. 14, 2016, 9:52 dop.) Review request for KDE Frameworks and

To C++11 or not?

Hi framework devs, recently we started to see the first patches for frameworks to silence warnings for not used features of C++11. In particular to add override to methods of inheriting classes. Now I find this weird from the perspective of our C++ requirements. On the one side we say that

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129395/#review100832 --- Can you attach a screenshot? Also the kpropertiesdialog cpp

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129396/#review100831 --- src/kdeinit/ktoolinvocation.cpp (line 98)

Review Request 129398: Restore KTextEditor Document Dbus bindings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129398/ --- Review request for KDE Frameworks and Christoph Cullmann. Bugs: 369623

Review Request 129397: Set environment variables from KLaunchRequest when starting new process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129397/ --- Review request for KDE Frameworks and David Faure. Repository: kinit

Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129396/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129395/ --- Review request for KDE Frameworks and David Faure. Repository: kio