Re: Review Request 129298: KPackage dependencies support

> On Nov. 17, 2016, 6:06 p.m., Marco Martin wrote: > > like it, still have some issues with the > > my concern is that an id by itself is not really identifying information > > enough (would in this case for instance colorschemes.knsrc in the url > > identify something on the server which can

[Differential] [Commented On] D2854: New: ECMGenerateApiDox, for generating qch & tag files

kfunk added a comment. Heya Friedrich. You asked me to review this. From a super brief scan of the code I don't see anything blatantly wrong. I trust you that you've tested this good enough. Love the extensive documentation. What's left here from your side? REVISION DETAIL

Re: Review Request 129398: Restore KTextEditor Document Dbus bindings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129398/#review100918 --- In general ok, but could you please post an updated version

Re: Review Request 129298: KPackage dependencies support

> On Nov. 17, 2016, 6:06 p.m., Marco Martin wrote: > > like it, still have some issues with the > > my concern is that an id by itself is not really identifying information > > enough (would in this case for instance colorschemes.knsrc in the url > > identify something on the server which can

Re: Review Request 129298: KPackage dependencies support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/#review100913 --- like it, still have some issues with the my concern is

Review Request 129419: FrameworksIntegration: Let KPackage have dependencies from packagekit and KNewStuff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129419/ --- Review request for KDE Frameworks. Repository: frameworkintegration

Re: Review Request 129298: KPackage dependencies support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/ --- (Updated Nov. 17, 2016, 5 p.m.) Review request for KDE Frameworks,

Re: Review Request 129298: RFC: supporting dependencies on KPackage

> On Oct. 31, 2016, 6:19 p.m., Marco Martin wrote: > > src/kpackage/private/packagejobthread.cpp, line 436 > > > > > > would this need a local database of installed packages/dependencies? > > Aleix Pol Gonzalez

[Differential] [Closed] D3314: Properly test environment variable

apol closed this revision. REVISION DETAIL https://phabricator.kde.org/D3314 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, sebas, sitter

[Differential] [Accepted] D3314: Properly test environment variable

sitter accepted this revision. sitter added a reviewer: sitter. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3314 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, sebas, sitter

[Differential] [Updated, 4 lines] D3314: Properly test environment variable

apol updated this revision to Diff 8256. apol added a comment. Use qEnvironmentVariableIsEmpty so we don't change the behaviour CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3314?vs=8034=8256 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3314 AFFECTED FILES

[Differential] [Accepted] D3314: Properly test environment variable

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3314 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, sebas

Re: Review Request 129298: RFC: supporting dependencies on KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/#review100899 --- now that even the kns refactor got in, can we continue on

[Differential] [Commented On] D3393: Make compile against WinXP SDK

kfunk added a comment. In https://phabricator.kde.org/D3393#63437, @dhaumann wrote: > In general ok (but why is this a review request for KSyntaxHighlighting?) Because the reviewers field auto-completion sucks :) REVISION DETAIL https://phabricator.kde.org/D3393 EMAIL

[Differential] [Updated] D3393: Make compile against WinXP SDK

kfunk edited reviewers, added: Frameworks; removed: Framework: Syntax Hightlighting. REVISION DETAIL https://phabricator.kde.org/D3393 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, arichardson, #frameworks Cc: dhaumann