Re: Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

2016-11-27 Thread Jan Grulich
> On Lis. 26, 2016, 7:20 odp., David Faure wrote: > > src/widgets/krun.cpp, line 436 > > > > > > Is it needed to do this check more than once? > > If this can't change over time, there could be a static enum

Re: Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

2016-11-27 Thread Jan Grulich
> On Lis. 26, 2016, 7:20 odp., David Faure wrote: > > src/widgets/krun.cpp, line 436 > > > > > > Is it needed to do this check more than once? > > If this can't change over time, there could be a static enum

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-27 Thread David Faure
> On Nov. 26, 2016, 7:22 p.m., David Faure wrote: > > src/widgets/kpropertiesdialog.cpp, line 3482 > > > > > > same comment as in 129399, it would be good if only the first > > properties dialog was slowed

Re: Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

2016-11-27 Thread David Faure
> On Nov. 26, 2016, 7:20 p.m., David Faure wrote: > > src/widgets/krun.cpp, line 436 > > > > > > Is it needed to do this check more than once? > > If this can't change over time, there could be a static enum

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-27 Thread Jan Grulich
> On Lis. 26, 2016, 7:22 odp., David Faure wrote: > > src/widgets/kpropertiesdialog.cpp, line 3482 > > > > > > same comment as in 129399, it would be good if only the first > > properties dialog was slowed

Re: Review Request 128574: Enable natural sorting on QCollator in KDirSortFilterProxyModel

2016-11-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128574/#review101146 --- +1 - Aleix Pol Gonzalez On Aug. 2, 2016, 12:08 p.m.,

Re: Review Request 128574: Enable natural sorting on QCollator in KDirSortFilterProxyModel

2016-11-27 Thread Konstantinos Smanis
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128574/#review101143 --- I can confirm that the patch indeed resolves the natural

Re: Please cleanup your scratch and clone repositories

2016-11-27 Thread Ben Cooksley
On Sat, Nov 26, 2016 at 7:53 AM, Ben Cooksley wrote: > Hi all, Hi all, > > To help Sysadmin assess how these types of repositories would be used > under Phabricator, it would be appreciated if everyone could please > cleanup the scratch and clone repositories they're no