Re: Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

2016-11-29 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129399/ --- (Updated Lis. 29, 2016, 8:02 dop.) Review request for KDE Frameworks and

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-29 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129395/ --- (Updated Lis. 29, 2016, 8:03 dop.) Review request for KDE Frameworks and

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-29 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129395/ --- (Updated Lis. 29, 2016, 8:09 dop.) Review request for KDE Frameworks and

[Differential] [Updated] D3530: Import plasma-workspace kioslaves

2016-11-29 Thread dfaure (David Faure)
dfaure added a comment. remote:/ sounds very workspace-independent indeed, it sounds useful to have in kio. But desktop:/ and applications:/ make no sense in other workspaces (I'm surprised we even still have applications:/, it's kind of a toy, isn't it?). (ok applications:/ might m

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-11-29 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129396/ --- (Updated Lis. 29, 2016, 9:47 dop.) Review request for KDE Frameworks and

Re: Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

2016-11-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129399/#review101178 --- Ship it! Ship It! - David Faure On Nov. 29, 2016, 8:02

Review Request 129580: Take X-KDE-RunOnDiscreteGpu property into account when starting app using klauncher

2016-11-29 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129580/ --- Review request for KDE Frameworks and David Faure. Repository: kinit De

Re: Review Request 129395: Add option to run an app on a discrete graphics card to KPropertiesDialog

2016-11-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129395/#review101179 --- Ship it! Ship It! - David Faure On Nov. 29, 2016, 8:09

Re: Review Request 129580: Take X-KDE-RunOnDiscreteGpu property into account when starting app using klauncher

2016-11-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129580/#review101180 --- src/klauncher/klauncher.cpp (line 746)

Re: Review Request 129580: Take X-KDE-RunOnDiscreteGpu property into account when starting app using klauncher

2016-11-29 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129580/ --- (Updated Lis. 29, 2016, 10:06 dop.) Review request for KDE Frameworks and

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

2016-11-29 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3530#65867, @dfaure wrote: > But desktop:/ and applications:/ make no sense in other workspaces (I'm surprised we even still have applications:/, it's kind of a toy, isn't it?). > > (ok applications:/ might make sense in gnome, but

Review Request 129586: [KNotification] Allow annotating notifications with URLs

2016-11-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129586/ --- Review request for KDE Frameworks and Plasma. Repository: knotifications

[Differential] [Commented On] D2546: Cleanup DBus-related resources before qApp exits

2016-11-29 Thread albertvaka (Albert Vaca Cintora)
albertvaka added a comment. Since there is no fix on Qt, should we merge this? REVISION DETAIL https://phabricator.kde.org/D2546 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, vonreth, dfaure Cc: albertvaka, #frameworks

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

2016-11-29 Thread albertvaka (Albert Vaca Cintora)
albertvaka added a comment. Since there is no fix on Qt, should we merge this? BRANCH master REVISION DETAIL https://phabricator.kde.org/D2545 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, vonreth, dfaure Cc: albertvaka, mutlaqja, arrowdodge

[Differential] [Accepted] D2546: Cleanup DBus-related resources before qApp exits

2016-11-29 Thread dfaure (David Faure)
dfaure accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D2546 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, vonreth, dfaure Cc: albertvaka, #frameworks

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

2016-11-29 Thread dfaure (David Faure)
dfaure added a comment. Actually, I think Thiago's still waiting for a backtrace of all threads. BRANCH master REVISION DETAIL https://phabricator.kde.org/D2545 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, vonreth, dfaure Cc: albertvaka, mu

Review Request 129587: Set parent for actions in DropJob's popup menu

2016-11-29 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129587/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox

2016-11-29 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129389/ --- (Updated Nov. 29, 2016, 5:59 p.m.) Status -- This change has been ma

Review Request 129588: http slave: add newlines to long error message

2016-11-29 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129588/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

[Differential] [Request, 12 lines] D3544: Small optimization

2016-11-29 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Frameworks, leinir, whiting. REVISION SUMMARY Reduce lookups to the attributes map Drop the QString part on QStringRef -> QString -> int BRANCH master REVISION DETAIL https://phabricator.kde.org/D3544 AFFECTED FILES src/contentparser.c

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 287 - Still Unstable!

2016-11-29 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/287/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 30 Nov 2016 03:25:36 + Build duration: 18 min CHANGE SET Revision 6b28a376b40d47bed82694059350edee6b320c2a

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 282 - Still Unstable!

2016-11-29 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/282/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 30 Nov 2016 03:25:36 + Build duration: 19 min CHANGE SET Revision 6b28a376b40d47bed82694059350edee6b320c2a by scr