Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/ --- (Updated Dec. 3, 2016, 8:50 a.m.) Status -- This change has been

[Differential] [Commented On] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

jonathans added a comment. Agreed that would be more robust. In writing the patch I was seeking consistency with those functions that already did the test, so those would also need to be updated. Are there any situations where the two tests would yield a different result, ie d->native is

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review101225 --- Honestly i don't see anything wrong with the patch but i

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Dec. 1, 2016, 9:43 p.m., Albert Astals Cid wrote: > > src/kstatusnotifieritem.cpp, line 972 > > > > > > maybe move this to the else? > > Anthony Fieroni wrote: > NET::WMFrameExtents is not needed

Re: [KUnitConversion] Question about overloading operators

El dimecres, 23 de novembre de 2016, a les 9:00:10 CET, Ander Pijoan va escriure: > So would it be to hamrfull to add at least this four operators? At the > moment just allowing same Unit values. You mentioned that using Q_ASSERT is > not a good idea, maybe there is another way of ensuring they

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 103 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Dec 2016 18:45:53 + Build duration: 4 min 54 sec CHANGE SET Revision

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 103 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Dec 2016 18:45:53 + Build duration: 4 min 54 sec CHANGE SET Revision

Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 98 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/98/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Dec 2016 18:45:53 + Build duration: 1 min 25 sec CHANGE SET Revision

Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 98 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/98/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Dec 2016 18:45:53 + Build duration: 1 min 25 sec CHANGE SET Revision

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 102 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/102/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Dec 2016 18:37:13 + Build duration: 1 min 28 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Closed] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

This revision was automatically updated to reflect the committed changes. Closed by commit R237:cd4e6504dfbd: Generate an instance with KSharedConfig::Ptr for singleton and arg (authored by graesslin). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 101 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Dec 2016 18:05:07 + Build duration: 2 min 11 sec CHANGE SET Revision

Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 97 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/97/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Dec 2016 18:05:07 + Build duration: 2 min 13 sec CHANGE SET Revision

Re: Shipping prison with next frameworks version

Hi, sorry for writing this mail shortly before the tagging of the next Frameworks release, but I got sidetracked by other things. On 09/30/16 09:42, David Faure wrote: > On dimanche 18 septembre 2016 20:03:00 CEST Sune Vuorela wrote: >> Other than asking sysadmin to move prison from kdesupport

Re: Review Request 126226: kdetemplate_add_app_templates installs previews

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126226/ --- (Updated Dec. 2, 2016, 12:13 p.m.) Status -- This change has been

[Differential] [Updated] D3568: Find the correct path to the cmake command

ltoscano set the repository for this revision to R240 Extra CMake Modules. REPOSITORY R240 Extra CMake Modules BRANCH find-cmake-binary REVISION DETAIL https://phabricator.kde.org/D3568 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: obogdan, kfunk,

[Differential] [Commented On] D3568: Find the correct path to the cmake command

obogdan added a comment. Should I wait for more people to review this? BRANCH find-cmake-binary REVISION DETAIL https://phabricator.kde.org/D3568 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: obogdan, kfunk, #frameworks, apol Cc: kfunk

[Differential] [Accepted] D3568: Find the correct path to the cmake command

apol accepted this revision. apol added a reviewer: apol. BRANCH find-cmake-binary REVISION DETAIL https://phabricator.kde.org/D3568 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: obogdan, kfunk, #frameworks, apol Cc: kfunk

[Differential] [Requested Changes To] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

kfunk requested changes to this revision. kfunk added a reviewer: kfunk. kfunk added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfiledialog.cpp:607 > +if (d->native) { > +return; > +} Should we rather check for `!d->w` here and below? Would

Re: Review Request 129598: fix build, needs QtDBus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129598/ --- (Updated Dec. 2, 2016, 11:09 a.m.) Status -- This change has been

[Differential] [Updated] D3568: Find the correct path to the cmake command

kfunk edited reviewers, added: Frameworks; removed: Framework: Syntax Hightlighting. BRANCH find-cmake-binary REVISION DETAIL https://phabricator.kde.org/D3568 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: obogdan, kfunk, #frameworks Cc: kfunk

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Dec. 1, 2016, 11:43 p.m., Albert Astals Cid wrote: > > src/kstatusnotifieritem.cpp, line 972 > > > > > > maybe move this to the else? > > Anthony Fieroni wrote: > NET::WMFrameExtents is not needed

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Dec. 1, 2016, 11:43 p.m., Albert Astals Cid wrote: > > src/kstatusnotifieritem.cpp, line 972 > > > > > > maybe move this to the else? NET::WMFrameExtents is not needed anymore. - Anthony