---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129661/
---
Review request for KDE Frameworks and Olivier Churlaud.
Bugs: 373723
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129660/#review101475
---
Ship it!
Ship It!
- Dan Leinir Turthra Jensen
On Dec.
thiago added a comment.
In https://phabricator.kde.org/D2545#69187, @kfunk wrote:
> In https://phabricator.kde.org/D2545#69091, @thiago wrote:
>
> > There doesn't seem to be a way of doing some clean up before the threads
are forcibly killed.
> >
> > Maybe if I abuse qtmain().
>
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129660/
---
(Updated Dec. 16, 2016, 5:56 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129654/#review101474
---
Waiting for feedback from tsdgeos on the change in scripty.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129660/
---
Review request for KDE Frameworks and Jeremy Whiting.
Repository: knewstu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129654/#review101473
---
Ship it!
Ship It!
- Dan Leinir Turthra Jensen
On Dec.
> On Dec. 16, 2016, 3:55 p.m., Aleix Pol Gonzalez wrote:
> > +1
> > Would it be possible to do the same with the signals?
Unfortunately that would break compatibility (the maps are public and clients
can insert new stuff there)
- Elvis
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101471
---
+1
Would it be possible to do the same with the signals?
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129659/
---
Review request for KDE Frameworks.
Repository: kconfigwidgets
Descripti
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/
---
Review request for KDE Frameworks.
Repository: kconfigwidgets
Descripti
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/337/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 16 Dec 2016 12:44:35 +
Build duration: 10 min
CHANGE SET
Revision 5837de42f3c53b801225814
This revision was automatically updated to reflect the committed changes.
Closed by commit R252:5837de42f3c5: Search for the more precise required
version of AppstreamQt (authored by apol).
REPOSITORY
R252 Framework Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3696?vs=9
kfunk added a comment.
In https://phabricator.kde.org/D2075#66751, @jonathans wrote:
> Agreed that would be more robust. In writing the patch I was seeking
consistency with those functions that already did the test, so those would also
need to be updated. Are there any situations where t
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:e6c88f67e2cb: kconfig_compiler: Use nullptr in generated
code (authored by kfunk).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3702?vs=9072&id=9075
REVISION DET
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3702
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/e
kfunk added a reviewer: Frameworks.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D3702
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks
kfunk added a comment.
In https://phabricator.kde.org/D2545#69091, @thiago wrote:
> There doesn't seem to be a way of doing some clean up before the threads
are forcibly killed.
>
> Maybe if I abuse qtmain().
This would only fix it for non-console GUI applications if I underst
kfunk added a comment.
For the record, since I don't see an easy fix I'm pondering about patching
qtbase in craft.git:
Ideas:
a ) Add this to QDBusConnectionManager ctor:
qAddPostRoutine([]() {
QMetaObject::invokeMethod(QDBusConnectionManager::instance(), "quit");
> On Dec. 16, 2016, 2:55 a.m., Stephen Kelly wrote:
> > Thanks for working on this!
> >
> > I noticed that I could remove the change in beginRemoveRows without any
> > unit test failing.
> >
> > Please add this test on top of your patch:
> >
> > diff --git a/autotests/kselectionproxymodeltes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129657/
---
(Updated Dec. 16, 2016, 9:23 a.m.)
Status
--
This change has been ma
On Fri, Dec 16, 2016 at 3:46 AM, Aleix Pol wrote:
> On Thu, Dec 15, 2016 at 7:19 AM, Ben Cooksley wrote:
>>
>> On Thu, Dec 15, 2016 at 7:16 PM, wrote:
>> >
>> > GENERAL INFO
>> >
>> > BUILD FAILURE
>> > Build URL:
>> > https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PL
22 matches
Mail list logo