Review Request 129661: optional CHM generation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129661/ --- Review request for KDE Frameworks and Olivier Churlaud. Bugs: 373723

Re: Review Request 129660: Fix set up of the KNSCore::Engine when created with an absolute config file path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129660/#review101475 --- Ship it! Ship It! - Dan Leinir Turthra Jensen On Dec.

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

thiago added a comment. In https://phabricator.kde.org/D2545#69187, @kfunk wrote: > In https://phabricator.kde.org/D2545#69091, @thiago wrote: > > > There doesn't seem to be a way of doing some clean up before the threads are forcibly killed. > > > > Maybe if I abuse qtmain().

Re: Review Request 129660: Fix set up of the KNSCore::Engine when created with an absolute config file path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129660/ --- (Updated Dec. 16, 2016, 5:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 129654: Introduce the resource name in the knsrc file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129654/#review101474 --- Waiting for feedback from tsdgeos on the change in scripty.

Review Request 129660: Fix set up of the KNSCore::Engine when created with an absolute config file path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129660/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository:

Re: Review Request 129654: Introduce the resource name in the knsrc file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129654/#review101473 --- Ship it! Ship It! - Dan Leinir Turthra Jensen On Dec.

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

> On Dec. 16, 2016, 3:55 p.m., Aleix Pol Gonzalez wrote: > > +1 > > Would it be possible to do the same with the signals? Unfortunately that would break compatibility (the maps are public and clients can insert new stuff there) - Elvis

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/#review101471 --- +1 Would it be possible to do the same with the signals? -

Review Request 129658: KConfigDialogManager: cleanup static maps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/ --- Review request for KDE Frameworks. Repository: kconfigwidgets

[Differential] [Closed] D3696: Search for the more precise required version of AppstreamQt

This revision was automatically updated to reflect the committed changes. Closed by commit R252:5837de42f3c5: Search for the more precise required version of AppstreamQt (authored by apol). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

kfunk added a comment. In https://phabricator.kde.org/D2075#66751, @jonathans wrote: > Agreed that would be more robust. In writing the patch I was seeking consistency with those functions that already did the test, so those would also need to be updated. Are there any situations where

[Differential] [Closed] D3702: kconfig_compiler: Use nullptr in generated code

This revision was automatically updated to reflect the committed changes. Closed by commit R237:e6c88f67e2cb: kconfig_compiler: Use nullptr in generated code (authored by kfunk). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3702?vs=9072=9075 REVISION

[Differential] [Accepted] D3702: kconfig_compiler: Use nullptr in generated code

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D3702 EMAIL PREFERENCES

[Differential] [Updated] D3702: kconfig_compiler: Use nullptr in generated code

kfunk added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D3702 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk added a comment. In https://phabricator.kde.org/D2545#69091, @thiago wrote: > There doesn't seem to be a way of doing some clean up before the threads are forcibly killed. > > Maybe if I abuse qtmain(). This would only fix it for non-console GUI applications if I

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk added a comment. For the record, since I don't see an easy fix I'm pondering about patching qtbase in craft.git: Ideas: a ) Add this to QDBusConnectionManager ctor: qAddPostRoutine([]() { QMetaObject::invokeMethod(QDBusConnectionManager::instance(), "quit");

Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

> On Dec. 16, 2016, 2:55 a.m., Stephen Kelly wrote: > > Thanks for working on this! > > > > I noticed that I could remove the change in beginRemoveRows without any > > unit test failing. > > > > Please add this test on top of your patch: > > > > diff --git

Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/ --- (Updated Dec. 16, 2016, 9:23 a.m.) Status -- This change has been

Re: Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 334 - Still Failing!

On Fri, Dec 16, 2016 at 3:46 AM, Aleix Pol wrote: > On Thu, Dec 15, 2016 at 7:19 AM, Ben Cooksley wrote: >> >> On Thu, Dec 15, 2016 at 7:16 PM, wrote: >> > >> > GENERAL INFO >> > >> > BUILD FAILURE >> > Build URL: >> >