kossebau closed this revision.
kossebau marked an inline comment as done.
kossebau added a comment.
Committed with 7bbbd93cd3fc0abdffd3fa7f144cb50a33fafad9
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D3796
EMAIL PREFERENCES
http
dfaure accepted this revision.
dfaure added inline comments.
INLINE COMMENTS
> kdeplatformfiledialoghelper.cpp:365
> +
> +// Qt 5 at least until 5.7.0 does not derive the directory from the
> passed url
> +// and set the initialDirectory option accordingly, also not for known
> schemes
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
fixFileDialogDirectoryWithSelectUrl
REVISION DETAIL
https://phabricator.kde.org/D3796
EMAIL PREFERENCE
kossebau created this revision.
kossebau added reviewers: Plasma, Frameworks, dfaure.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
QFileDialog does not set the initialDirectory option in codepaths from
QFileDialog::se
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129694/
---
Review request for KDE Frameworks.
Bugs: 345434
https://bugs.kde.org/
graesslin added a comment.
In https://phabricator.kde.org/D3689#70685, @aacid wrote:
> > We can adjust the shortcuts without having side effects on other tests.
>
> Why not just delete the test file on start of each test?
I like my tests not affecting other tests. If for whatev
