[Differential] [Changed Subscribers] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

graesslin added inline comments. INLINE COMMENTS > job.h:50 > KIOCORE_EXPORT QString buildHTMLErrorString(int errorCode, const QString > , > -const QUrl *reqUrl = 0, int method = -1); > +const QUrl *reqUrl = nullptr, int method = -1); > Question: is this change API and ABI

Re: CI Requirements - Lessons Not Learnt?

On Fri, Jan 6, 2017 at 12:38 AM, Martin Gräßlin wrote: > Am 2017-01-05 11:20, schrieb Ben Cooksley: >> >> On Thu, Jan 5, 2017 at 10:28 PM, Martin Gräßlin >> wrote: >>> >>> Am 2017-01-05 09:44, schrieb Ben Cooksley: Hi all,

[Differential] [Updated] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk updated the summary for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D3987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

Re: To C++11 or not?

On Friday, 30 December 2016 15:29:52 CET Kevin Funk wrote: > On Friday, 30 December 2016 15:25:56 CET David Faure wrote: > > On vendredi 30 décembre 2016 12:56:09 CET Albert Astals Cid wrote: > > > El divendres, 30 de desembre de 2016, a les 12:24:38 CET, Luigi Toscano > > > va > > > > > >

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 355 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/355/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 23:31:19 + Build duration: 13 min CHANGE SET No changes JUNIT RESULTS Name: (root)

[Differential] [Request, 2,027 lines] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk created this revision. kfunk added a reviewer: Frameworks. kfunk set the repository for this revision to R241 KIO. Restricted Application added a project: Frameworks. REVISION SUMMARY The full patch (all Frameworks ported to using nullptr instead of null literals) changes around 9000

[Differential] [Updated] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk updated the summary for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D3987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 350 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/350/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 23:22:26 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Enabling Clang's -Wdocumentation in Frameworks...?

On Thursday, January 05, 2017 08:01:53 PM Kevin Funk wrote: > Heya, > > we all like up-to-date apidocs, right. > I would like to point out that the EBN has been providing pretty reports for doxygen problems for many years already. Or had been, before the frameworks days. One such example from

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 183 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/183/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 22:51:57 + Build duration: 2 min 9 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kcmutils master kf5-qt5 » Linux,gcc - Build # 122 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcmutils%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/122/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 22:39:46 + Build duration: 1 min 11 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 129760: Fixup handling of KFontUtils::adaptFontSize's flags' default value.

> On Jan. 5, 2017, 10:56 p.m., Stephen Kelly wrote: > > I've added the change to the unit test. It already passes, so it's not > > clear to me what else is needed from this review request. > > Shaheed Haque wrote: > What version of SIP compiler and C++ compiler are you using? I'm on: >

Jenkins-kde-ci: kcmutils master kf5-qt5 » Linux,gcc - Build # 122 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcmutils%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/122/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 22:39:46 + Build duration: 1 min 11 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 186 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/186/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 22:35:35 + Build duration: 1 min 48 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 129760: Fixup handling of KFontUtils::adaptFontSize's flags' default value.

> On Jan. 5, 2017, 10:56 p.m., Stephen Kelly wrote: > > I've added the change to the unit test. It already passes, so it's not > > clear to me what else is needed from this review request. What version of SIP compiler and C++ compiler are you using? I'm on: $ sip -V 4.18.1 $ g++ --version g++

Re: Review Request 129760: Fixup handling of KFontUtils::adaptFontSize's flags' default value.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129760/#review101827 --- I've added the change to the unit test. It already passes,

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 349 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/349/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 21:32:50 + Build duration: 16 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 354 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/354/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 21:23:49 + Build duration: 8 min 45 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 185 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/185/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 20:53:42 + Build duration: 1 min 55 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kcmutils master kf5-qt5 » Linux,gcc - Build # 121 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcmutils%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/121/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 20:52:01 + Build duration: 31 sec CHANGE SET No changes

[Differential] [Updated, 147 lines] D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

kossebau updated this revision to Diff 9781. kossebau marked an inline comment as done. kossebau added a comment. Use Q_DECL_OVERRIDE & nullpt REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3977?vs=9775=9781 BRANCH fixKDynamicJobTracker REVISION DETAIL

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 182 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/182/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 20:45:30 + Build duration: 1 min 49 sec CHANGE SET No changes JUNIT RESULTS

Re: Enabling Clang's -Wdocumentation in Frameworks...?

Am 2017-01-05 20:01, schrieb Kevin Funk: Heya, we all like up-to-date apidocs, right. I was pondering whether it would be feasible to globally activate Clang's - Wdocumentation warning in KDEFrameworkCompilerSettings.cmake in ECM, but we're running into too many issues at the moment, thus I

Enabling Clang's -Wdocumentation in Frameworks...?

Heya, we all like up-to-date apidocs, right. I was pondering whether it would be feasible to globally activate Clang's - Wdocumentation warning in KDEFrameworkCompilerSettings.cmake in ECM, but we're running into too many issues at the moment, thus I ditched the idea. In case you don't know

[Differential] [Accepted] D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

kfunk accepted this revision. kfunk added a reviewer: kfunk. kfunk added a comment. This revision is now accepted and ready to land. Rest LGTM, but let's wait for another review INLINE COMMENTS > kdynamicjobtrackernowidgetstest.cpp:34 > +public: > +virtual void start() {

[Differential] [Updated, 147 lines] D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

kossebau updated this revision to Diff 9775. kossebau added a comment. add unittest for crash by qwidgets without qapplication instance REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3977?vs=9740=9775 BRANCH fixKDynamicJobTracker REVISION DETAIL

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 353 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/353/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 16:51:17 + Build duration: 11 min CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 348 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/348/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 16:51:17 + Build duration: 11 min CHANGE SET Revision 933c75c1dc645b60ba13807afba02eaad9cebbfc by

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 290 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/290/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 05 Jan 2017 14:16:00 + Build duration: 4 min 15 sec CHANGE SET Revision

[Differential] [Closed] D3892: [Icon Item] Support non-square icons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d46a91ea57f1: [Icon Item] Support non-square icons (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3892?vs=9658=9760#toc REPOSITORY R242 Plasma Frameworks CHANGES

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 184 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/184/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 13:54:33 + Build duration: 5 min 28 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 167 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/167/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 13:54:33 + Build duration: 3 min 39 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 167 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/167/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 13:54:33 + Build duration: 3 min 39 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 181 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/181/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 13:50:45 + Build duration: 5 min 24 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Accepted] D3892: [Icon Item] Support non-square icons

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3892 EMAIL PREFERENCES

Re: Review Request 129770: Return stringlist types in KPluginMetaData::value

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129770/ --- (Updated Jan. 5, 2017, 1:43 p.m.) Status -- This change has been

Re: Review Request 129777: Initialise a member variable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129777/ --- (Updated Jan. 5, 2017, 1:42 p.m.) Status -- This change has been

Re: Review Request 129770: Return stringlist types in KPluginMetaData::value

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129770/#review101824 --- Ship it! Looks good, thanks! - Aleix Pol Gonzalez On

[Differential] [Closed] D3958: [PackageLoader] Don't access invalid KPluginMetadata

This revision was automatically updated to reflect the committed changes. Closed by commit R290:8391e022e0f0: [PackageLoader] Don't access invalid KPluginMetadata (authored by broulik). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3958?vs=9708=9756

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/#review101822 --- Note: This got reverted in master for now, since there were

Qt 5.7+ and Command+Shift shortcuts on Mac

Hi, I'm noticing a different in the handling of Command+Shift shortcuts on Mac, after upgrading to Qt 5.7.1 Pre-existing shortcuts like Command+Shift+, for Command-< continue to show up as Command-< (<) but they no longer function. When I try to re-record them, the Shift modifier is dropped

Re: CI Requirements - Lessons Not Learnt?

Am 2017-01-05 11:20, schrieb Ben Cooksley: On Thu, Jan 5, 2017 at 10:28 PM, Martin Gräßlin wrote: Am 2017-01-05 09:44, schrieb Ben Cooksley: Hi all, It seems that my previous vocal complaints about system level / serious impact dependency bumps on the CI system

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. Note: I'll push this after the imminent KF5 release if no-one objects. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: CI Requirements - Lessons Not Learnt?

On Thu, Jan 5, 2017 at 10:28 PM, Martin Gräßlin wrote: > Am 2017-01-05 09:44, schrieb Ben Cooksley: >> >> Hi all, >> >> It seems that my previous vocal complaints about system level / >> serious impact dependency bumps on the CI system have gone completely >>

Re: CI Requirements - Lessons Not Learnt?

Sorry picked wrong from address Am 2017-01-05 10:28, schrieb Martin Gräßlin: Am 2017-01-05 09:44, schrieb Ben Cooksley: Hi all, It seems that my previous vocal complaints about system level / serious impact dependency bumps on the CI system have gone completely unnoticed by (some) members of

CI Requirements - Lessons Not Learnt?

Hi all, It seems that my previous vocal complaints about system level / serious impact dependency bumps on the CI system have gone completely unnoticed by (some) members of our Community. This was demonstrated earlier this week when components of Plasma bumped their version requirements for