[Differential] [Commented On] D4023: kformat: Make it possible to properly translate relative days of the week

mpyne added a comment. In https://phabricator.kde.org/D4023#76891, @aacid wrote: > I find the comments misleading (maybe because i'm not english native) but > > if (daysTo < -1) { > switch (date.dayOfWeek()) { > case 1: > return tr("Last Monday",

Re: Review Request 129826: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129826/#review101991 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129825: Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129825/#review101990 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129824: Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129824/#review101989 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129822: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129822/#review101987 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129823: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129823/#review101988 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129821: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129821/#review101986 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129820: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129820/#review101985 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129819: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129819/#review101984 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129818: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129818/#review101983 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129817: Q_ENUMS -> Q_ENUM, Q_FLAGS -> Q_FLAG and actually declare the flags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129817/#review101982 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129816: Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129816/#review101981 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129815: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129815/#review101980 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129814: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129814/#review101979 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Re: Review Request 129813: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129813/#review101978 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 13, 201

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 373 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/373/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 13 Jan 2017 00:26:25 + Build duration: 13 min CHANGE SET Revision 17be5b14ff398e454dae005bc60b954924ee5745

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 373 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/373/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 13 Jan 2017 00:26:25 + Build duration: 13 min CHANGE SET Revision 17be5b14ff398e454dae005bc60b954924ee5745

Jenkins-kde-ci: kinit master kf5-qt5 » Linux,gcc - Build # 375 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kinit%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/375/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 13 Jan 2017 00:33:40 + Build duration: 3 min 46 sec CHANGE SET No changes

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 369 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/369/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 13 Jan 2017 00:26:25 + Build duration: 5 min 28 sec CHANGE SET Revision 17be5b14ff398e454dae005bc60b954924ee5745 b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 369 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/369/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 13 Jan 2017 00:26:25 + Build duration: 5 min 28 sec CHANGE SET Revision 17be5b14ff398e454dae005bc60b954924ee5745 b

Review Request 129826: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129826/ --- Review request for KDE Frameworks. Repository: plasma-framework Descrip

Review Request 129825: Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129825/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Review Request 129824: Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129824/ --- Review request for KDE Frameworks. Repository: ktextwidgets Description

Review Request 129823: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129823/ --- Review request for KDE Frameworks. Repository: kpeople Description

Review Request 129822: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129822/ --- Review request for KDE Frameworks. Repository: kparts Description -

Review Request 129821: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129821/ --- Review request for KDE Frameworks. Repository: knotifications Descripti

Review Request 129820: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129820/ --- Review request for KDE Frameworks. Repository: knewstuff Description --

Review Request 129819: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129819/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 129818: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129818/ --- Review request for KDE Frameworks. Repository: kiconthemes Description

Review Request 129817: Q_ENUMS -> Q_ENUM, Q_FLAGS -> Q_FLAG and actually declare the flags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129817/ --- Review request for KDE Frameworks. Repository: kglobalaccel Description

Review Request 129816: Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129816/ --- Review request for KDE Frameworks. Repository: kdewebkit Description --

Review Request 129815: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129815/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Review Request 129814: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129814/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Review Request 129813: Q_ENUMS -> Q_ENUM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129813/ --- Review request for KDE Frameworks. Repository: kactivities Description

[Differential] [Requested Changes To] D4023: kformat: Make it possible to properly translate relative days of the week

aacid requested changes to this revision. aacid added a reviewer: aacid. aacid added a comment. This revision now requires changes to proceed. I find the comments misleading (maybe because i'm not english native) but if (daysTo < -1) { switch (date.dayOfWeek()) { case

[Differential] [Closed] D4096: KConfigDialog_UnitTest: cover also custom config widgets

This revision was automatically updated to reflect the committed changes. Closed by commit R265:cb51f3e6aaa7: KConfigDialog_UnitTest: cover also custom config widgets (authored by kossebau). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4096?vs=10083&i

[Differential] [Accepted] D4096: KConfigDialog_UnitTest: cover also custom config widgets

aacid accepted this revision. aacid added a reviewer: aacid. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH extendKConfigDialog_UnitTest REVISION DETAIL https://phabricator.kde.org/D4096 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

> On Jan. 12, 2017, 9:08 p.m., Christoph Feck wrote: > > src/kfontrequester.cpp, line 51 > > > > > > Here you are creating a second QFontInfo object. oops, thanks > On Jan. 12, 2017, 9:08 p.m., Christoph Feck w

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 368 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/368/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 12 Jan 2017 18:10:05 + Build duration: 8 min 3 sec CHANGE SET Revision 3261c842a2a95c2c7748196ff2ebc2f994621e9a b

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 372 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/372/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 12 Jan 2017 18:10:05 + Build duration: 7 min 39 sec CHANGE SET Revision 3261c842a2a95c2c7748196ff2ebc2f994

[Differential] [Closed] D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3261c842a2a9: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication (authored by kossebau). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3977?vs=978

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129809/#review101970 --- src/kfontrequester.cpp (line 51)

Review Request 129809: KFontRequester: Find the nearest match for a missing font

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129809/ --- Review request for KDE Frameworks and Christoph Feck. Bugs: 286260 ht

Re: Review Request 129807: proposal: add ksvg2ico

> On Jan. 12, 2017, 6:23 p.m., Christoph Feck wrote: > > Someone more experienced with legal matters should review the verbatim > > inclusion of Qt code; in particular the license header. FWIW, the Qt code included in KDEWin's png2ico is almost identical, except for the license header. I've pu

Re: Review Request 129807: proposal: add ksvg2ico

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/#review101968 --- Someone more experienced with legal matters should review th

Re: Review Request 129807: proposal: add ksvg2ico

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/ --- (Updated Jan. 12, 2017, 6:01 p.m.) Review request for KDE Frameworks, kde

Re: Review Request 129807: proposal: add ksvg2ico

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/ --- (Updated Jan. 12, 2017, 5:47 p.m.) Review request for KDE Frameworks, kde

Jenkins-kde-ci: oxygen Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 12 Jan 2017 15:38:25 + Build duration: 2 min 52 sec CHANGE SET No changes JUNIT RESULTS Nam

[Differential] [Closed] D3811: Use KPlugin for calendar applet plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3aec1bf2d379: Use KPlugin to load Calendar plugins (authored by dvratil). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3811?vs=10022&id=10101

[Differential] [Closed] D4092: Part Revert "[Units] Make iconSizes property constant"

This revision was automatically updated to reflect the committed changes. Closed by commit R242:66ebf2c84fee: Part Revert "[Units] Make iconSizes property constant" (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

[Differential] [Commented On] D4096: KConfigDialog_UnitTest: cover also custom config widgets

elvisangelaccio added a comment. +1 REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D4096 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks Cc: elvisangelaccio

[Differential] [Accepted] D4092: Part Revert "[Units] Make iconSizes property constant"

mart accepted this revision. mart added a reviewer: mart. mart added a comment. unfortunate that there are users expecting that signal (that doesn't really make sense) but ok as is the most compatible way REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from mast

Re: Review Request 129807: proposal: add ksvg2ico

> On Jan. 11, 2017, 9:54 p.m., Christoph Feck wrote: > > Could you test it with an SVG file that contains text? From what I > > remember, painting text requires a QGuiApplication to access the font > > database. > > > > Additionally, I do not like the hand-made command line parsing. We have >

Re: Review Request 129807: proposal: add ksvg2ico

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/ --- (Updated Jan. 12, 2017, 10:47 a.m.) Review request for KDE Frameworks, kd

Re: Review Request 129807: proposal: add ksvg2ico

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/#review101961 --- I'll deal with the feedback when I get back to my main dev m

[Differential] [Accepted] D4092: Part Revert "[Units] Make iconSizes property constant"

broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Oh, well… since we now have just one Units instance instead of a gazillion, should be fine. REPOSITORY R242 Plasma Framework (Library) BRANCH origi

[Differential] [Accepted] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. In https://phabricator.kde.org/D2075#76591, @jonathans wrote: > They interrupt the logical flow of the code, and because the conditionally executed code no longer sits inside an indented