Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/ --- (Updated Ян. 21, 2017, 7:52 преди обяд) Review request for KDE Frameworks

Re: Review Request 124089: Connected timeout before timer start.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/#review102141 --- I'm going to discard this as it seems that Jordan Hewitt did

Re: Review Request 124089: Connected timeout before timer start.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124089/ --- (Updated Jan. 21, 2017, 12:53 a.m.) Status -- This change has been d

[Differential] [Updated] D4227: Don't block when running the post-install command

apol added a reviewer: whiting. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D4227 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, mart, leinir, whiting

[Differential] [Updated] D4226: [KNS] Take into account the distribution type

apol added a reviewer: whiting. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D4226 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, leinir, whiting

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated Jan. 21, 2017, 12:46 a.m.) Status -- This change has been d

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On Oct. 19, 2015, 6:50 p.m., Rex Dieter wrote: > > May as well drop this now, it's largely superceded by code in in repo > > already, for example, > > https://quickgit.kde.org/?p=sonnet.git&a=commit&h=0e6edac621fbd366b126ebd851fbea21355e02d0 Dropping as suggested by Rex. - Albert ---

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126418/#review102134 --- Unfortunately noone commited this patch and doesn't apply an

Re: Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129526/ --- (Updated Jan. 21, 2017, 12:12 a.m.) Status -- This change has been m

Re: Review Request 129860: Fix warning when destructing a KPixmapSequenceWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129860/ --- (Updated Jan. 21, 2017, 1:02 a.m.) Status -- This change has been ma

Re: Review Request 129860: Fix warning when destructing a KPixmapSequenceWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129860/#review102125 --- Ship it! >From looking at the code, m_started can only be

Re: Review Request 127223: Don't emit destroyedChanged(true) twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127223/#review102121 --- Doesn't apply anymore. - Albert Astals Cid On Feb. 29, 20

Re: Review Request 126758: Drop support for building with Qt 4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126758/ --- (Updated Jan. 20, 2017, 11:25 p.m.) Status -- This change has been m

Re: Review Request 129855: Treat no passphrase as Solid::UserCanceled error

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129855/ --- (Updated Jan. 20, 2017, 11:39 p.m.) Status -- This change has been m

Review Request 129860: Fix warning when destructing a KPixmapSequenceWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129860/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 223 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/223/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 Jan 2017 21:35:48 + Build duration: 7 min 38 sec CHANGE SET No changes JUNIT RESULTS Name: (ro

[Differential] [Commented On] D4228: Add an image/ktx mimetype

dfaure added a comment. Please do submit upstream, I handle those incoming requests together with Bastien. http://www.freedesktop.org/wiki/Specifications/AddingMIMETutor (link at bottom for freedesktop bugzilla with predefined query) I would be useful if you could also submit a

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 219 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/219/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 Jan 2017 21:33:41 + Build duration: 1 min 45 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 219 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/219/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 Jan 2017 21:33:41 + Build duration: 1 min 45 sec CHANGE SET No changes JUNIT RESULTS Nam

Re: Review Request 129855: Treat no passphrase as Solid::UserCanceled error

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129855/#review102119 --- Ship it! Ship It! - Lamarque Souza On Jan. 20, 2017, 9

Re: Review Request 129859: Add benchmark for KTextToHTML::convertToHtml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129859/#review102118 --- Ship it! Ship It! - David Faure On Jan. 20, 2017, 8:21

Re: Review Request 129856: KEmoticons: performance improvement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129856/ --- (Updated Jan. 20, 2017, 9:21 p.m.) Status -- This change has been ma

[Differential] [Commented On] D4228: Add an image/ktx mimetype

fredrik added a comment. In https://phabricator.kde.org/D4228#78967, @ltoscano wrote: > Was the request submitted to shared-mime-info too? It was not. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4228 EMAIL PREFERENCES https://phabricator.kde.or

Review Request 129859: Add benchmark for KTextToHTML::convertToHtml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129859/ --- Review request for KDE Frameworks, David Faure, Daniel Vrátil, and Laurent

[Differential] [Commented On] D4228: Add an image/ktx mimetype

ltoscano added a comment. Was the request submitted to shared-mime-info too? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4228 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fredrik, #frameworks Cc: ltoscano

[Differential] [Request, 9 lines] D4228: Add an image/ktx mimetype

fredrik created this revision. fredrik added a reviewer: Frameworks. fredrik set the repository for this revision to R244 KCoreAddons. Restricted Application added a project: Frameworks. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4228 AFFECTED FILES src/mimety

[Differential] [Request, 62 lines] D4227: Don't block when running the post-install command

apol created this revision. apol added reviewers: Frameworks, mart, leinir. Restricted Application added a project: Frameworks. REVISION SUMMARY Which in fact is the install command for KPackages BUG: 375287 REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricato

[Differential] [Request, 2 lines] D4226: [KNS] Take into account the distribution type

apol created this revision. apol added reviewers: Frameworks, leinir. Restricted Application added a project: Frameworks. REVISION SUMMARY Otherwise we have an expression that doesn't do anything and possibly should be removed altogether. REPOSITORY R304 KNewStuff BRANCH master REVISION

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 399 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/399/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 Jan 2017 14:51:59 + Build duration: 6 min 13 sec CHANGE SET Revision 07ebbd6fdf9a36eff0356154fab1229ce2

Re: Review Request 129856: KEmoticons: performance improvement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129856/#review102112 --- Ship it! Ship It! - David Edmundson On Jan. 20, 2017,

Review Request 129856: KEmoticons: performance improvement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129856/ --- Review request for KDE Frameworks, Martin Klapetek, Harald Sitter, and Volk

[Differential] [Commented On] D4214: Make sure we display enabled ListItem on hover

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in ListItem.qml:97 > > in fact it's what it was supposed to happen in the first place > > We have the highlight for the item under mouse. > Why should the delegate change too? If that's the case, then we should remove the opaci

Re: Review Request 129857: Remove unused jp2.desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129857/ --- (Updated Jan. 20, 2017, 2:22 p.m.) Status -- This change has been di

Review Request 129857: Remove unused jp2.desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129857/ --- Review request for KDE Frameworks and Alex Merry. Repository: kimageforma

Re: Review Request 129760: Fixup handling of KFontUtils::adaptFontSize's flags' default value.

I've actually switched all activity to KDE/master (I'm presently on a5f3a76e14799c68b5e8f74e375baa5f6f6ab4dc), so I'll check again when I've got your latest updates. BTW, one other thing I noticed was this, if I "make clean" in kguiaddons, src/sip/PyKF5/KGuiAddons/KGuiAddonsmod.sip is not removed.

Review Request 129855: Treat no passphrase as Solid::UserCanceled error

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129855/ --- Review request for KDE Frameworks and Solid. Repository: solid Descript

[Differential] [Updated] D4201: Make it possible to lower KCrash to tier 1

dfaure added a comment. In https://phabricator.kde.org/D4201#78794, @apol wrote: > Still using QPluginLoader and QDirIterator which probably are as bad as those. That is a very big problem. QDirIterator could be ported to lower-level APIs, but plugin loading means memory allocati

[Differential] [Changed Subscribers] D4201: Make it possible to lower KCrash to tier 1

shumski added inline comments. INLINE COMMENTS > config-kcrash.h.cmake:7 > + > +#cmakedefine KCRASH_PLUGIN_INSTALL_DIR "${KCRASH_PLUGIN_INSTALL_DIR}" CMAKE_INSTALL_FULL_PLUGINDIR/kcrashhandlers REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D4201 EMAIL PREFERENCES ht

Re: Qt::WindowFlags f = nullptr in framworks headers

On Friday, 20 January 2017 09:19:21 CET Kevin Funk wrote: > On Wednesday, 18 January 2017 21:12:07 CET Stephen Kelly wrote: > > Hello, > > > > As a result of the recent porting from 0 to nullptr, we have things like > > > > Qt::WindowFlags f = nullptr Please ignore my reply, haven't seen the di

Re: Qt::WindowFlags f = nullptr in framworks headers

On Wednesday, 18 January 2017 21:12:07 CET Stephen Kelly wrote: > Hello, > > As a result of the recent porting from 0 to nullptr, we have things like > > Qt::WindowFlags f = nullptr > > in frameworks headers. See for example kruler. That is - enum default > parameter values have been ported inc