[Differential] [Accepted] D4300: Simpler calculation of longest line limit

2017-01-26 Thread Milian Wolff
mwolff accepted this revision. mwolff added a reviewer: mwolff. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4300 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: gszymaszek,

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

2017-01-26 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129892/#review102269 --- So, wait a minute i just quote you *This patch attempts to

Re: Sonnet: Trigram data file for Greek

2017-01-26 Thread John Salatas
On 2017-01-24 04:03 PM, Christoph Feck wrote: On 24.01.2017 19:45, John Salatas wrote: On 2017-01-24 10:40 AM, Christoph Feck wrote: On 24.01.2017 09:01, John Salatas wrote: I just built a trigram data file (attached) for Greek language using a wikipedia dump as corpus. Can I just push it to

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

2017-01-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129892/#review102263 --- Ship it! Ship It! - David Faure On Jan. 26, 2017,

Re: Review Request 129885: [KStandadAction] Correct menubars logic

2017-01-26 Thread Albert Astals Cid
> On Jan. 25, 2017, 11:15 p.m., Albert Astals Cid wrote: > > I briefly looked at dolphins code a while ago and i'm pretty sure the code > > is wrong in dolphin > > Albert Astals Cid wrote: > BTW what do you mean with "Works correct on KDE"? > > Anthony Fieroni wrote: > The code in

Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

2017-01-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129892/ --- Review request for KDE Frameworks, Anthony Fieroni and David Faure.

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

2017-01-26 Thread Demitrius Belai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126418/ --- (Updated Jan. 26, 2017, 9:30 p.m.) Status -- This change has been

[Differential] [Resigned From] D4253: redesign gwenview icon

2017-01-26 Thread Albert Astals Cid
aacid resigned from this revision. aacid removed a reviewer: aacid. aacid added a comment. I don't have an opinion, not good in saying which icon is nicer than others. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4253 EMAIL PREFERENCES

[Differential] [Request, 2 lines] D4300: Simpler calculation of longest line limit

2017-01-26 Thread Grzegorz Szymaszek
gszymaszek created this revision. gszymaszek added a reviewer: KTextEditor. gszymaszek set the repository for this revision to R39 KTextEditor. gszymaszek added a project: KTextEditor. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project:

[Differential] [Commented On] D4294: Latex Syntax: Fix identification of alignat environment end

2017-01-26 Thread Dominik Haumann
dhaumann added a comment. The patch is almost good: Whenever we change a .xml file, we also need to increase the version number in https://phabricator.kde.org/D4294 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hfujimoto,

[Differential] [Commented On] D4253: redesign gwenview icon

2017-01-26 Thread Andrea Del Sarto
adelsarto added a comment. I also think that we shouldn't update the icon. I like the current one. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4253 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze,

[Differential] [Updated] D4253: redesign gwenview icon

2017-01-26 Thread Alexey Varfolomeev
varlesh added reviewers: sandsmark, aacid, cfeck. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4253 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze, andreask, sandsmark, aacid, cfeck Cc: alex-l, andreaska,

[Differential] [Commented On] D4253: redesign gwenview icon

2017-01-26 Thread Alexey Varfolomeev
varlesh added a comment. gwenview devs please tell what you like icon for Breeze 1 or 2? 1:1 F2181407: Снимок экрана от 2017-01-26 20-02-37.png zoomed F2181414: Снимок экрана от 2017-01-26 20-10-44.png

[Differential] [Accepted] D4288: Add Kleopatra tray icon

2017-01-26 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4288 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Closed] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

2017-01-26 Thread Alexey Varfolomeev
This revision was automatically updated to reflect the committed changes. Closed by commit R266:0fda78588faf: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter (authored by varlesh). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

[Differential] [Request, 4 lines] D4296: Fixed single line comments in Less starting new regions

2017-01-26 Thread Grzegorz Szymaszek
gszymaszek created this revision. gszymaszek added a reviewer: Framework: Syntax Hightlighting. gszymaszek set the repository for this revision to R216 Syntax Highlighting. gszymaszek added a project: Framework: Syntax Hightlighting. Restricted Application added a project: Frameworks. Restricted

[Differential] [Closed] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

2017-01-26 Thread David Rosca
This revision was automatically updated to reflect the committed changes. Closed by commit R242:d2c7435b1bc1: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate (authored by drosca). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

2017-01-26 Thread Andreas Kainz
andreaska accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4278 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, alex-l, andreaska, #breeze Cc:

[Differential] [Commented On] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

2017-01-26 Thread Alexey Varfolomeev
varlesh added a comment. diff updated: F2180675: Снимок экрана от 2017-01-26 17-54-36.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4278 EMAIL PREFERENCES

[Differential] [Updated, 983 lines] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

2017-01-26 Thread Alexey Varfolomeev
varlesh updated this revision to Diff 10587. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4278?vs=10542=10587 REVISION DETAIL https://phabricator.kde.org/D4278 AFFECTED FILES icons/apps/48/bittorent-sync.svg icons/apps/48/bittorrent-sync.svg

[Differential] [Accepted] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

2017-01-26 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4282 EMAIL PREFERENCES

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

2017-01-26 Thread Demitrius Belai
> On Jan. 21, 2017, 12:44 a.m., Albert Astals Cid wrote: > > Unfortunately noone commited this patch and doesn't apply anymore, could > > you update it? > > Demitrius Belai wrote: > Sure. I have to submit new request review because the PackageStructure > plugin for kpackagetool5 must be

[Differential] [Request, 2 lines] D4294: Latex Syntax: Fix identification of alignat environment end

2017-01-26 Thread Hironori Fujimoto
hfujimoto created this revision. hfujimoto added a reviewer: Framework: Syntax Hightlighting. hfujimoto added a subscriber: kwrite-devel. hfujimoto set the repository for this revision to R216 Syntax Highlighting. hfujimoto added a project: Framework: Syntax Hightlighting. Restricted Application

[Differential] [Updated] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

2017-01-26 Thread Alessandro Longo
alex-l added a comment. For me new ones don't follow the guidelines and Breeze style. Please use the current icons as reference implementation. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4278 EMAIL PREFERENCES

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

2017-01-26 Thread Demitrius Belai
> On Jan. 21, 2017, 12:44 a.m., Albert Astals Cid wrote: > > Unfortunately noone commited this patch and doesn't apply anymore, could > > you update it? Sure. I have to submit new request review because the PackageStructure plugin for kpackagetool5 must be in the kwin repository. -

[Differential] [Commented On] D4289: Add VLC tray icon

2017-01-26 Thread Yunhe Guo
guoyunhe added a comment. In https://phabricator.kde.org/D4289#80406, @andreaska wrote: > can you upload the svgz file cause I can't download it here. Uploaded REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4289 EMAIL PREFERENCES

[Differential] [Updated] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

2017-01-26 Thread Andreas Kainz
andreaska added a comment. +1 bittorent sync +1 darktable +1 ffmulticonverter codeblocks is better but the hammer had to much different colors I think REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4278 EMAIL PREFERENCES

[Differential] [Updated] D4288: Add Kleopatra tray icon

2017-01-26 Thread Yunhe Guo
guoyunhe updated the summary for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4288 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #plasma Cc: plasma-devel, guoyunhe, #frameworks,

[Differential] [Updated] D4289: Add VLC tray icon

2017-01-26 Thread Yunhe Guo
guoyunhe updated the summary for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4289 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #plasma:_design Cc: andreaska, guoyunhe, #frameworks

[Differential] [Commented On] D4289: Add VLC tray icon

2017-01-26 Thread Andreas Kainz
andreaska added a comment. can you upload the svgz file cause I can't download it here. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4289 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe,

[Differential] [Request, 0 lines] D4289: Add VLC tray icon

2017-01-26 Thread Yunhe Guo
guoyunhe created this revision. guoyunhe added a reviewer: Plasma: Design. guoyunhe set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY F2171236:

[Differential] [Request, 0 lines] D4288: Add Kleopatra tray icon

2017-01-26 Thread Yunhe Guo
guoyunhe created this revision. guoyunhe added a reviewer: Plasma. guoyunhe set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY