[Differential] [Updated, 240 lines] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide

2017-01-28 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 10669. kossebau added a comment. deduplicate unit tests REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4329?vs=10667=10669 BRANCH fixKMessageWidgetInstantShowHide REVISION DETAIL

[Differential] [Request, 288 lines] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide

2017-01-28 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, dhaumann. Restricted Application added a project: Frameworks. REVISION SUMMARY Calling animatedHide() on a not yet shown KMessageWidget instance was ignored when the parent And instant counter-direction updates (like it

Phabricator: All repositories registered - upcoming workflow changes

2017-01-28 Thread Ben Cooksley
Hi everyone, We've just completed the registration of all mainline repositories (not including Websites or Sysadmin namespaced ones) on Phabricator. Thanks go to Luigi Toscano for providing significant assistance with this process. >From this point forward, communities should be moving away from

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

2017-01-28 Thread Anthony Fieroni
> On Ян. 27, 2017, 7:01 преди обяд, Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > > the show menu bar action

[Differential] [Accepted] D4320: Don't fail when moving to the temp directory when installing

2017-01-28 Thread Marco Martin
mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > installation.cpp:546 > if (success) { > +if (installpath.startsWith(QDir::tempPath())) > +file.remove(installpath); if ()

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

2017-01-28 Thread Albert Astals Cid
> On gen. 27, 2017, 5:01 a.m., Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > > the show menu bar action (basically

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

2017-01-28 Thread Anthony Fieroni
> On Ян. 27, 2017, 7:01 преди обяд, Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > > the show menu bar action

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

2017-01-28 Thread Anthony Fieroni
> On Ян. 27, 2017, 7:01 преди обяд, Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > > the show menu bar action

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

2017-01-28 Thread Albert Astals Cid
> On Jan. 27, 2017, 5:01 a.m., Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > > the show menu bar action (basically

[Differential] [Abandoned] D4258: redesign gimp icon

2017-01-28 Thread Alexey Varfolomeev
varlesh abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4258 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze Cc: andreaska, alex-l, #frameworks

[Differential] [Abandoned] D4253: redesign gwenview icon

2017-01-28 Thread Alexey Varfolomeev
varlesh abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4253 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze, andreask, sandsmark, cfeck Cc: adelsarto, alex-l, andreaska, #frameworks

Re: Review Request 129842: KAuth: update most of the examples, drop outdated ones

2017-01-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129842/#review102297 --- Ship it! Great work. KAuth was really lacking

Re: Review Request 129842: KAuth: update most of the examples, drop outdated ones

2017-01-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129842/#review102296 --- Ping? - Elvis Angelaccio On Jan. 15, 2017, 5:10 p.m.,

Re: Review Request 129849: KToolTipWidget: don't take ownership of the content widget

2017-01-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129849/#review102295 --- Ping? - Elvis Angelaccio On Jan. 17, 2017, 10:47 p.m.,

Re: Review Request 129833: KToolTipWidget: hide immediately if content gets destroyed

2017-01-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129833/#review102294 --- Ping? - Elvis Angelaccio On Jan. 14, 2017, 6:54 p.m.,

[Differential] [Commented On] D4253: redesign gwenview icon

2017-01-28 Thread Andreas Kainz
andreaska added a comment. Varlesh you do awesome icon work, but gwenview was changed some time ago so no icon redesign needed sorry. Please work on other icons. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4253 EMAIL PREFERENCES