[Differential] [Updated, 392 lines] D4425: Add support for flatpak portals

jgrulich updated this revision to Diff 10951. jgrulich marked 11 inline comments as done. jgrulich added a comment. - Fix mentioned issues REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4425?vs=10890=10951 BRANCH master REVISION DETAIL

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 419 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/419/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Feb 2017 05:01:33 + Build duration: 5 min 14 sec CHANGE SET Revision b877345b63c1237ec09f3dbf9ec74267224b23cb

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 419 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/419/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Feb 2017 05:01:33 + Build duration: 5 min 14 sec CHANGE SET Revision b877345b63c1237ec09f3dbf9ec74267224b23cb

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 423 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/423/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Feb 2017 05:01:34 + Build duration: 7 min 28 sec CHANGE SET Revision

Re: Review Request 129921: [kio-extras] thumbnails should be a clean image representation without "hard-coded" borders or design elements

> On Feb. 5, 2017, 9:50 a.m., David Faure wrote: > > Can you also deprecate DrawFrame, then? How does stuff get deprecated in Frameworks? I don't have a lot of kde development (or development in general) experience. I also don't have a proper dev environment setup atm. - Diego

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 418 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/418/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Feb 2017 00:00:41 + Build duration: 6 min 58 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 241 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/241/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 23:21:00 + Build duration: 2 min 4 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 236 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/236/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 23:06:56 + Build duration: 1 min 39 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 236 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/236/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 23:06:56 + Build duration: 1 min 39 sec CHANGE SET No changes JUNIT RESULTS

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

El dilluns, 6 de febrer de 2017, a les 10:19:30 CET, Ben Cooksley va escriure: > On Mon, Feb 6, 2017 at 8:39 AM, Albert Astals Cid wrote: > > El dilluns, 6 de febrer de 2017, a les 8:18:04 CET, Ben Cooksley va escriure: > >> On Sun, Feb 5, 2017 at 6:24 AM, Albert Astals Cid

[Differential] [Commented On] D4439: KDirWatch: fix memory leak on destruction.

aacid added a comment. In https://phabricator.kde.org/D4439#83326, @dfaure wrote: > In https://phabricator.kde.org/D4439#83310, @aacid wrote: > > > In https://phabricator.kde.org/D4439#83166, @dfaure wrote: > > > > > It's not crazy, but > > > > > > - then it should use QVector

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

On Mon, Feb 6, 2017 at 8:39 AM, Albert Astals Cid wrote: > El dilluns, 6 de febrer de 2017, a les 8:18:04 CET, Ben Cooksley va escriure: >> On Sun, Feb 5, 2017 at 6:24 AM, Albert Astals Cid wrote: >> > El dissabte, 4 de febrer de 2017, a les 12:44:54 CET, Ben

[Differential] [Commented On] D4439: KDirWatch: fix memory leak on destruction.

dfaure added a comment. In https://phabricator.kde.org/D4439#83310, @aacid wrote: > In https://phabricator.kde.org/D4439#83166, @dfaure wrote: > > > It's not crazy, but > > > > - then it should use QVector instead of QList (Client is a "big" struct, bigger than a pointer) > >

[Differential] [Commented On] D4439: KDirWatch: fix memory leak on destruction.

markg added a comment. In https://phabricator.kde.org/D4439#83310, @aacid wrote: > In https://phabricator.kde.org/D4439#83166, @dfaure wrote: > > > It's not crazy, but > > > > - then it should use QVector instead of QList (Client is a "big" struct, bigger than a pointer) > >

Jenkins-kde-ci: kfilemetadata master stable-kf5-qt5 » Linux,gcc - Build # 164 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kfilemetadata%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/164/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 19:48:30 + Build duration: 7 min 54 sec CHANGE SET Revision

Jenkins-kde-ci: kfilemetadata master stable-kf5-qt5 » Linux,gcc - Build # 164 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kfilemetadata%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/164/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 19:48:30 + Build duration: 7 min 54 sec CHANGE SET Revision

Jenkins-kde-ci: kfilemetadata master kf5-qt5 » Linux,gcc - Build # 166 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/166/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 19:48:30 + Build duration: 1 min 58 sec CHANGE SET Revision

Jenkins-kde-ci: kfilemetadata master kf5-qt5 » Linux,gcc - Build # 166 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/166/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 19:48:30 + Build duration: 1 min 58 sec CHANGE SET Revision

Re: Review Request 129925: fix build of kfilemetadata with taglib version 1.9

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129925/ --- (Updated Feb. 5, 2017, 7:48 p.m.) Status -- This change has been

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

El dilluns, 6 de febrer de 2017, a les 8:18:04 CET, Ben Cooksley va escriure: > On Sun, Feb 5, 2017 at 6:24 AM, Albert Astals Cid wrote: > > El dissabte, 4 de febrer de 2017, a les 12:44:54 CET, Ben Cooksley va > > > > escriure: > >> On Sat, Feb 4, 2017 at 11:41 AM, Albert Astals

Re: Review Request 129925: fix build of kfilemetadata with taglib version 1.9

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129925/#review102420 --- Ship it! Ship It! - David Faure On Feb. 5, 2017, 4:39

[Differential] [Commented On] D4439: KDirWatch: fix memory leak on destruction.

aacid added a comment. In https://phabricator.kde.org/D4439#83166, @dfaure wrote: > It's not crazy, but > > - then it should use QVector instead of QList (Client is a "big" struct, bigger than a pointer) The problem with QVector is that it doesn't have erase(iterator) built

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

On Sun, Feb 5, 2017 at 6:24 AM, Albert Astals Cid wrote: > El dissabte, 4 de febrer de 2017, a les 12:44:54 CET, Ben Cooksley va > escriure: >> On Sat, Feb 4, 2017 at 11:41 AM, Albert Astals Cid wrote: >> > El divendres, 3 de febrer de 2017, a les 21:06:08 CET, Ben

Jenkins-kde-ci: kfilemetadata master kf5-qt5 » Linux,gcc - Build # 165 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/165/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 17:17:02 + Build duration: 6 min 54 sec CHANGE SET Revision

Jenkins-kde-ci: kfilemetadata master stable-kf5-qt5 » Linux,gcc - Build # 163 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kfilemetadata%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/163/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 17:17:01 + Build duration: 6 min 6 sec CHANGE SET Revision

Re: Review Request 129925: fix build of kfilemetadata with taglib version 1.9

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129925/ --- (Updated Feb. 5, 2017, 5:39 p.m.) Review request for Baloo and KDE

Jenkins-kde-ci: kfilemetadata master kf5-qt5 » Linux,gcc - Build # 164 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/164/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 16:06:51 + Build duration: 33 sec CHANGE SET Revision

[Differential] [Request, 177 lines] D4448: Don't use tier3 frameworks in unit tests

svuorela created this revision. svuorela added reviewers: sitter, vonreth, kde-frameworks-devel. svuorela set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Port

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129720/ --- (Updated Feb. 5, 2017, 4:06 p.m.) Status -- This change has been

[Differential] [Closed] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide

This revision was automatically updated to reflect the committed changes. Closed by commit R236:ec02ee4b85a4: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide (authored by kossebau). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: kfilemetadata master stable-kf5-qt5 » Linux,gcc - Build # 161 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kfilemetadata%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/161/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 15:30:26 + Build duration: 1 min 53 sec CHANGE SET Revision

Jenkins-kde-ci: kfilemetadata master kf5-qt5 » Linux,gcc - Build # 163 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/163/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 15:30:26 + Build duration: 35 sec CHANGE SET Revision

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129798/ --- (Updated Feb. 5, 2017, 4:30 p.m.) Status -- This change has been

[Differential] [Closed] D4444: Make tier3 dependency for tests optional

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7109c9f7e5e6: Make tier3 dependency for tests optional (authored by vonreth). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D?vs=10932=10935 REVISION

[Differential] [Accepted] D4444: Make tier3 dependency for tests optional

svuorela accepted this revision. svuorela added a reviewer: svuorela. svuorela added a comment. This revision is now accepted and ready to land. I'm not fully sure what the scalable test does, but having tier3 libraries required for tests in tier1 thingns is a bit bad to me. REPOSITORY

[Differential] [Accepted] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. KTextEditor uses KMessageWidget 4 times: floating inside on top right or bottom right. This is what you hacked. And 2 times above and below. These two times use the animation, but

[Differential] [Updated] D4444: Make tier3 dependency for tests optional

vonreth added a reviewer: sitter. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vonreth, sitter Cc: #frameworks

[Differential] [Request, 24 lines] D4444: Make tier3 dependency for tests optional

vonreth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D AFFECTED FILES CMakeLists.txt

[Differential] [Closed] D4294: Latex Syntax: Fix identification of alignat environment end

This revision was automatically updated to reflect the committed changes. Closed by commit R216:540fb97a8764: LaTeX highlighting: fix alignat environment (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4294?vs=10646=10931#toc REPOSITORY R216 Syntax Highlighting

[Differential] [Commented On] D4439: KDirWatch: fix memory leak on destruction.

dfaure added a comment. QScopedPointer wouldn't work here (this isn't about a scope). std::unique_ptr would most certainly work, but then again, why use pointers where values can work. I like Albert's approach overall, with only the two concerns I listed. REPOSITORY R244 KCoreAddons

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129839/#review102409 --- src/extractors/taglibextractor.cpp (line 111)

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129839/ --- (Updated Feb. 5, 2017, 2:02 p.m.) Review request for Baloo and KDE

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

> On Feb. 5, 2017, 10:45 a.m., David Faure wrote: > > Patch looks ok to me, although I don't know much about all this. > > > > The real problem isn't tooling, but lack of active maintainership for > > kfilemetadata. Are you interested in taking over? > > Matthieu Gallien wrote: > Hello, >

[Differential] [Commented On] D4439: KDirWatch: fix memory leak on destruction.

markg added a comment. Hmm, this is exactly the reason why i always go for either smart pointers or stack objects. Both prevent this issue from occurring in the first place. It's probably a bit much to make the Entry class own the objects (basically the diff of Albert). But there i

[Differential] [Commented On] D4439: KDirWatch: fix memory leak on destruction.

dfaure added a comment. It's not crazy, but - then it should use QVector instead of QList (Client is a "big" struct, bigger than a pointer) - I would be worried about copies happening unexpectedly (can this code compile with forbidden copy ctor for Client? I guess not as is due to

[Differential] [Accepted] D4439: KDirWatch: fix memory leak on destruction.

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Looks good to me, we could also go the crazy way and hold the data in m_clients instead of holding the ptr to the data http://paste.ubuntu.com/23933091/ But I'm pretty sure i did some

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 235 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/235/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 11:07:16 + Build duration: 2 min 6 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/ --- (Updated Feb. 5, 2017, 12:24 p.m.) Status -- This change has been

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 149 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/149/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 05 Feb 2017 10:16:31 + Build duration: 13 min CHANGE SET No changes

[Differential] [Request, 11 lines] D4439: KDirWatch: fix memory leak on destruction.

dfaure created this revision. dfaure added reviewers: aacid, mpyne. dfaure added a subscriber: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY The Entry class owns the Client instances, so it should delete the remaining instances in its destructor, for the

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 151 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/151/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 05 Feb 2017 10:16:30 + Build duration: 1 min 46 sec CHANGE SET No changes

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 151 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/151/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 05 Feb 2017 10:16:30 + Build duration: 1 min 46 sec CHANGE SET No changes

Jenkins-kde-ci: kitemviews master kf5-qt5 » Linux,gcc - Build # 130 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kitemviews%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/130/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 10:16:02 + Build duration: 10 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kitemviews master kf5-qt5 » Linux,gcc - Build # 130 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kitemviews%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/130/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 05 Feb 2017 10:16:02 + Build duration: 10 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

> On Feb. 5, 2017, 9:45 a.m., David Faure wrote: > > Patch looks ok to me, although I don't know much about all this. > > > > The real problem isn't tooling, but lack of active maintainership for > > kfilemetadata. Are you interested in taking over? > > Matthieu Gallien wrote: > Hello, >

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

> On Feb. 5, 2017, 10:45 a.m., David Faure wrote: > > Patch looks ok to me, although I don't know much about all this. > > > > The real problem isn't tooling, but lack of active maintainership for > > kfilemetadata. Are you interested in taking over? Hello, I have a real interest in

Re: Review Request 129921: [kio-extras] thumbnails should be a clean image representation without "hard-coded" borders or design elements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129921/#review102402 --- Ship it! Can you also deprecate DrawFrame, then? -

Re: Review Request 129911: Added property() method to TerminalInterface class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129911/#review102401 --- Alas, this is a binary incompatible change. It cannot be

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/#review102400 --- Ship it! Ship It! - David Faure On Feb. 2, 2017,

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129798/#review102399 --- Ship it! Patch looks ok to me, although I don't know

[Differential] [Updated] D4431: Add KUrlRequester::setMimeTypeFilters.

dfaure marked an inline comment as done. dfaure added inline comments. INLINE COMMENTS > cfeck wrote in kurlrequester.h:144 > The APIDOX for these two functions are somehow swapped. Thanks for noticing, fixed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4431 EMAIL

[Differential] [Closed] D4247: KIconEngine: Center icon in requested rect

This revision was automatically updated to reflect the committed changes. Closed by commit R302:456b57d71c67: KIconEngine: Center icon in requested rect (authored by drosca). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4247?vs=10438=10923 REVISION