[Differential] [Updated] D4510: Python bindings: Restore handling of deprecated constructs.

lbeltrame added reviewers: skelly, Build System, Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4510 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: shaheed, skelly, #build_system, #frameworks Cc: #frameworks

[Differential] [Updated] D4509: Python bindings: Some comment-only tidyups and PEP-8 fixes.

lbeltrame added reviewers: Build System, skelly, Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4509 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: shaheed, #build_system, skelly, #frameworks Cc: #frameworks

[Differential] [Abandoned] D3661: Downgrade required ECM version to 5.26

cfeck abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D3661 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cfeck, vkrause, antlarr Cc: #frameworks

[Differential] [Commandeered] D3661: Downgrade required ECM version to 5.26

cfeck commandeered this revision. cfeck added a reviewer: antlarr. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D3661 EMAIL PREFERENCES https://phab

[Differential] [Closed] D4496: Don't use KConfig keys with backslashes

This revision was automatically updated to reflect the committed changes. Closed by commit R263:4c436ce2a291: Don't use KConfig keys with backslashes (authored by elvisangelaccio). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4496?vs=11055&id=11088 REVISION

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 426 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/426/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 08 Feb 2017 23:30:02 + Build duration: 7 min 9 sec CHANGE SET No changes JUNIT RESULTS Name: (r

[Differential] [Commented On] D4496: Don't use KConfig keys with backslashes

elvisangelaccio added a comment. In https://phabricator.kde.org/D4496#84368, @aacid wrote: > It's probably better to actually fix kile ;) > > But ok. I agree, even though if I press Alt+Shift+F in Kile I don't get the warning dialog, so I suppose the two actions are not enable

[Differential] [Commented On] D4392: Fix KEditListWidget losing the focus on click of buttons

kossebau added a comment. @cfeck, thanks for review so far. No(one a) further comment on this fix? Will push on Feb 15th then unless someone objects. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D4392 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Accepted] D4496: Don't use KConfig keys with backslashes

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. It's probably better to actually fix kile ;) But ok. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D4496 EMAIL PREFERENCES https://phabricat

[Differential] [Request, 20 lines] D4510: Python bindings: Restore handling of deprecated constructs.

shaheed created this revision. shaheed set the repository for this revision to R240 Extra CMake Modules. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. TEST PLAN Add to the unit tests and verify the result is m

[Differential] [Updated, 2,990 lines] D4508: [WIP] Plasma controls based on QtQuickControls2

mart updated this revision to Diff 11082. mart added a comment. - start a Plasma qqc2 style - add labels and button - add ToolButton - add checkboxes and check delegates - warnings-- - add ComboBox - add Container and Control - add Dialog, Popup - add Drawer - add Frame - ia

[Differential] [Reopened] D4508: [WIP] Plasma controls based on QtQuickControls2

mart reopened this revision. mart added inline comments. INLINE COMMENTS > broulik wrote in BusyIndicator.qml:28 > Apparently in Qt 5.8 the implicit sizes now take into account padding but > since we want to support 5.7 (?) makes sense. > > Mentioned in the changelog: > https://code.qt.io/cgit

[Differential] [Closed] D4508: [WIP] Plasma controls based on QtQuickControls2

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b2f6a9503738: separately install as style and import (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4508?vs=11077&id=11080#toc REPOSITORY R242 Plasma Framework (Library)

[Differential] [Updated] D4509: Python bindings: Some comment-only tidyups and PEP-8 fixes.

shaheed retitled this revision from "Some comment-only tidyups and PEP-8 fixes." to "Python bindings: Some comment-only tidyups and PEP-8 fixes.". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4509 EMAIL PREFERENCES https://phabricator.kde.org/settings/p

[Differential] [Request, 15 lines] D4509: Some comment-only tidyups and PEP-8 fixes.

shaheed created this revision. shaheed set the repository for this revision to R240 Extra CMake Modules. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. TEST PLAN No code changes. REPOSITORY R240 Extra CMake

[Differential] [Updated, 5,900 lines] D4508: [WIP] Plasma controls based on QtQuickControls2

mart updated this revision to Diff 11077. mart added a comment. - separately install as style and import REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11076&id=11077 BRANCH mart/qqc2style REVISION DETAIL https://phabricator

[Differential] [Commented On] D4508: [WIP] Plasma controls based on QtQuickControls2

broulik added a comment. Skimmed through it until `ItemDelegate.qml`, few nitpicks for that below INLINE COMMENTS > BusyIndicator.qml:28 > + > +implicitWidth: contentItem.implicitWidth + leftPadding + rightPadding > +implicitHeight: contentItem.implicitHeight + topPadding + bottomPadd

[Differential] [Request, 2,947 lines] D4508: [WIP] Plasma controls based on QtQuickControls2

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This is a basic styling of a QtQuickControls2 series based on Plasma theme. it has the main

Re: Review Request 129315: Don't install plasmoid desktop files as services

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/ --- (Updated Feb. 8, 2017, 3:37 p.m.) Status -- This change has been dis

Re: Review Request 122732: Add std::function overloads for KServiceTypeTrader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/#review102470 --- if it's still valid, please move it to phabricator - Marco

Re: Review Request 122732: Add std::function overloads for KServiceTypeTrader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/ --- (Updated Feb. 8, 2017, 3:30 p.m.) Status -- This change has been dis

Re: Review Request 129260: Add find module for QtPlatformSupport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/ --- (Updated Feb. 8, 2017, 2:25 nachm.) Status -- This change has been d

Re: Review Request 127800: Format number in KLocalizedString::subs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127800/ --- (Updated Feb. 8, 2017, 2:10 nachm.) Status -- This change has been d

Re: Review Request 128895: Return high-resolution line edit clear icon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128895/ --- (Updated Feb. 8, 2017, 2:09 nachm.) Status -- This change has been d

Re: Review Request 122732: Add std::function overloads for KServiceTypeTrader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/#review102447 --- Is this still relevant? If not, please discard it... - Seba

[Differential] [Request, 3 lines] D4496: Don't use KConfig keys with backslashes

elvisangelaccio created this revision. elvisangelaccio added a reviewer: aacid. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Kile has ambiguous shortcuts which result in the following string used as KConfig key for

[Differential] [Closed] D4493: [KCModuleQML] Pass the window as context for paletteChanged

This revision was automatically updated to reflect the committed changes. Closed by commit R295:3dd7345841be: [KCModuleQML] Pass the window as context for paletteChanged (authored by broulik). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4493?vs=11043&id=11

[Differential] [Commented On] D4495: Remove monochrome application icons

andreaska added a comment. when was the last release for ktorrent? REVISION DETAIL https://phabricator.kde.org/D4495 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #breeze Cc: andreaska, #frameworks

[Differential] [Closed] D4425: Add support for flatpak portals

This revision was automatically updated to reflect the committed changes. Closed by commit R289:64451eb248e2: Add support for flatpak portals (authored by jgrulich). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4425?vs=11052&id=11053 REVISION DETAIL

[Differential] [Accepted] D4425: Add support for flatpak portals

broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Good stuff! REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D4425 EMAIL PREFERENCES https://phabricat

[Differential] [Updated] D4495: Remove monochrome application icons

guoyunhe updated the summary for this revision. REVISION DETAIL https://phabricator.kde.org/D4495 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #breeze Cc: andreaska, #frameworks

[Differential] [Updated] D4425: Add support for flatpak portals

jgrulich marked an inline comment as done. jgrulich added a comment. Patch updated to address all mentioned issues. Re-check it please. Thank you. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4425 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Commented On] D4495: Remove monochrome application icons

guoyunhe added a comment. Found a problem in KTorrent. But I guess we can change the icon used in KTorrent. F2426037: Spectacle.oq3409.png REVISION DETAIL https://phabricator.kde.org/D4495 EMAIL PREFERENCES https://phabricator.kde.org/settings/

[Differential] [Updated, 390 lines] D4425: Add support for flatpak portals

jgrulich updated this revision to Diff 11052. jgrulich added a comment. Fix mentioned issues REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4425?vs=10951&id=11052 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4425 AFFECTED FILES

[Differential] [Commented On] D4425: Add support for flatpak portals

apol added inline comments. INLINE COMMENTS > knotificationmanager.cpp:56 > > +bool inSandbox; > +bool portalDBusServiceExists; These could be a local variable, it's not being used outside for figuring out the backend. REPOSITORY R289 KNotifications REVISION DETAIL https://phabr

[Differential] [Commented On] D4495: Remove monochrome application icons

andreaska added a comment. please have a look at applications like amarok or ktorrent some icons are needed for this applications. REVISION DETAIL https://phabricator.kde.org/D4495 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #breeze Cc: a

[Differential] [Updated, 79 lines] D4495: Remove monochrome application icons

guoyunhe removed R266 Breeze Icons as the repository for this revision. guoyunhe updated this revision to Diff 11051. guoyunhe added a comment. Remove some extra icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4495?vs=11050&id=11051 REVISION DETAIL https://phabricator.kde.org

[Differential] [Request, 30 lines] D4495: Remove monochrome application icons

guoyunhe created this revision. guoyunhe added a reviewer: Breeze. guoyunhe set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY These monochrome icons cause applicat

[Differential] [Accepted] D4493: [KCModuleQML] Pass the window as context for paletteChanged

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D4493 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, graess

[Differential] [Updated] D4493: [KCModuleQML] Pass the window as context for paletteChanged

broulik updated the test plan for this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D4493 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, graesslin, dfaure Cc: plasma-devel, #frameworks, lesliezhai, ali

[Differential] [Request, 2 lines] D4493: [KCModuleQML] Pass the window as context for paletteChanged

broulik created this revision. broulik added reviewers: Plasma, graesslin, dfaure. broulik set the repository for this revision to R295 KCMUtils. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This d

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 238 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/238/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 08 Feb 2017 08:25:46 + Build duration: 2 min 49 sec CHANGE SET No changes JUNIT RESULTS Na

[Differential] [Closed] D4439: KDirWatch: fix memory leak on destruction.

dfaure closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4439 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, aacid, mpyne Cc: markg, #frameworks