jsalatas updated this revision to Diff 11494.
jsalatas added a comment.
1. I abandoned the 3rd issue I mention in the summary about the line
`scrollPos(max, max.column(), calledExternally);` as I could neither verify nor
disprove if this was intended or not.
2. In `cursorToCoordinate()`
On mardi 14 février 2017 08:17:33 CET Matthieu Gallien wrote:
> Hello,
>
> I am using Baloo to collect all audio files in its database. I would like to
> keep the list up to date with the Baloo database when my application is
> running.
>
> Currently Baloo DBus interface provides two
gszymaszek added a comment.
In https://phabricator.kde.org/D4537#87411, @cullmann wrote:
> Do you have commit rights? If not, paste your mail address and full name
and I can push your change with you as author.
No, I don’t have. Grzegorz Szymaszek, `gszymas...@short.pl`.
albertvaka added a comment.
I don't think indicators are the future of notifications :/
If you have a look at modern systems like Android (which had the luxury of
designing a notification system without having to think about legacy), they
have nothing like app indicators: they use
gszymaszek updated this revision to Diff 11486.
gszymaszek marked 5 inline comments as done.
gszymaszek added a comment.
Updated to work with new `cmake/FindEditorConfig.cmake`.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4537?vs=11366=11486
brauch added a comment.
Looks sensible to me, but can you check that it doesn't break KDevelop's
navigation widget? I think that is the most visible use case for that interface
right now.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4538
EMAIL PREFERENCES
mck182 added a comment.
I see your usecase, but I think there might be better solution overall
and that would involve not actually depending on the notification. As
you say, servers should enforce maximum timeout, Plasma does just
that and there's no safe way to predict what other
albertvaka added a comment.
I understand the potential of it being misused, even though I don't think we
should treat developers as if they didn't know what they are doing. Also, if we
want to have a maximum timeout, this is something that should be enforced on
the server (ie: Plasma)
cullmann added a comment.
> Currently if you try to convert the cursor to coordinates and then convert
these coordinates back to a cursor again, it produces an invalid cursor (-1,
-1) when the original cursor is located at the end of line
> Converting back to cursor coordinates that have
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
Hi, please adjust your patch to the EditorConfig find module commited to
ktexteditor.git.
Then this can land.
Do you have commit rights? If not, paste your mail address
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:6fa17cdccc06: add FindEditorConfig to ktexteditor if that
proves to be useful, can be moved… (authored by cullmann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4589?vs=11329=11485#toc
cullmann commandeered this revision.
cullmann added a reviewer: gszymaszek.
cullmann added a comment.
Hi, I think ATM only ktexteditor will need this, therefore I will add a small
find module to the ktexteditor repo.
If this is proven to be useful for other frameworks, too, we can move it.
mck182 added a comment.
This was discussed couple times before and the reason
this was never added is because of potential misuse of
this by setting extremely high value, making the bubble
virtually sticked to your screen forever. This should be
handled by the server that should do the
albertvaka added a reviewer: apol.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D4663
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: albertvaka, #frameworks, apol
Cc: #frameworks
albertvaka created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4663
AFFECTED FILES
src/knotification.cpp
albertvaka added a reviewer: Frameworks.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D4663
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: albertvaka, #frameworks
Cc: #frameworks
dhaumann added a comment.
Ok, I see. Then I would like you to look at how Qt Creator behaves here. And
agree, then the proposed patch is maybe better than thought. If you want, you
can even look into the implementation of Qt Creator...
REPOSITORY
R39 KTextEditor
REVISION DETAIL
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Looks good, fix the comments and commit!
INLINE COMMENTS
> kpagewidget.h:143
> * This signal is emitted whenever a checkable page changes its state.
> @param checked is true
> - *
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/253/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 18 Feb 2017 11:08:27 +
Build duration: 1 min 56 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/242/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 18 Feb 2017 11:08:04 +
Build duration: 1 min 59 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/252/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 18 Feb 2017 11:05:34 +
Build duration: 2 min 6 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/200/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 18 Feb 2017 11:01:43 +
Build duration: 5 min 34 sec
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/200/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 18 Feb 2017 11:01:43 +
Build duration: 5 min 34 sec
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/195/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 18 Feb 2017 11:01:48 +
Build duration: 2 min 23 sec
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/195/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 18 Feb 2017 11:01:48 +
Build duration: 2 min 23 sec
CHANGE SET
Revision
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129921/
---
(Updated Feb. 18, 2017, 10:52 a.m.)
Status
--
This change has been
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> dropjob.cpp:330
> +}
> +//separator at last position and not needed anymore?
> +if (d->m_appActions.isEmpty() && d->m_pluginActions.isEmpty() &&
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/199/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 18 Feb 2017 10:27:39 +
Build duration: 1 min 48 sec
CHANGE SET
Revision
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/194/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 18 Feb 2017 10:26:59 +
Build duration: 28 sec
CHANGE SET
Revision
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/198/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 18 Feb 2017 10:24:47 +
Build duration: 2 min 9 sec
CHANGE SET
Revision
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/193/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 18 Feb 2017 10:24:48 +
Build duration: 28 sec
CHANGE SET
Revision
dfaure marked an inline comment as done.
dfaure added inline comments.
INLINE COMMENTS
> dfaure wrote in kdirwatch.cpp:371
> Good point.
Done in
https://commits.kde.org/kcoreaddons/d7fb4a5ff2fdec24a922aebbcdb5901a117f56cf
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
dfaure closed this revision.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4584
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure, aacid, mwolff, mpyne
Cc: smartins, mwolff, #frameworks
33 matches
Mail list logo
