dfaure added a comment.
Looks good to me, just found two more minor things.
INLINE COMMENTS
> remoteimpl.cpp:31
> +
> +#include
> +
probably unused at this point
> remoteimpl.cpp:87
> +QDir dir = *dirpath;
> +if (!dir.exists()) {
> +continue;
The QDir object
mck182 added a comment.
> I don't think that KNotification as a framework should hide this feature
from the developer.
I, on the other hand, don't see why the developer should need
this feature; as I said before - there's no scenario where the
app should want either really short or
colomar added a comment.
I agree that what Android does makes a lot of sense. What they have is
- a permanent icon in the top bar for each application that still has an open
notification - basically an SNI, minus the direct interactivity (which makes
sense given that tiny icons are not
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
https://phabricator.kde.org/R242:d8a1a9eb084b19e552c789244267f7346e1b27a8
introduces an unintended code
change,
albertvaka added a comment.
I agree that just rising the timeout is suboptimal but I still like it better
than a modal dialog... Actually, notifications were invented as a way to avoid
harassing the user with modal dialogs when apps need attention.
Apart from that, and even if we end up
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
I tested this patch: I think, the footer's height is not correct when the box
is disabled, see: http://i.imgur.com/Te5XigY.png
When the box is activated, it has the same
anthonyfieroni created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Qt 5.8 has a bit changed and ungrabbing at show does not work.
REPOSITORY
R242 Plasma Framework (Library)
elvisangelaccio added a comment.
In https://phabricator.kde.org/D4690#88350, @ltoscano wrote:
> Is it an import with the git history as well?
Initially I wanted to do that, but then I decided against it because it's not
worth the effort imho. There are very few changes and a lot
ltoscano added a comment.
Is it an import with the git history as well?
REPOSITORY
R241 KIO
BRANCH
import-remote
REVISION DETAIL
https://phabricator.kde.org/D4690
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, dfaure,
elvisangelaccio added a comment.
In https://phabricator.kde.org/D4690#88306, @dfaure wrote:
> I know this isn't your code and you're just moving it to solve a dependency
issue. No problem, go ahead.
>
> But while at it I took at it, I look at the code and found a few issues,
feel
elvisangelaccio updated this revision to Diff 11597.
elvisangelaccio marked 2 inline comments as done.
elvisangelaccio added a comment.
- renamed kded module to allow co-installability with plasma-workspace <= 5.9
- fixed issues spotted by David
REPOSITORY
R241 KIO
CHANGES SINCE LAST
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:408b31166227: [FrameSvgItemMargins] Don't update on
repaintNeeded (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
mart edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4707
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart
Cc: #frameworks
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/433/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 21 Feb 2017 16:28:38 +
Build duration: 12 min
CHANGE SET
Revision a942db1a0dd5462127b5f7c276690a0694b2daf1 by
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/433/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 21 Feb 2017 16:28:38 +
Build duration: 12 min
CHANGE SET
Revision a942db1a0dd5462127b5f7c276690a0694b2daf1 by
broulik abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4362
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: mart, davidedmundson, plasma-devel, #frameworks,
mart updated this revision to Diff 11593.
mart added a comment.
- less svg renderer creation
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4707?vs=11589=11593
BRANCH
phab/framesvgrefactor
REVISION DETAIL
mart planned changes to this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4707
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a942db1a0dd5: [PreviewJob] Remove maximum size for local
files by default (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4552?vs=11185=11592#toc
REPOSITORY
R241 KIO
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
I know this isn't your code and you're just moving it to solve a dependency
issue. No problem, go ahead.
But while at it I took at it, I look at the code and found a few issues, feel
dfaure added a comment.
No objection.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D4552
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, emmanuelp, hein, dfaure
Cc: #frameworks
broulik added a comment.
David?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D4552
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, dfaure, emmanuelp, hein
Cc: #frameworks
mart planned changes to this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4707
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart
Cc: #frameworks
mart created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
make sure the framedata creation/destruction is
completely in updateFrameData, makes easier to track
and possible to use the
mck182 added a comment.
Well, I would argue that Android is using exactly indicators
which we know as SNIs. It's the same thing - it's an icon in
your top panel and when you pull the panel down, you see
the title, text and available actions. This is _exactly_ what
SNI does, it just so
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:148ff6311bfe: IconItemTest: Fix loadPixmap and loadImage
tests (authored by drosca).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4702
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: drosca,
drosca created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
It only works on CI because data/test_image.png size
is the same as implicitSize of IconItem (KIconLoader::Dialog).
drosca added a comment.
Yes, I want to use it in plasma-pa applet for volume indicator icons (the
small icon next to slider). Currently, they are too small but next round icon
size is already too big. This change will make it possible to make them just
few pixels bigger.
REPOSITORY
R242
alex-l added a comment.
I'd make the chess background full the folder's front.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D4633
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan, andreaska, alex-l
Cc: #frameworks
alex-l added a comment.
I'd make the chess background full the folder's front.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D4633
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan, andreaska, alex-l
Cc: #frameworks
31 matches
Mail list logo
