GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/syntax-highlighting%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/85/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 02 Mar 2017 05:59:53 +
Build duration: 5 min 53 sec
CHANGE SET
Revision 88f5456506ca22fa77b257dc70e
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/syntax-highlighting%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/85/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 02 Mar 2017 05:59:53 +
Build duration: 5 min 53 sec
CHANGE SET
Revision 88f5456506ca22fa77b257dc70e
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/syntax-highlighting%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/84/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 02 Mar 2017 05:59:53 +
Build duration: 6 min 14 sec
CHANGE SET
Revision 88f5456506ca22fa77b2
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/syntax-highlighting%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/84/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 02 Mar 2017 05:59:53 +
Build duration: 6 min 14 sec
CHANGE SET
Revision 88f5456506ca22fa77b2
Le mercredi 1 mars 2017, 22:57:09 CET Dominik Haumann a écrit :
> Hi Laurent,
Hi,
>
> whenever you change the xml files or change any unit test
> (highlight.js),
Oh I just fixed a typo in comment :)
> you need to run `make test`.
> Failing tests then need to be investigated. If you can verify
lbeltrame added a comment.
> - Does that affect other platforms such as Windows in any way? I.e., does
KAuth exist on Windows?
KAuth had backends for OSX and Windows. Whether they are working or just
stubs however, I don't know.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://ph
Hi Laurent,
whenever you change the xml files or change any unit test
(highlight.js), you need to run `make test`.
Failing tests then need to be investigated. If you can verify that
your changes are correct, then call the following (auto-generated)
script in your build folder:
./autotest/update-re
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
This is a good patch.
My main concerns are:
- please use const for variables that do not change anymore
- please don't use const & for primitive data types (like boo
mart added a comment.
sorry for the noise, it was a local setup problem, it works correctly now
+1 from me
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4851
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/syntax-highlighting%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/83/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Mar 2017 21:36:22 +
Build duration: 7 min 27 sec
CHANGE SET
Revision 9e464caf050cee4c9b5
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/syntax-highlighting%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Mar 2017 21:36:22 +
Build duration: 1 min 43 sec
CHANGE SET
Revision 9e464caf050cee4c9b5ba12d04
Hi,
On Wed, Mar 1, 2017 at 4:16 PM, David Faure wrote:
> On mercredi 1 mars 2017 13:35:47 CET Kevin Funk wrote:
>> On Tuesday, 28 February 2017 21:31:44 CET Michael Pyne wrote:
>> > On Tue, Feb 28, 2017 at 08:38:12PM +0100, Ivan Čukić wrote:
>> > > > [Differential] D4508: Plasma controls based
mart added a comment.
also,
Failed to find shader ":/plasma-framework/shaders/fadingmaterial_core.vert"
Failed to find shader ":/plasma-framework/shaders/fadingmaterial_core.frag"
QOpenGLShader:🔗 Vertex shader(s) failed to link, fragment shader(s) failed to
link.
Vertex link error: INV
mart added a comment.
tried it now on ati proprietary, the icon does have the highlight effect at
the end of the animation but disappear during the animation.
on terminal i have the following error:
shader compilation failed:
"Vertex shader(s) failed to link, fragment shader(s) faile
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:76ca9bc01c6f: Removed some dead code. (authored by vpilo).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4801?vs=11835&id=12031
REVISION DETAIL
https://ph
graesslin added subscribers: davidedmundson, graesslin.
graesslin added a comment.
I really like what I see here!
Just a thought: what happens if the file is not owned by root, but e.g. by
www-data? If I understand the code correctly it might change to be owned by
root due to the usage o
davidedmundson added a dependent revision: D4851: Implement FadingMaterial
frag/vert shaders on core profile.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4848
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: da
davidedmundson added a dependency: D4848: Split frag and vert code of
FadingNode into separate files.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4851
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmun
On mercredi 1 mars 2017 13:35:47 CET Kevin Funk wrote:
> On Tuesday, 28 February 2017 21:31:44 CET Michael Pyne wrote:
> > On Tue, Feb 28, 2017 at 08:38:12PM +0100, Ivan Čukić wrote:
> > > > [Differential] D4508: Plasma controls based on QtQuickControls2
> > > > [Commented On]> >
> > > >
> > >
subdiff edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4867
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezha
subdiff created this revision.
subdiff added a project: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
There was already some kind of detection and adjustment if there is not
enough space for the popup availabl
mart added a dependent revision: D4865: [System Tray] Listen to external
collapse.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4866
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, broulik
Cc: pl
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
it will still have no visible effect, but
is possible to read and write the property if
containments make use of it (the
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/255/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Mar 2017 13:34:51 +
Build duration: 9 min 33 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (ro
apol added a comment.
The patch looks good to me, but I'm clueless about this code-base. Let's try
to get some feedback.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D4769
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: xue
apol added a reviewer: Frameworks.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D4769
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: xuetianweng, apol, #frameworks
mart added a comment.
I would push it right after this frameworks release, ok?
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D4508
REVISION DETAIL
https://phabricator.kde.org/D4508
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart,
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This way one can just add a KCM as-is without having to worry about a
potentially diverging translation or icon from Sys
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4857
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, mart
Cc: p
On Tuesday, 28 February 2017 21:31:44 CET Michael Pyne wrote:
> On Tue, Feb 28, 2017 at 08:38:12PM +0100, Ivan Čukić wrote:
> > > [Differential] D4508: Plasma controls based on QtQuickControls2
> > > [Commented On]> >
> > > I personally find that having a "vertical" line in which all the
> > >
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
TEST PLAN
Ran
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4857
AFFECTED FILES
davidedmundson updated this revision to Diff 12000.
davidedmundson added a comment.
Change prefix
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4848?vs=11980&id=12000
REVISION DETAIL
https://phabricator.kde.org/D4848
AFFECTED FILES
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Good catch!
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D4801
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: vpilo, ap
On Tue, Feb 28, 2017 at 08:38:12PM +0100, Ivan Čukić wrote:
> > [Differential] D4508: Plasma controls based on QtQuickControls2
> > [Commented On]
> >
> > I personally find that having a "vertical" line in which all the subjects
> > of the differential emails start makes it much easier to read.
mart added a comment.
agree on plasma-framework, in general, looks way cleaner :)
INLINE COMMENTS
> broulik wrote in shaders.qrc:2
> plasma-framework?
+1
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4848
EMAIL PREFERENCES
https://phabricato
davidedmundson added a comment.
There is another solution that would work without any changes to
KNotification.
DBus has a solution to buffer messages and wait for a name to become
available, it happens in DBus activation. If plasmashell was DBus activated on
org.freedesktop.Notificatio
martinkostolny updated this revision to Diff 11991.
martinkostolny added a comment.
I once again updated the diff - I've only renamed 2 variables to better
reflect what they mean:
readAction -> saveAction (I copied that one from tutorial page and forgot to
rename)
dataToWrite -> dataToSav
broulik added a comment.
+1
INLINE COMMENTS
> fadingnode.cpp:57
> {
> -return "varying highp vec2 v_coord;"
> -"uniform sampler2D u_src;"
> -"uniform sampler2D u_target;"
> -"uniform highp float u_transitionProgress;"
> -"uniform lowp float qt_Opacity;"
> -"void main(
martinkostolny updated this revision to Diff 11990.
martinkostolny added a comment.
I missed this one - thanks, Wladimir. Fixed.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4847?vs=11974&id=11990
REVISION DETAIL
https://phabricator.kde.org/D4847
A
palant added inline comments.
INLINE COMMENTS
> org.kde.ktexteditor.katetextbuffer.actions:8
> +Name=Save Document
> +Description=Root privileges are needed save this document
> +Policy=auth_admin
You probably meant to write "**to** save this document"
REPOSITORY
R39 KTextEditor
REVISION DET
40 matches
Mail list logo
