> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote:
> > Ship It!
>
> Matthieu Gallien wrote:
> KFileMetaData being in use by itself, IMHO Baloo problematics should not
> block this correction.
>
> Matthieu Gallien wrote:
> I almost forgot to ask an automatic test for your fix. Plea
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130013/
---
(Updated March 17, 2017, 8:23 a.m.)
Status
--
This change has been m
sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
otherwise it's fairly inobvious why drkonqi doesn't kick in
REPOSITORY
R285 KCrash
BRANCH
master
REVISION DETAIL
https://phabricator.
sitter added a reviewer: dfaure.
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D5079
To: sitter, dfaure
Cc: #frameworks
apol created this revision.
Restricted Application added projects: Frameworks, Build System.
REVISION SUMMARY
Introduces a function that allows to generate plugins.qmltypes files for our
qml plugins using qmlplugindump much like Qt does.
TEST PLAN
Introduced it locally on Purpose and it wor
cfeck added a reviewer: ossi.
REPOSITORY
R291 KPty
REVISION DETAIL
https://phabricator.kde.org/D4975
To: Lekensteyn, #konsole, hindenburg, ossi
Cc: #frameworks
apol created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5088
AFFECTED FILES
CMakeLists.txt
src/
apol updated this revision to Diff 12570.
apol added a comment.
Some adaptions so it works for Plasma Framework too
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5087?vs=12565&id=12570
BRANCH
master
REVISION DETAIL
https://phabricator.kde
rjvbb created this revision.
rjvbb added projects: Build System, Frameworks.
REVISION SUMMARY
KDECompilerSettings.cmake and KDEFrameworksCompilerSettings.cmake fail to
consider the fact that cmake considers Apple's clang compiler to be different
(differences that exist but are largely irreleva
ossi added a comment.
please verify that this is in fact a kernel bug (include ml references), not
something that should be expected for some weird reasons (compare the solaris
path).
if this is a bug, does it actually affect released versions which are not
being "upgraded away" on short n
Lekensteyn added a comment.
In https://phabricator.kde.org/D4975#95727, @ossi wrote:
> please verify that this is in fact a kernel bug (include ml references),
not something that should be expected for some weird reasons (compare the
solaris path).
I suspect it is a kernel bug, b
apol added a comment.
Maybe it would make sense to use MATCHES? are there any other *Clang*?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5089
To: rjvbb, #build_system, #frameworks
Cc: apol, kde-mac, #frameworks, #build_system
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/475/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 17 Mar 2017 17:57:41 +
Build duration: 1 min 20 sec
CHANGE SET
No changes
rjvbb added a comment.
In https://phabricator.kde.org/D5089#95732, @apol wrote:
> Maybe it would make sense to use MATCHES? are there any other *Clang*?
That was my first idea, use `MATCHES "*Clang"`, but then I realised I have no
idea if there are other SomethingClang. Searching
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/476/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 17 Mar 2017 18:10:12 +
Build duration: 57 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root)
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/476/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 17 Mar 2017 18:10:12 +
Build duration: 57 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root)
kfunk added a comment.
+1 to apol's recommendation. `... MATCHES "Clang"` is the expression everyone
uses.
Even in cmake.git:
Modules/CMakeDetermineCCompiler.cmake
138: if(CMAKE_C_COMPILER_ID MATCHES "GNU" OR CMAKE_C_COMPILER_ID MATCHES
"Clang")
Also see:
http://stackov
kfunk requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5089
To: rjvbb, #build_system, #frameworks, kfunk
Cc: kfunk, apol, kde-mac, #frameworks, #build_system
ossi added a comment.
first try googling it; maybe there is even a response on stackoverflow (as so
often happens).
then try posting it yourself to stackoverflow.
dunno whether such questions are welcome on the linux-kernel list, but if
not, there might be other lists where it would fit.
Lekensteyn added a comment.
In https://phabricator.kde.org/D4975#95754, @ossi wrote:
> first try googling it; maybe there is even a response on stackoverflow (as
so often happens).
Was one of the first things to try, that only pointed to an issue in Emacs
and another that clarifi
ossi added a comment.
yeah, but without knowing the root cause, your fix may be just wrong, or at
least the comment/commit message may be misleading.
also,
https://community.kde.org/Policies/Commit_Policy#Don.27t_commit_code_you_don.27t_understand
REPOSITORY
R291 KPty
REVISION DETAIL
ltoscano created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
- more highlight on "applications that use a certain KIO", Konqueror is an
example;
- use kio_http and not Konqueror in the user agent;
ltoscano created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
New user agents, as the available ones are a bit old.
TEST PLAN
Compiles, and the new user agents can be selected for example
in Konque
cfeck created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
If the parent widget is not visible, then immediately show() the message
widget to compute proper size hint. Otherwise, when the widget is lat
24 matches
Mail list logo
