D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added a comment. In https://phabricator.kde.org/D3987#96418, @kossebau wrote: > In https://phabricator.kde.org/D3987#95858, @kfunk wrote: > > > Closing. This Diff refactored the code technically correct. > > > Technically correct, as in: it builds. > But semantically it

D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kossebau added a comment. In https://phabricator.kde.org/D3987#95858, @kfunk wrote: > Closing. This Diff refactored the code technically correct. Technically correct, as in: it builds. But semantically it is incorrect and a regression when it comes to flags, especially as high l

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb updated this revision to Diff 12647. rjvbb added a comment. stripped diff. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5111?vs=12644&id=12647 REVISION DETAIL https://phabricator.kde.org/D5111 AFFECTED FILES kstyle/demo/oxygendemodialog.cpp kstyle/demo/oxygendemodialo

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. Colour scheme chooser proposition split off: https://phabricator.kde.org/D5113 REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, jriddell, anthonyfieroni, zhigalin, hpereiradacosta Cc: kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb updated this revision to Diff 12644. rjvbb edited the summary of this revision. rjvbb added a comment. Updated, not yet split. I've kept the former left-to-right menu action as a "check here" noop action and made the distinction a bit more explicit by adding a menu section (which a

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. Once more. Note how Oxygen renders an icon on the menu button despite me having disabled the icons-in-buttons feature in the settings. Only QtCurve seems to respect this setting for regular buttons (in dialog button boxes) nowadays. F2988220: oxydemo-oxygen-menu.p

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. Screenshots: F2988075: oxydemo-breeze.png F2988076: oxydemo-qtcurve.png F2988077: oxydemo-oxygen.png F2988078: oxydemo-qtcurve-menu.png

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. > - please re-add the screenshot from Review Board. (sorry I was not aware of this review request cause I was not in the list of reviewers, even though official maintainer of oxygen ...) Sorry about that, I thought you'd be a member of the Plasma group. But I had

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

hpereiradacosta added a comment. Hi, Thanks for the set of patches. in general, i am ok with the change but: - please re-add the screenshot from Review Board. (sorry I was not aware of this review request cause I was not in the list of reviewers, even though official maintainer of

D5088: Generate plugins.qmltypes files for the plugins we install

apol added a comment. In https://phabricator.kde.org/D5088#96296, @davidedmundson wrote: > I'm confused. > > If you're generating the qmltypes with the ecm command, why are they in the diff? Good point. We can't generate them at runtime. Here's how they put it in Qt:

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb removed a project: Plasma. rjvbb removed a subscriber: plasma-devel. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, hpereiradacosta, jriddell, anthonyfieroni, zhigalin Cc: kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a continuation/transfer of https://git.reviewboard.kde.org/r/128109/ (which still has a few screenshots) There currently is no "off

D5088: Generate plugins.qmltypes files for the plugins we install

davidedmundson added a comment. I'm confused. If you're generating the qmltypes with the ecm command, why are they in the diff? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5088 To: apol, #plasma, #frameworks Cc: davidedmundson, hein, plas

D5088: Generate plugins.qmltypes files for the plugins we install

hein added a comment. Might be nice to do for p-w as well (libtaskmanager QML plugin). REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5088 To: apol, #plasma, #frameworks Cc: hein, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D5079: debug when disabling kcrash due to env vars

This revision was automatically updated to reflect the committed changes. Closed by commit R285:c916d7b8f3a2: debug when disabling kcrash due to env vars (authored by sitter). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5079?vs=12553&id=12631 REVISION DETAI

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 474 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/474/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Mar 2017 06:58:58 + Build duration: 3 min 2 sec CHANGE SET Revision b6b1c0a6aac2c176491ff125e0062fb557476590 by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 478 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/478/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Mar 2017 06:58:58 + Build duration: 3 min 6 sec CHANGE SET Revision b6b1c0a6aac2c176491ff125e0062fb55747