dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Feel like implementing it for Linux, too? ;-)
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5138
To: tcberner, adridg, arrowdodger, rakuco, dfaure
C
sitter added inline comments.
INLINE COMMENTS
> KDECMakeSettings.cmake:74
> # - ``APPLE_SUPPRESS_X11_WARNING`` option since 5.14.0
>
>
> #=
Needs documentation for the l10n awesomeness.
> KDECMakeSettings.cmake:280
arrowdodger accepted this revision.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5138
To: tcberner, adridg, arrowdodger, rakuco, dfaure
Cc: #frameworks
aacid added a comment.
> Kinit if built with X11 is still requiring the DISPLAY variable all over
the place. The only solution is to run an X server, even if it is not the X
platform As we do on Plasma/Wayland
I don't know what you mean by "only solution" because with this change things
adridg added a comment.
Might want to add a comment about "this is the actual inode creation time;
support depends on the underlying filesystem (e.g. UFS and ZFS have this
information, NFS doesn't)", and change the comment about buff.st_ctime and KDE
2.0.
In addition, please insert the
dfaure added a comment.
The comment about ctime is still true ;-)
For Linux support, I suppose https://codereview.qt-project.org/167049 has
what we need.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5138
To: tcberner, arrowdodger, rakuco, dfaure
adridg added a comment.
Further to the Linux bits: while ext4 and btrfs have the necessary fields,
stat(2) doesn't expose them, xstat(2) doesn't exist yet (see LWN from a few
years back), and extracting the info using other tools depends on fun stuff
like knowing what kind of filesystem the
adridg accepted this revision.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5138
To: tcberner, arrowdodger, rakuco, dfaure, adridg
Cc: #frameworks
emmanuelp added a comment.
In https://phabricator.kde.org/D5138#97024, @adridg wrote:
> So, Linux, sort out your *stat(2) interfaces first and we'll get back to
you.
xstat patches have been merged into 4.11
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabric
dfaure added a comment.
Ah yes OK, the extraction on Linux is indeed not done in those Qt patches
either. Nevermind ;)
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5138
To: tcberner, arrowdodger, rakuco, dfaure, adridg
Cc: emmanuelp, #frameworks
apol marked 2 inline comments as done.
apol added a comment.
will send another review with the documentation
INLINE COMMENTS
> sitter wrote in KDECMakeSettings.cmake:302
> I wonder if we shouldn't use `ExternalProject` here. The advantage being that
> cmake would manage the clone and make su
apol updated this revision to Diff 12732.
apol added a comment.
Add documentation
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5143?vs=12711&id=12732
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5143
AFFECTED FILES
kde-m
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
used for opening the handles when the toolbox is open
or potentially other places
TEST PLAN
handles open
REPOSITORY
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/editMode
REVISION DETAIL
https://phabricator.kde.org/D5153
To: mart, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, progwolff, lesliezhai,
mwolff added a comment.
Yes, please reserve it.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5102
To: sars, #kate, #ktexteditor, dhaumann
Cc: mwolff, dhaumann, kwrite-devel, #frameworks
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/383/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 23 Mar 2017 14:23:34 +
Build duration: 2 min 53 sec
CHANGE SET
Re
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:244baaf92864: add a new property in containment, for an
edit mode (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5153?vs=1273
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/381/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 23 Mar 2017 14:23:34 +
Build duration: 12 min
CHANGE SET
Revision 244baaf
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/381/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 23 Mar 2017 14:23:34 +
Build duration: 12 min
CHANGE SET
Revision 244baaf
sitter added a comment.
A couple of things I am not sure about
- defaults to stable translations, I'd say it should default to trunk. e.g.
playground and kdereview don't even have stable
- considering one has to enable this feature in the cmakecache I think it
should be made a dependen
tcberner updated this revision to Diff 12743.
tcberner added a comment.
Use cmake to check for `st_birthime`.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5138?vs=12704&id=12743
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5138
AFFECTED F
tcberner updated this revision to Diff 12744.
tcberner added a comment.
Add `#cmakedefine01 HAVE_ST_BIRTHTIME` to `config-kioslave-file.h.cmake`
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5138?vs=12743&id=12744
BRANCH
master
REVISION DETAIL
https://ph
tcberner updated this revision to Diff 12745.
tcberner added a comment.
Fix typo.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5138?vs=12744&id=12745
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5138
AFFECTED FILES
src/ioslaves/file/CMa
kfunk added inline comments.
INLINE COMMENTS
> config-kioslave-file.h.cmake:13
>
> +/* Defined if st_birthime is defined */
> +#cmakedefine01 HAVE_ST_BIRTHTIME
Note: typo
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5138
To: tcberner, arrowdodger, ra
kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D3987#96434, @kfunk wrote:
> In https://phabricator.kde.org/D3987#96418, @kossebau wrote:
>
> > In https://phabricator.kde.org/D3987#95858, @kfunk
kossebau closed this revision.
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D3987
To: kfunk, #frameworks, dfaure, kossebau
Cc: skelly, kossebau, dfaure, graesslin
hein created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This allows users of IconItem to know the aspect ratio of the
source document, which can be used to size the item or set
applet size
hein added a dependent revision: D5162: Port custom image mode to IconItem..
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5160
To: hein, #plasma, mart, davidedmundson
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,
jensreuterberg
hein added a comment.
That was me being sleepy and trying to be smart and cunning and avoid
busywork :)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5160
To: hein, #plasma, mart, davidedmundson
Cc: drosca, plasma-devel, #frameworks, progwolff,
hein updated this revision to Diff 12755.
hein added a comment.
Always update implicit size.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5160?vs=12752&id=12755
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5160
AFFE
drosca added a comment.
You don't reset the implicitSize anywhere, so if you do setSource(QImage) and
then setSource(QIcon) it will still have the implicitSize of the previously set
QImage.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5160
To:
ltoscano added a comment.
Thanks for checking: with this patch you should not see the error that I
reported in the summary/commit message. Is it the case? If it is, I guess that
the patch can go in.
It's interesting to note that I have the same issue that you reported on one
of my two mach
32 matches
Mail list logo
