D5178: QtCurve/Qt5 : further KF5 adaptation

2017-03-25 Thread René J . V . Bertin
rjvbb created this revision. REVISION SUMMARY This patch introduces several improvements to QtCurve's integration with KF5: - Inherit KStyle instead of QCommonStyle when built with KDE support - recognise at least KF5 systemsettings application and above all KWin5 - use the new method o

D5174: Add support for wl_shell_surface::set_popup and popup_done

2017-03-25 Thread Martin Gräßlin
graesslin added a dependent revision: D5177: Initial support for popup window handling. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5174 To: graesslin, #plasma_on_wayland, #frameworks, #kwin Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

2017-03-25 Thread Albert Astals Cid
aacid added a comment. Are you sure this is needed, they get installed in different prefixes so what's the problem? /usr/lib/kde4/libexec/ksendbugmail /usr/lib/x86_64-linux-gnu/libexec/kf5/ksendbugmail REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5173 To:

D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.

2017-03-25 Thread Ralf Habacker
habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY BUG:377686 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5175 AFFECTED FILES src/ioslaves/http/

D5174: Add support for wl_shell_surface::set_popup and popup_done

2017-03-25 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a subscriber: plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY This extends the client side API to support creating popup ShellSurface windows and the server side API to send out t

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

2017-03-25 Thread Ralf Habacker
habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The executable is now named ksendbugmail5. BUG:374347 REPOSITORY R263 KXmlGui BRANCH 374347 REVISION DETAIL https://phabricato

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

2017-03-25 Thread Elvis Angelaccio
> On March 22, 2017, 10:08 a.m., Elvis Angelaccio wrote: > > src/ioslaves/file/kauth/file.actions, lines 1-5 > > > > > > I don't see the advantage of using a single kauth action. This way you > > are generating on

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

2017-03-25 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/#review102944 --- src/ioslaves/file/file.cpp (line 1423)

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

2017-03-25 Thread René J . V . Bertin
rjvbb updated this revision to Diff 12788. rjvbb added a comment. Rebased on master; also updated the MDI page title to indicate that it has menu previews. In terms of general improvement we might consider adding a command line argument to start with a specific page. CHANGES SINCE LAST

D4847: KAuth integration in document saving

2017-03-25 Thread David Faure
dfaure added a comment. Looks good to me. Just some minor things I noticed. INLINE COMMENTS > katesecuretextbuffer.cpp:26 > +#include > +#include > +#endif where is stdio.h used? > katesecuretextbuffer.cpp:100 > +} > +const qint64 len = 4096; > +char buffer[len];