Jenkins-kde-ci: kxmlrpcclient master stable-kf5-qt5 » Linux,gcc - Build # 491 - Failure!

2017-04-16 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlrpcclient%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/491/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 17 Apr 2017 03:09:43 + Build duration: 1 min 18 sec CHANGE SET No changes

Re: KAuth buildability: new CI architecture

2017-04-16 Thread Ben Cooksley
On Mon, Apr 17, 2017 at 12:48 AM, Martin Gräßlin wrote: > Am 2017-04-16 13:52, schrieb Ben Cooksley: >> >> On Sun, Apr 16, 2017 at 11:09 PM, Harald Sitter wrote: >>> >>> Not particularly related to the issue at hand (which is probably >>> polkitqt having meh

Threadweaver compilation failure: Windows

2017-04-16 Thread Ben Cooksley
Hi all, If someone could take a look at the following build log that would be appreciated: https://paste.kde.org/pzyhxydjw/xxx39x/raw Cheers, Ben

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 519 - Fixed!

2017-04-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/519/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 17 Apr 2017 02:00:38 + Build duration: 29 min CHANGE SET Revision 45bff508278963b4e19da9222e0562a84e590f1d

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 519 - Fixed!

2017-04-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/519/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 17 Apr 2017 02:00:38 + Build duration: 29 min CHANGE SET Revision 45bff508278963b4e19da9222e0562a84e590f1d

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 518 - Unstable!

2017-04-16 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/518/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 17 Apr 2017 02:00:38 + Build duration: 24 min CHANGE SET Revision 45bff508278963b4e19da9222e0562a84e590f1d by

D5394: KAuth integration in document saving - vol. 2

2017-04-16 Thread Fabian Vogt
fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. Thanks! So far I only found two issues (see comments). Apart from that it would be great to see the application name and the target/source file in the polkit dialog, but I

D5456: KDoctools: build on Mac with docbook from homebrew

2017-04-16 Thread Allen Winter
winterz closed this revision. winterz added a comment. committed in https://phabricator.kde.org/R238:5c5bfc2d838993f7d4be1885dff822e3794c529f REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D5456 To: winterz, ltoscano, kfunk Cc: kfunk, #frameworks, #documentation,

D5456: KDoctools: build on Mac with docbook from homebrew

2017-04-16 Thread Luigi Toscano
ltoscano accepted this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D5456 To: winterz, ltoscano, kfunk Cc: kfunk, #frameworks, #documentation, skadinna

D5456: KDoctools: build on Mac with docbook from homebrew

2017-04-16 Thread Allen Winter
winterz updated this revision to Diff 13520. winterz added a comment. I added comments. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5456?vs=13448=13520 REVISION DETAIL https://phabricator.kde.org/D5456 AFFECTED FILES cmake/FindDocBookXML4.cmake

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

2017-04-16 Thread Andreas Sturmlechner
> On April 1, 2017, 7:59 p.m., David Faure wrote: > > Makes sense to me, +1. > > Andreas Sturmlechner wrote: > Thanks, anyone else who wants to +1? > > I've tried to test migration today but it didn't work. May as well have > nothing to do with te patch and be caused by the

D5394: KAuth integration in document saving - vol. 2

2017-04-16 Thread Martin Kostolný
martinkostolny updated this revision to Diff 13517. martinkostolny added a comment. Updated diff based on Fabian's advisory. Thanks, Fabian! I've implemented the first option: checksum -> tempfile1 -> read in privileged action -> checksum -> tempfile2 -> permissions -> rename. It works

Re: KAuth buildability: new CI architecture

2017-04-16 Thread Martin Gräßlin
Am 2017-04-16 13:52, schrieb Ben Cooksley: On Sun, Apr 16, 2017 at 11:09 PM, Harald Sitter wrote: Not particularly related to the issue at hand (which is probably polkitqt having meh cmake files), but relocating stuff in general is sper unreliable and I would absolutely

Re: KAuth buildability: new CI architecture

2017-04-16 Thread Ben Cooksley
On Sun, Apr 16, 2017 at 11:09 PM, Harald Sitter wrote: > Not particularly related to the issue at hand (which is probably > polkitqt having meh cmake files), but relocating stuff in general is > sper unreliable and I would absolutely advise against it as it can > easily screw

Re: KAuth buildability: new CI architecture

2017-04-16 Thread Harald Sitter
Not particularly related to the issue at hand (which is probably polkitqt having meh cmake files), but relocating stuff in general is sper unreliable and I would absolutely advise against it as it can easily screw up test results and builds alike, often in unobvious ways (all it takes is a bit

D5463: Pug/Jade Syntax

2017-04-16 Thread Yunhe Guo
guoyunhe added a comment. In https://phabricator.kde.org/D5463#102409, @dhaumann wrote: > Do you also agree to release this highlighting file under MIT license? Same for the test case you attached? Also, can we use this test case for unit testing? It is okay. I can release the

D5394: KAuth integration in document saving - vol. 2

2017-04-16 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D5394#102605, @dfaure wrote: > Would it help if QSaveFile had an API to set more restrictive permissions on the temp file? No, the fix is simple: Revert

D5394: KAuth integration in document saving - vol. 2

2017-04-16 Thread David Faure
dfaure added a comment. Would it help if QSaveFile had an API to set more restrictive permissions on the temp file? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5394 To: martinkostolny, #ktexteditor, fvogt Cc: elvisangelaccio, aacid, ivan, lbeltrame, fvogt,

D5413: makes KArchive be optional and do not build extractors needing it

2017-04-16 Thread Matthieu Gallien
This revision was automatically updated to reflect the committed changes. Closed by commit R286:599e9b6489fe: makes KArchive be optional and do not build extractors needing it (authored by mgallien). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5413?vs=13496=13507#toc REPOSITORY

Re: Review Request 130084: Add a pair of flags forcing fsync during copy loop

2017-04-16 Thread David Faure
> On April 15, 2017, 8:30 a.m., David Faure wrote: > > But doesn't this make copying much slower in the normal case? (copying onto > > a non-removable harddisk partition). > > > > It sounds to me like this should be > > 1) done internally in kio_file (no Job API for this) > > 2) only when the

D5413: makes KArchive be optional and do not build extractors needing it

2017-04-16 Thread David Faure
dfaure accepted this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D5413 To: mgallien, kfunk, dfaure Cc: kfunk, heikobecker, dfaure, #frameworks