D5674: Solve a visibility conflict for meinproc5

2017-05-02 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R238:86c5dd3baa3c: Solve a visibility conflict for meinproc5 (authored by ltoscano). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5674?vs=14040&id=14093 REVISION DE

D5674: Solve a visibility conflict for meinproc5

2017-05-02 Thread Hannah von Reth
vonreth accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D5674 To: ltoscano, vonreth Cc: #frameworks, #documentation, skadinna, kfunk

D5639: Internal cache for provider data on initialisation

2017-05-02 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 14080. leinir edited the summary of this revision. leinir added a comment. Simplify the logic, and only do the xmlloader caching, not the documents themselves which (as apol points out) should be cached already anyway. Not only that, but that codepath was

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-02 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 14079. leinir marked an inline comment as done. leinir added a comment. Simpler logic, with the global qnam (etc) stored in a locally defined class, so we only have the one global static, and also allowing the qnam access to be more pleasantly locked. REP

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-02 Thread Dan Leinir Turthra Jensen
leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in httpworker.cpp:33 > How about getting a class with these 3 attributes? Looks like we're juggling > here... You know, that sounds like a good plan. Updated diff incoming :) REPOSITORY R304 K

D5656: Adds method to force the reloading of a document

2017-05-02 Thread Pedro Arthur P. R. Duarte
pedroarthurp added a comment. In https://phabricator.kde.org/D5656#106401, @nalvarez wrote: > I'm pretty sure this breaks ABI by adding a new virtual function... If an application was compiled against a previous version of KTextEditor and calls `documentSave()`, when run with a newer KTe

D5605: Allow multiple categories with the same name

2017-05-02 Thread Marco Martin
mart updated this revision to Diff 14070. mart added a comment. - remove empty placeholders REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5605?vs=13843&id=14070 BRANCH arcpatch-D5605 REVISION DETAIL https://phabricator.kde.org/D5605 AFFECTED FILES

Re: KConfigDialogManager and QButtonGroup

2017-05-02 Thread Albert Astals Cid
El dilluns, 1 de maig de 2017, a les 20:31:28 CEST, Martin Koller va escriure: > Hi, > > trying to fix https://bugs.kde.org/show_bug.cgi?id=378930 > > I see that the mboxresource has a configuration dialog which uses > KConfigDialogManager to handle the settings, but it has a QGroupBox widget > h

D5639: Internal cache for provider data on initialisation

2017-05-02 Thread Dan Leinir Turthra Jensen
leinir added a comment. In https://phabricator.kde.org/D5639#105620, @apol wrote: > Won't caching already fix the problem of traffic there? This change adds quite some complexity (all these QMutex make me cringe, these methods should always be called from the same thread anyway...)

Re: KWallet::openWallet and 0-WinId ?

2017-05-02 Thread Martin Gräßlin
Am 2017-05-01 17:33, schrieb Martin Koller: Hi, the Wallet::openWallet() documentation says for the WinId argument: "The window id to associate any dialogs with. You can pass 0 if you don't have a window the password dialog should associate with." However passing 0 gives a runtime warning