ivan accepted this revision.
ivan added a comment.
This revision is now accepted and ready to land.
This is a good point. *
I'll make this lower again when I remove KConfig from KActivities/imports.
*Though, KActivities imports are tier 2 (the KIO dep was removed some time
ago -
bcooksley added a comment.
Unfortunately our Jenkins Jobs aren't configured to apply patches, so there
isn't a way of testing this as such other than through:
1. Some manual handling
2. Committing it and seeing what happens.
REPOSITORY
R238 KDocTools
REVISION DETAIL
ltoscano added a subscriber: bcooksley.
ltoscano added a comment.
@bcooksley , is there a way to test this properly in the new CI (aka: without
me manually applying some patches), to see if I didn't do something weird that
made it work by accident?
REPOSITORY
R238 KDocTools
REVISION
ltoscano updated this revision to Diff 14182.
ltoscano added a comment.
Readd docs
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5725?vs=14181=14182
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5725
AFFECTED FILES
CMakeLists.txt
ltoscano created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REVISION SUMMARY
Apparently setting XML_CATALOG_FILES has no effects on Windows
at least with MSVC (2017). The variable seems
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/524/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 00:39:21 +
Build duration: 1 min 8 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/524/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 00:39:21 +
Build duration: 1 min 8 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kparts%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/532/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 00:36:45 +
Build duration: 1 min 23 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kparts%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/532/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 00:36:45 +
Build duration: 1 min 23 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/523/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 00:33:02 +
Build duration: 4 min 22 sec
CHANGE SET
No changes
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kparts%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/531/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 00:33:02 +
Build duration: 1 min 46 sec
CHANGE SET
No changes
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/546/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 00:25:05 +
Build duration: 5 min 41 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/546/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 00:25:05 +
Build duration: 5 min 41 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/545/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 00:16:15 +
Build duration: 7 min 55 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/294/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 23:29:31 +
Build duration: 13 min
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/294/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 23:29:31 +
Build duration: 13 min
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/540/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 23:27:26 +
Build duration: 1 min 40 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/540/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 23:27:26 +
Build duration: 1 min 40 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/599/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 23:27:26 +
Build duration: 2 min 13 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/599/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 23:27:26 +
Build duration: 2 min 13 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kconfigwidgets%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/214/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:58:38 +
Build duration: 4 min 34 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kconfigwidgets%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/214/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:58:38 +
Build duration: 4 min 34 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/232/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:48:22 +
Build duration: 1 min 45 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/232/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:48:22 +
Build duration: 1 min 45 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/263/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:24:59 +
Build duration: 5 min 22 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root)
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/263/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:24:59 +
Build duration: 5 min 22 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root)
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/598/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:21:42 +
Build duration: 2 min 31 sec
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/219/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:17:49 +
Build duration: 3 min 56 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/219/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:17:49 +
Build duration: 3 min 56 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/539/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:21:42 +
Build duration: 45 sec
CHANGE SET
Revision b90f4d762af72ac7bd8c375041d6404499a4258e by
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kconfigwidgets%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/213/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:13:05 +
Build duration: 2 min 21 sec
CHANGE SET
No changes
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/293/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:13:04 +
Build duration: 35 sec
CHANGE SET
Revision
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/544/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:03:40 +
Build duration: 2 min 23 sec
CHANGE SET
Revision
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/231/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:03:40 +
Build duration: 36 sec
CHANGE SET
Revision
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/167/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 22:01:37 +
Build duration: 3 min 11 sec
CHANGE SET
Revision
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/409/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 05 May 2017 21:58:45 +
Build duration: 38 sec
CHANGE SET
Revision
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/409/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 05 May 2017 21:58:45 +
Build duration: 44 sec
CHANGE SET
Revision
In data sabato 6 maggio 2017 00:01:09 CEST, Luca Beltrame ha scritto:
> I'll try rebuilding a few more times (the result is unreliable) and I'll
> report back.
False alarm: it wasn't the problem at all. I can't see what could be wrong
from the generated files.
--
Luca Beltrame - KDE Forums
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kded%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/262/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 21:40:55 +
Build duration: 28 sec
CHANGE SET
Revision 760580a82047149c68c6bc8bceedbc5d685fd816 by
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/218/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 05 May 2017 21:38:37 +
Build duration: 4 min 24 sec
CHANGE SET
Revision
In data venerdì 5 maggio 2017 22:47:45 CEST, Luca Beltrame ha scritto:
> From a quick discussion on #opensuse-kde, it may have to do with
> QT_NO_CAST_FROM_ASCII and QT_NO_CAST_TO_ASCII (which means that we have
My initial test suggests that indeed we have a problem somehow with strings-
In data venerdì 5 maggio 2017 19:42:45 CEST, Stephen Kelly ha scritto:
> Is KI18n the only one with the problem?
At the moment, yes. All the other failures I saw were just a case of missing
sip files.
> I can't reproduce it on my Ubuntu. Can someone dig in on opensuse to
> reduce the code to
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:85699c8d2f54: reload icon when usesPlasmaTheme changes
(authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5721?vs=14172=14176
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/useplasmatheme
REVISION DETAIL
https://phabricator.kde.org/D5721
To: mart, #plasma, sebas
Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren,
Am 2017-05-05 18:37, schrieb Detlef Eppers:
File indexing tools encounter all different types of files, both of
trusted and untrusted origin, and last November it was demonstrated by
Chris Evans how this can potentially be exploited*. In order to
provide a means for mitigation, I have written a
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
when usesPlasmaTheme gets changed, make sure to
invalidate the svg icon if there, to reload the
icon from the proper
On 05/05/2017 11:21 AM, David Faure wrote:
> On samedi 15 avril 2017 16:17:43 CEST Luca Beltrame wrote:
>> In data sabato 15 aprile 2017 16:10:24 CEST, Luca Beltrame ha scritto:
>>> https://build.opensuse.org/build/
>>> home:luca_b:branches:KDE:Unstable:Frameworks/openSUSE_Factory/x86_64/ki18n
>>>
File indexing tools encounter all different types of files, both of
trusted and untrusted origin, and last November it was demonstrated by
Chris Evans how this can potentially be exploited*. In order to provide
a means for mitigation, I have written a Firejail profile** for Baloo
recently
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:93fb3260679b: Validate surface is valid when sending
TextInput leave event (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Thanks for adding the test!
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5712
To: davidedmundson, #plasma, graesslin
Cc: apol,
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:28a1d8b41162: Improve apidox (authored by
elvisangelaccio).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5718?vs=14156=14163
REVISION DETAIL
apol added a comment.
In https://phabricator.kde.org/D4906#107096, @adridg wrote:
> The default configuration of kactivities has option
KACTIVITIES_LIBRARY_ONLY set to OFF, which means src/imports is added as
subdirectory, and it uses KIO and other tier-3 libraries. So the default build
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:a5d279198fee: Fix autotests on the FreeBSD CI. (authored
by adridg).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5717?vs=14155=14160
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:def270105286: Fix quoting of preprocessor-definition.
(authored by adridg).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5713?vs=14149=14159
REVISION DETAIL
adridg added a comment.
The default configuration of kactivities has option KACTIVITIES_LIBRARY_ONLY
set to OFF, which means src/imports is added as subdirectory, and it uses KIO
and other tier-3 libraries. So the default build of kactivities is still
tier-3. And as long as kactivities is
kossebau added a comment.
BTW, the `` and `\ref x` seems not to work (only reused that for
consistency), will do a separate patch later which follows instructions from
http://doxygen.10944.n7.nabble.com/Creating-links-in-and-between-Markdown-files-pages-td6689.html
REPOSITORY
R249 KI18n
mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.
Thank you!
REPOSITORY
R289 KNotifications
BRANCH
improve-apidox (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D5718
To: elvisangelaccio, mck182
Cc: #frameworks
kossebau added a comment.
@ilic Thanks for the comments, agreed. Actually the initial text had some
"really?" across it, as I was surprised about the findings stated in there and
wanted (your) confirmation.
So made this info bit a subsection of the "Writing Messages" part, and
changed it
kossebau updated this revision to Diff 14158.
kossebau added a comment.
rework text follwing feedback
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5455?vs=13447=14158
BRANCH
addNoteAboutGettextLocaleIssuse
REVISION DETAIL
davidedmundson updated this revision to Diff 14157.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Also validate the enterEvent, this makes it symetric to pointer enter/leave
events that have the same check.
I've also
apol added a comment.
I've been there, apparently it's not the right fix, didn't investigate
further. :/
https://phabricator.kde.org/D4906
REPOSITORY
R159 KActivities Statistics
REVISION DETAIL
https://phabricator.kde.org/D5715
To: adridg, ivan
Cc: apol, #frameworks
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Stress the fact that a misconfigured appname/component name
will result in notifications not working.
While at it, fix a bunch
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5717
To: adridg, bcooksley, graesslin, davidedmundson
Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren,
adridg added a reviewer: graesslin.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5717
To: adridg, bcooksley, graesslin
Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas
adridg created this revision.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REVISION SUMMARY
Include explicitly, for EPROTO.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
adridg added reviewers: winterz, bcooksley, vonreth.
REPOSITORY
R264 KApiDox
REVISION DETAIL
https://phabricator.kde.org/D5716
To: adridg, winterz, bcooksley, vonreth
Cc: #frameworks, #documentation, skadinna
adridg created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REVISION SUMMARY
In the presence of spaces in directory names, things end up
double-escaped by using TO_NATIVE_PATH and then the
bcooksley accepted this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.
From a theoretical perspective this looks fine to me.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5713
To: adridg, dfaure, bcooksley
Cc:
> On May 1, 2017, 2:05 p.m., Lamarque Souza wrote:
> > ping
>
> David Faure wrote:
> ping? did you see my comment? ;)
Yes, I did see your comment. The "ping" was to this review's author to follow
your instructions :-) I am one of the Plasma NM developers and there is review
for Plasma NM
adridg created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Since activities-stats depends on kactivities, which is tier-3
itself, -stats must be tier-3 as well.
REPOSITORY
R159 KActivities
adridg created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
If the LIBEXECDIR contains spaces (as it does specifically on the CI
systems) then this needs one extra layer of quoting to protect it from
On mardi 18 avril 2017 18:20:14 CEST Hartmut Goebel wrote:
> KStandarddirsTest::testFindResource() '!data.isEmpty()' returned
Check the code: this isn't about foorc, but about
share/ + "dbus-1/interfaces/kf5_org.kde.JobView.xml"
In other words, it requires KJobWidgets installed into a prefix
On samedi 15 avril 2017 16:17:43 CEST Luca Beltrame wrote:
> In data sabato 15 aprile 2017 16:10:24 CEST, Luca Beltrame ha scritto:
> > https://build.opensuse.org/build/
> > home:luca_b:branches:KDE:Unstable:Frameworks/openSUSE_Factory/x86_64/ki18n
> > /
> > _log
>
> As these build logs are only
> On May 1, 2017, 2:05 p.m., Lamarque Souza wrote:
> > ping
ping? did you see my comment? ;)
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128958/#review103166
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130084/#review103187
---
src/ioslaves/file/file_unix.cpp (line 89)
apol added a comment.
+1
FWIW, this fixes my initial issue.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5712
To: davidedmundson, #plasma, graesslin
Cc: apol, graesslin, plasma-devel, #frameworks, spstarr, progwolff, Zren,
lesliezhai, ali-mohamed,
leinir updated this revision to Diff 14146.
leinir marked 2 inline comments as done.
leinir added a comment.
Unpointerify the internals, as agreed
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5638?vs=14079=14146
REVISION DETAIL
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130084/#review103186
---
src/ioslaves/file/file_unix.cpp (line 112)
78 matches
Mail list logo
