D4711: Ungrab mouse on menu close

2017-05-13 Thread Anthony Fieroni
anthonyfieroni abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 To: anthonyfieroni, #plasma, mart, broulik, davidedmundson Cc: mvourlakos, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, je

D5828: fix plasma-frameworks build without kwayland

2017-05-13 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > dialog.cpp:1141 > KWindowSystem::setState(winId(), NET::SkipTaskbar | > NET::SkipPager); > d->setupWaylandIntegration(); > d->updateVisibility(true); Maybe we should only wrap this one function call? REPOSITOR

Re: Section of man pages shipped with Frameworks

2017-05-13 Thread Luigi Toscano
Luigi Toscano ha scritto: > Aleix Pol ha scritto: >> On Sat, Apr 8, 2017 at 9:31 PM, Luigi Toscano >> wrote: >>> Hi all, >>> I was checking the manpages shipped with Frameworks. >>> I know that this is not the most existing topics, but: can I move the man >>> pages currently in section 8 (System

D5747: add pid to plasma window management protocol

2017-05-13 Thread Martin Flöser
graesslin reopened this revision. graesslin added a comment. This revision is now accepted and ready to land. Can reproduce the failing test locally. Please fix ASAP! Broken tests is not acceptable in KWayland. This change has been on review so long, I find it quite disappointing that it was

D5747: add pid to plasma window management protocol

2017-05-13 Thread Eike Hein
hein added a comment. testPid is failing: https://build.kde.org/job/kwayland%20master%20kf5-qt5/204/PLATFORM=Linux,compiler=gcc/testReport/junit/(root)/TestSuite/kwayland_testPlasmaWindowModel/ REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma

D5747: add pid to plasma window management protocol

2017-05-13 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit R127:0b4d8a7fc1df: add pid to plasma window management protocol (authored by sebas). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5747?vs=14442&id=14463 REVISION DET

D5828: fix plasma-frameworks build without kwayland

2017-05-13 Thread Allen Winter
winterz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY fixes the compile errors in plasmaquick/dialog.cpp if you don't have kwayland TEST PLAN compile it REPOSITORY R242 Plasma Framework (Li

D5774: speed up detail treeview display by avoiding too many column resizes

2017-05-13 Thread Martin Koller
This revision was automatically updated to reflect the committed changes. Closed by commit R241:10e53ca3b2a7: speed up detail treeview display by avoiding too many column resizes (authored by mkoller). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5774?vs=14300&id=14461#toc REPOSITORY

D5774: speed up detail treeview display by avoiding too many column resizes

2017-05-13 Thread Martin Koller
mkoller added inline comments. INLINE COMMENTS > dfaure wrote in kdiroperatordetailview.cpp:156 > Is there any risk that this connect is done multiple times? To be honest, I don't know. I'll add Qt::UniqueConnection just to be safe REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kd

D5775: Don't include the pid in the dbus path when on flatpak

2017-05-13 Thread David Faure
dfaure added a comment. d_ed: I use the DBus name in multi mode to talk to running processes ;-) (for introspection, debugging, automation, etc.) REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D5775 To: apol, #frameworks, jgrulich Cc: dfaure, davidedmundso

D5774: speed up detail treeview display by avoiding too many column resizes

2017-05-13 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I don't really know this code, but I definitely welcome such very needed speed improvements. INLINE COMMENTS > kdiroperatordetailview.cpp:156 > { > -QTimer::singleShot(300, this, SLOT

Re: i18n and KFileMetaData

2017-05-13 Thread David Faure
On lundi 8 mai 2017 13:09:03 CEST Luigi Toscano wrote: > Matthieu Gallien ha scritto: > > Hello, > > > > Currently KFileMetaData is a tier 2 framework even when you remove all > > optional dependencies on other frameworks due to a dependency on ki18n. > > > > I would like to know if people think

Re: KDirWatch issue

2017-05-13 Thread David Faure
On lundi 8 mai 2017 17:51:06 CEST Albert Astals Cid wrote: > El dilluns, 8 de maig de 2017, a les 17:32:35 CEST, David Faure va escriure: > > On lundi 8 mai 2017 16:14:47 CEST Albert Astals Cid wrote: > > > > I think the point is that we *want* the notification to happen after > > > > restartDirSca