Re: Unusual CMake installation error

2017-05-16 Thread Albert Astals Cid
El dimarts, 16 de maig de 2017, a les 22:42:52 CEST, Ben Cooksley va escriure: > Hi all, > > On the Windows CI i'm currently seeing a weird installation error > message with kdelibs4support: > > -- Installing: C:/JenkinsWS/workspace/Frameworks kdelibs4support > kf5-qt5 WindowsQt5.7/install-divert

D5867: Add or improve "Generated. Don't edit" messages and make consistent

2017-05-16 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R240:b58820c4af64: Add or improve "Generated. Don't edit" messages and make consistent (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D5889: Keep QIcon::fromTheme in main thread

2017-05-16 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:92bf5a9828d1: Keep QIcon::fromTheme in main thread (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5889?vs=14602&id=14611 REVISION DE

D5889: Keep QIcon::fromTheme in main thread

2017-05-16 Thread Martin Flöser
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Eh what? That is not thread save?!? Oh sh*** I didn't expect that. Good catch and a nice solution. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.k

Re: Compilation failure on Windows: kpeople

2017-05-16 Thread Ralf Habacker
Hi > When someone gets the chance, could they please look into the build > log at > https://build-sandbox.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsQt5.7/4/console > to see why this Framework isn't building on Windows? from my recent experience with building kmymoney on Windows this may

D3883: Generate gperf output at build time

2017-05-16 Thread Ben Cooksley
bcooksley added a comment. It's located at https://build-sandbox.kde.org/ We're currently in a transitional period between the two systems - the new one has already been announced on various mailing lists including kde-core-devel. REPOSITORY R270 KCodecs REVISION DETAIL https://phabri

D5890: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning.

2017-05-16 Thread Gleb Popov
arrowdodger created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning. TEST PLAN Successfully compiled with MSVC. REPOSITORY R313 KHtml BRA

D3883: Generate gperf output at build time

2017-05-16 Thread Pino Toscano
pino added a comment. In https://phabricator.kde.org/D3883#110156, @bcooksley wrote: > Please remember that adding *any* build dependency *requires* notification to Sysadmin, which was not done in this case. Please see https://community.kde.org/Policies/Dependency_Changes_and_CI

D3883: Generate gperf output at build time

2017-05-16 Thread Ben Cooksley
bcooksley added a comment. Please remember that adding *any* build dependency *requires* notification to Sysadmin, which was not done in this case. Please see https://community.kde.org/Policies/Dependency_Changes_and_CI This broke the FreeBSD and Windows builds of both of those on the ne

D3883: Generate gperf output at build time

2017-05-16 Thread Pino Toscano
pino added a comment. In https://phabricator.kde.org/D3883#109995, @bcooksley wrote: > Did you intend to make GPerf a hard dependency of KCodecs? Yes, that's the whole point of https://phabricator.kde.org/D3830 and this one... Also, now even khtml has gperf has required build de

Compilation failure on Windows: kpeople

2017-05-16 Thread Ben Cooksley
Hi all, When someone gets the chance, could they please look into the build log at https://build-sandbox.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsQt5.7/4/console to see why this Framework isn't building on Windows? Thanks, Ben

D5889: Keep QIcon::fromTheme in main thread

2017-05-16 Thread David Edmundson
davidedmundson updated this revision to Diff 14602. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. simplify a line REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5889?vs=14601&id=14602 BRAN

D5889: Keep QIcon::fromTheme in main thread

2017-05-16 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY QIcon::fromTheme is not thread safe, we can't have it done in the future watcher. We can solve this

D5887: Remove pid changedSignal in Client::PlasmaWindow

2017-05-16 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:c4caf02a9d4b: Remove pid changedSignal in Client::PlasmaWindow (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5887?vs=14597&id=14599

D5887: Remove pid changedSignal in Client::PlasmaWindow

2017-05-16 Thread Martin Flöser
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R127 KWayland BRANCH asdfasdf REVISION DETAIL https://phabricator.kde.org/D5887 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, #framewo

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-16 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D5872#109962, @hein wrote: > I'm fine with no change signal, but heads-up that libtaskmanager has code connecting to it, so if you remove it from kwayland please also adapt plasma-workspace or the build breaks. I highly su

D5887: Remove pid changedSignal in Client::PlasmaWindow

2017-05-16 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Verified it it send before the initial_state and adjust tests and docs accordingly TEST PLAN All un

Unusual CMake installation error

2017-05-16 Thread Ben Cooksley
Hi all, On the Windows CI i'm currently seeing a weird installation error message with kdelibs4support: -- Installing: C:/JenkinsWS/workspace/Frameworks kdelibs4support kf5-qt5 WindowsQt5.7/install-divert/JenkinsWS/workspace/Frameworks kdelibs4support kf5-qt5 WindowsQt5.7/install-prefix/bin/data/

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-16 Thread Eike Hein
hein added a comment. No, I don't. libtaskmanager doesn't use PlasmaWindowModel, it uses PlasmaWindow. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5872 To: sebas, #plasma, hein, davidedmundson Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, Zre

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-16 Thread David Edmundson
davidedmundson added a comment. No you don't. You connect via QAIM;: dataChanged which is still there. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5872 To: sebas, #plasma, hein, davidedmundson Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, Zr

D3883: Generate gperf output at build time

2017-05-16 Thread Ben Cooksley
bcooksley added a comment. Did you intend to make GPerf a hard dependency of KCodecs? https://build-sandbox.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20FreeBSDQt5.7/6/console REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D3883 To: pino, #frameworks Cc: bcooksley

D5757: add requestToggleKeepAbove/below

2017-05-16 Thread Marco Martin
mart marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D5757: add requestToggleKeepAbove/below

2017-05-16 Thread Marco Martin
mart updated this revision to Diff 14581. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - fix comment REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14320&id=14581 BRANCH arcpatch-D5757 R

D5757: add requestToggleKeepAbove/below

2017-05-16 Thread Marco Martin
mart updated this revision to Diff 14582. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - fix comment REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14581&id=14582 BRANCH arcpatch-D5757 R

D5775: Don't include the pid in the dbus path when on flatpak

2017-05-16 Thread Jan Grulich
jgrulich added a comment. I think this still doesn't solve the general problem we have with sandboxed applications as you cannot still allow this dbus service in app manifest. You can use "org.kde.AppName.*" , but then the dbus name would need to be in form of "org.kde.AppName.appPid" or "or