Re: KFileMetaData and API level requirement

On Wed, May 17, 2017 at 9:57 PM, Matthieu Gallien wrote: > Hello, > > As a follow up of a discussion on android list, I would like to gather some > comments or point of views about the following dilemma. > Currently, the mandatory parts of KFileMetaData compile for

KFileMetaData and API level requirement

Hello, As a follow up of a discussion on android list, I would like to gather some comments or point of views about the following dilemma. Currently, the mandatory parts of KFileMetaData compile for Android using API level 21 (Android 5.0). The class UserMetaData is relying on extended

D5775: Don't include the pid in the dbus path when on flatpak

apol updated this revision to Diff 14642. apol added a comment. Fix reverse domain notation REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5775?vs=14541=14642 BRANCH arcpatch-D5775 REVISION DETAIL https://phabricator.kde.org/D5775 AFFECTED FILES

D5902: Expand KNewStuff documentation

apol added inline comments. INLINE COMMENTS > README.md:30 > + > +find_package(KF5NewStuffCore NO_MODULE) # for the KNewStuffCore library > only > +find_package(KF5NewStuff NO_MODULE) # for the KNewStuff UI library, will > pull in KNewStuffCore for you I'd say that it looks better to

Re: i18n and KFileMetaData

Le 13 mai 2017 14:18, "David Faure" a écrit : On lundi 8 mai 2017 13:09:03 CEST Luigi Toscano wrote: > Matthieu Gallien ha scritto: > > Hello, > > > > Currently KFileMetaData is a tier 2 framework even when you remove all > > optional dependencies on other frameworks due to a

D5872: pidChanged also signals dataChanged in WindowModel

sebas abandoned this revision. sebas added a comment. Okay, thanks David. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5872 To: sebas, #plasma, hein, davidedmundson Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

rjvbb set the repository for this revision to R240 Extra CMake Modules. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5865 To: rjvbb, #frameworks, #build_system, cgilles Cc: kfunk

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

rjvbb updated this revision to Diff 14635. rjvbb marked an inline comment as done. rjvbb added a comment. This update hopefully introduces the appropriate check for MSVC 2015 update 3 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5865?vs=14548=14635 REVISION DETAIL

D5902: Expand KNewStuff documentation

leinir created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add mention of KNewStuffCore and KNewStuffQuick to the base documentation, and expand the API documentation to mention some of the new

D5902: Expand KNewStuff documentation

leinir added a reviewer: KNewStuff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5902 To: leinir, #knewstuff Cc: #frameworks

D5872: pidChanged also signals dataChanged in WindowModel

davidedmundson added a comment. I merged a different thing that Martin was happy wtih. This is closable. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5872 To: sebas, #plasma, hein, davidedmundson Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks,

D5900: use transientparent directly

This revision was automatically updated to reflect the committed changes. Closed by commit R263:4690808e65f1: use transientparent directly (authored by mart). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5900?vs=14630=14631 REVISION DETAIL

D5900: use transientparent directly

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Tested, works (neither kontact nor okular crash with this change). REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D5900 To: mart, lbeltrame

D5900: use transientparent directly

lbeltrame added a reviewer: lbeltrame. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5900 To: mart, lbeltrame Cc: lbeltrame, #frameworks

D5900: use transientparent directly

lbeltrame added a comment. I'll test this and see how it goes. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5900 To: mart Cc: lbeltrame, #frameworks

D5806: When building menu hyerarchies, parent menus to their containers

cfeck added a comment. Konsole could also be affected, see https://bugs.kde.org/show_bug.cgi?id=379795 Timing indicate all reporters use newest frameworks. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5806 To: mart, #plasma, #plasma_on_wayland, #frameworks,

D5806: When building menu hyerarchies, parent menus to their containers

mart added a comment. possible fix https://phabricator.kde.org/D5900 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5806 To: mart, #plasma, #plasma_on_wayland, #frameworks, davidedmundson Cc: lbeltrame, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr,

D5900: use transientparent directly

mart updated this revision to Diff 14630. mart added a comment. call windid only once REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5900?vs=14629=14630 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5900 AFFECTED FILES

D5900: use transientparent directly

mart created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY don't parent directly as we don't want unwanted deletions. ensure we have a menu, not parented yet, the container exists, both the menu and

Re: Unusual CMake installation error

On Wed, May 17, 2017 at 10:22 AM, Albert Astals Cid wrote: > El dimarts, 16 de maig de 2017, a les 22:42:52 CEST, Ben Cooksley va escriure: >> Hi all, >> >> On the Windows CI i'm currently seeing a weird installation error >> message with kdelibs4support: >> >> -- Installing:

D5806: When building menu hyerarchies, parent menus to their containers

lbeltrame added a comment. Unfortunately this change causes crashes in KPart-using applications that do stuff with their QActions with Qt 5.9. okular and kontact are affected, at least. This is a typical backtrace (got this from Eike, but I have the same): #0 QAction::setEnabled