D5966: Fix race-condition in KRandom-seeding.

2017-05-25 Thread Michael Pyne
mpyne added a comment. Would it be better to use `QThreadStorage` (to record if the thread has been seeded) instead of a `QSet`? It would allow us to more easily adopt C++11's `thread_local` once we remove support for older compilers. I also looked into whether we could adopt the

D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)

2017-05-25 Thread René J . V . Bertin
rjvbb edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5972 To: rjvbb, #build_system, #frameworks Cc: #frameworks, #build_system

D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)

2017-05-25 Thread René J . V . Bertin
rjvbb edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5972 To: rjvbb, #build_system, #frameworks Cc: #frameworks, #build_system

Re: Review Request 130139: Set QT_NO_EXCEPTIONS for *.mm files

2017-05-25 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130139/#review103244 --- See also https://phabricator.kde.org/D5972 - René J.V.

D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)

2017-05-25 Thread René J . V . Bertin
rjvbb created this revision. rjvbb added a project: Build System. Restricted Application added a project: Frameworks. REVISION SUMMARY Qt currently fails to set `QT_NO_EXCEPTIONS` when building with Clang (and thus presumably with ICC too as it apparently masquerades as Clang). This patch

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

2017-05-25 Thread René J . V . Bertin
rjvbb added a comment. ping? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5865 To: rjvbb, #frameworks, #build_system, cgilles Cc: kfunk

D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it

2017-05-25 Thread Chris Holland
Zren updated this revision to Diff 14841. Zren added a comment. Apply to icons-dark too. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5971?vs=14840=14841 REVISION DETAIL https://phabricator.kde.org/D5971 AFFECTED FILES

D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it

2017-05-25 Thread Chris Holland
Zren created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This lets panels >23px use the symbolic icon for their launcher. Right now the 48px version of kde.svg has a blue rounded rectangle

Re: Review Request 130139: Set QT_NO_EXCEPTIONS for *.mm files

2017-05-25 Thread René J . V . Bertin
> On May 25, 2017, 2:26 p.m., René J.V. Bertin wrote: > > src/kdeinit/CMakeLists.txt, line 6 > > > > > > I think you'll need to investigate this issue further first. I've been > > building (and patching) KInit

Re: Review Request 130139: Set QT_NO_EXCEPTIONS for *.mm files

2017-05-25 Thread René J . V . Bertin
> On May 25, 2017, 2:26 p.m., René J.V. Bertin wrote: > > src/kdeinit/CMakeLists.txt, line 6 > > > > > > I think you'll need to investigate this issue further first. I've been > > building (and patching) KInit

D5970: Fix KSNIs being unable to register service under flatpak

2017-05-25 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Rather than registering a custom service and then passing that to the watcher's RegisterItem we can just pass the base service as a name. As we're not registering random names it

Review Request 130139: Set QT_NO_EXCEPTIONS for *.mm files

2017-05-25 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130139/ --- Review request for KDE Frameworks and René J.V. Bertin. Repository:

Review Request 130138: Set QT_NO_EXCEPTIONS when building *.mm files

2017-05-25 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130138/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

D5912: minimize dialog resizes/moves

2017-05-25 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D5912#111657, @davidedmundson wrote: > but: we're still doing a resize whislt we have the old window management min/max hints set from the previous item, so it'll still have an extra resize, just at a kwin level not here.

D5912: minimize dialog resizes/moves

2017-05-25 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:32e67a591edb: minimize dialog resizes/moves (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5912?vs=14809=14834#toc REPOSITORY R242 Plasma Framework (Library) CHANGES

D5966: Fix race-condition in KRandom-seeding.

2017-05-25 Thread Thomas Friedrichsmeier
tfry updated this revision to Diff 14831. tfry added a comment. Ensure proper per-thread random-seeding in KRandom::random(). As commented, the problem is somewhat different, than I though, originally: qsrand() and qrand() keep random seeds per QThread, and each thread needs a