aacid added a comment.
i think it'd be much more acceptable if you made it equal to be "running
tests" like we have on other repos, so on by default but when running make
check.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D6076
To: tcberner, #freebsd,
This revision was automatically updated to reflect the committed changes.
Closed by commit R279:5973954f0b90: Work-around MSVC2017 compiler bug (authored
by kfunk).
REPOSITORY
R279 ThreadWeaver
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6101?vs=15173=15184
REVISION DETAIL
skalinichev added a comment.
In https://phabricator.kde.org/D5983#114146, @aacid wrote:
> I find this impolite, it was on my queue for reviewing properly, just i
have had a very busy week.
Ah, sorry for the misunderstanding, I simply thought that you didn't care
about it anymore
arrowdodger accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R279 ThreadWeaver
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6101
To: kfunk, arrowdodger, bcooksley
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:7bb1f434afaf: Jump to the clicked scrollbar position when
minim-map is enabled. (authored by sars).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/21/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Mon, 05 Jun 2017 15:29:50 +
Build duration:
3 min 23 sec and counting
apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Only mark package as installed if it was successfully extracted
Don't store all installed files in the knsregistry file
At the moment we were storing every file, for big packages (for
sars updated this revision to Diff 15180.
sars added a comment.
Use qBound() + remove one set of unneeded parenthesis
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6086?vs=15128=15180
REVISION DETAIL
https://phabricator.kde.org/D6086
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:1b0496d05987: scan the whole install folder for qml
dependencies (authored by mart).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6103?vs=15178=15179
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6103
To: mart, apol
Cc: #frameworks, #build_system
mart created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
set qml-root-path as the root install folder
of the application, as is used to scan for
import dependencies, and
arrowdodger created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Having `NOTIFY textChanged` on `text` property may come useful when using
KUrlRequester with KConfig. KUrlRequester field may hold paths for executables
and sometimes it is more convenient
apol updated this revision to Diff 15176.
apol added a comment.
More testing, fix issues
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6067?vs=15172=15176
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6067
AFFECTED FILES
winterz closed this revision.
winterz added a comment.
committed
https://phabricator.kde.org/R242:6c03c15c08a4b585bc3f320865858e4c2832f70b
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5828
To: winterz, mart, davidedmundson, bshah, #plasma
Cc:
kfunk added reviewers: arrowdodger, bcooksley.
REPOSITORY
R279 ThreadWeaver
REVISION DETAIL
https://phabricator.kde.org/D6101
To: kfunk, arrowdodger, bcooksley
Cc: #frameworks
kfunk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Also see: https://www.mail-archive.com/kde-windows@kde.org/msg07448.html
Error:
C:\JenkinsWS\workspace\Frameworks threadweaver
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130146/#review103284
---
I can see how this could be useful, but then it can be
apol updated this revision to Diff 15172.
apol added a comment.
Adds test, better parsing when there's comments, addresses comments by dfaure
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6067?vs=15096=15172
BRANCH
master
REVISION DETAIL
Hi all,
The Kirigami component set always was targeted to be eventually released as a
framework, ideally tier 1. since a framework must depend at most from 2 Qt
releases before the current one, it couldn't be released there yet.
Now that Qt 5.9 is released, i would like to propose to move
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130146/
---
(Updated June 5, 2017, 12:42 p.m.)
Review request for Kate and KDE
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
good idea!
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4972
To: davidedmundson, #plasma, mart
Cc: mart, hein, broulik, plasma-devel,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130146/
---
Review request for Kate and KDE Frameworks.
Repository: ktexteditor
kfunk added subscribers: arrowdodger, kfunk.
kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.
I don't think we should do that. Compilation only breaks on MSVC2017, which
is fairly new. And according to some test compilations by
mart added inline comments.
INLINE COMMENTS
> mart wrote in xdgshell_interface.h:80
> so storing all the ids of pings in progress somewhere to make a more recent
> ping not cancel an older one still pending?
from kwin, client.cpp:
i guess that's the kwin part that will have to use this.
it
mart accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5828
To: winterz, mart, davidedmundson, bshah, #plasma
Cc: dfaure, asturmlechner, apol, #frameworks
davidedmundson accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5828
To: winterz, mart, davidedmundson, bshah, #plasma
Cc: dfaure, asturmlechner, apol, #frameworks
bshah added a reviewer: Plasma.
bshah added a comment.
Still for 2nd review, adding Plasma as reviewer
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5828
To: winterz, mart, davidedmundson, bshah, #plasma
Cc: dfaure, asturmlechner, apol,
bshah accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5828
To: winterz, mart, davidedmundson, bshah
Cc: dfaure, asturmlechner, apol, #frameworks
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Sorting correctness (and more thorough testing) is good, yes. LGTM! :)
As to the missing arcconfig... will need someone to produce one of those who
actually uses arc to fix that ;)
29 matches
Mail list logo
