awilcox updated this revision to Diff 15456.
awilcox added a comment.
This is now a patch made with ```git format-patch``` against current master
(https://phabricator.kde.org/R286:6a24cf9d5a2fd83a22ea74d502d24665dcd0b57c).
Still passes on both Py2 and Py3.
REPOSITORY
R286 KFileMetaData
mgallien added a comment.
Thanks for the review.
The idea of this extractor is to have an extractor not needing taglib (ease
of build, build on platforms other than linux distributions).
QtMultimedia is not extracting a lot of metadata on linux+gstreamer but other
platforms have better
mgallien updated this revision to Diff 15454.
mgallien marked 7 inline comments as done.
mgallien added a comment.
fix issues reported by dfaure
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5417?vs=13840=15454
BRANCH
qtmultimedia
REVISION
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.7/23/
Project:
Frameworks knewstuff kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 14 Jun 2017 18:02:20 +
Build duration:
2 min 0 sec and counting
JUnit
FYI:
https://gitlab.kitware.com/cmake/cmake/issues/16973
R.
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in dialog.cpp:1368-1370
> You can't move the code from updateVisibility as we need it to work with an
> upcasted QQuickWindow::setVisible .
> That's probably the main reason you ended up having to change the pointer
> type in
mart updated this revision to Diff 15446.
mart added a comment.
don't update the size twice
only update the size in setvisible, not in updatevisibility.
if this is done in the showEvent instead, it's too late and
is possible to see a resize on screen
REPOSITORY
R242 Plasma
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:2f8580b9e604: Expose and use Engine's page size variable
(authored by leinir).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6190?vs=15377=15443#toc
REPOSITORY
R304 KNewStuff
CHANGES
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in dialog.cpp:1368-1370
> >> this is already done in updateVisibility which is effectively called from
> >
> > i think it should be safe to remove it from updatevisibility
>
> hmm, actually not, seems sometimes it needs to be
sebas added a comment.
I like this, and I'll likely need it in my kscreen OSD code aswell
(positioning there is unreliable, and my best guess is that this is the exact
same problem @mart is trying to solve here).
+1
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
mart added inline comments.
INLINE COMMENTS
> mart wrote in dialog.cpp:1368-1370
> > You've not really said what problem we're trying to solve with this patch.
>
> having a pointt in which we are 100% sure of the final size of the dialog to
> correctly position it.
> if visualparent is set,
11 matches
Mail list logo
