vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6220
To: kfunk, vkrause, dhaumann
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c70eb8b15640: CMake: Fix CMP0058 warning when using Ninja
(authored by kfunk).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6220?vs=15437&id=15726
RE
rjvbb updated this revision to Diff 15727.
rjvbb added a comment.
refreshed for git/head (and ¡bump!)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5037?vs=12608&id=15727
REVISION DETAIL
https://phabricator.kde.org/D5037
AFFECTED FILES
src/view/kateviewinternal.cpp
src/view/
rjvbb set the repository for this revision to R39 KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5037
To: rjvbb, #ktexteditor
Cc: luebking, anthonyfieroni, dhaumann, kwrite-devel, #ktexteditor,
#frameworks, head7, cullmann, kfunk, sars
chinmoyr updated this revision to Diff 15729.
chinmoyr marked 2 inline comments as done.
chinmoyr removed a reviewer: dfaure.
chinmoyr added a comment.
QStringLiteral -> i18n
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=15702&id=15729
REVISION DETAIL
kfunk added a comment.
A couple of minor issues I spotted while looking briefly over the patch.
INLINE COMMENTS
> kateviewinternal.cpp:76
> +
> +bool detectZoomingEvent(QWheelEvent *e, Qt::KeyboardModifiers
> modifier=Qt::ControlModifier)
> +{
Style: Use ` = `
> kateviewinternal.cp
chinmoyr added a comment.
In policy-gen.cpp there is this condition
if (persistence != QLatin1String("session") && persistence !=
QLatin1String("always")) {
qCritical("Wrong persistence: %s", persistence.toLatin1().data());
exit(1);
}
So, if there is persi
chinmoyr updated this revision to Diff 15732.
chinmoyr added a comment.
minor fixes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6198?vs=15625&id=15732
REVISION DETAIL
https://phabricator.kde.org/D6198
AFFECTED FILES
autotests/deletejobtest.cpp
autote
chinmoyr added inline comments.
INLINE COMMENTS
> davidedmundson wrote in file.actions:5
> We don't want session persistence
>
> It would mean if you prompt the user to delete a file, any rogue plugin in
> Dolphin can now remove any file without prompts.
> It would mean if you prompt the user
davidedmundson added a comment.
Right, there's 2 valid options if it's set, session and always. Which as you
say behave the same.
and an implicit third option, not setting it at all. Which does have a
different behaviour to the above.
I think that needs clearing up in the docs with a l
davidedmundson added a comment.
> There are additional prompts as well.
Those prompts are in the client code.
If there was a malicous agent hiding in a dolphin plugin, it would just be
making a direct call to the helper and skip all that.
REPOSITORY
R241 KIO
REVISION DETAIL
https:
kossebau created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The other KF5 modules use DOXYGEN_SHOULD_SKIP_THIS, picking up the example
from the doxygen documentation.
So for consistency and current expectations of kapidox (and built-in support
of EC
kossebau added a comment.
See current output of kapidox, which has no clue about `DOXYGEN_PREPROC`:
https://api.kde.org/frameworks/ki18n/html/klocalizedstring_8h.html
((sadly doxygen has no proper support for global methods, only documents them
as part of the file documentation, but that
kossebau created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Are not integrated wih kapidox or ECMAddQch, and the other
KF5 modules do not have such files.
For custom generation of API dox instead the QCH generation
can be used, by the target KF5I
kossebau added a comment.
For some background, files had been added in
https://cgit.kde.org/kdelibs.git/commit/staging/ki18n/?h=frameworks&id=67a945a51440a67e40cf7d0dbde93c5ecc5118c2
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D6339
To: kossebau, #frameworks, ilic
leinir created this revision.
leinir added a project: KNewStuff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This fixes the error detection for knsrc files, which previously would report
missing files only if the di
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
+1 for proper error messages!
INLINE COMMENTS
> engine.cpp:130
> +emit signalError(i18n("Configuration file exists, but cannot be
> opened: \"%1\"", configfile));
> +qCritical(
On Wed, Jun 21, 2017 at 6:22 PM, Jonathan Riddell wrote:
> On 21 June 2017 at 15:00, Marco Martin wrote:
>> As there were no replies for quite a while, i assume there are no
>> particular objections.
>>
>> so, how to proceed? what needs to be doe to do the actual move?
>
> Does it comply with the
rjvbb marked 6 inline comments as done.
rjvbb added inline comments.
INLINE COMMENTS
> kfunk wrote in kateviewinternal.cpp:87
> Simplify: `else if (...) {`?
Why the question mark? Simplification should be perfectly fine here, no?
> kfunk wrote in kateviewinternal.cpp:121
> Initialize here
Inst
rjvbb updated this revision to Diff 15747.
rjvbb marked 2 inline comments as done.
rjvbb added a comment.
Updated as requested.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5037?vs=15727&id=15747
REVISION DETAIL
https://phabricator.kde.org/D5037
AFFECTED FILES
src/view/katevi
rjvbb set the repository for this revision to R39 KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5037
To: rjvbb, #ktexteditor
Cc: kfunk, luebking, anthonyfieroni, dhaumann, kwrite-devel, #ktexteditor,
#frameworks, head7, cullmann, sars
graesslin added a comment.
could you please upload a version with context?
INLINE COMMENTS
> mart wrote in xdgshell_interface.h:80
> from kwin, client.cpp:
> i guess that's the kwin part that will have to use this.
> it uses a single timer, and tries for a couple of timeout, as soon as the
>
tfry added a comment.
Looks good to me.
This place is talking about how to get icon themes working, and so it should
list the most relevant approaches. Arguably, this is not the place where I
would have looked for an answer to that question, first, but since it does
provide an answer, i
ltoscano created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REVISION SUMMARY
Right now each users of KDocTools (KIO Help, KHelpCenter) contains
the logic to get the documentation director
ltoscano created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Use the function now available in KDocTools to retrieve the list
of documentation directories.
TEST PLAN
No regressions in the behavior
ltoscano added a dependent revision: D6353: Get the doc dirs with the newly
exported function.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D6352
To: ltoscano, dfaure
Cc: #frameworks, #documentation, skadinna
ltoscano added a dependency: D6352: New function to retrieve the documentation
directories.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6353
To: ltoscano, dfaure
Cc: #frameworks
27 matches
Mail list logo