This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6ca0b93e6029: Use KIO::rename instead of KIO::moveAs in
setData (authored by hein).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6413?vs=15935&id=16030
REVISION DETA
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/12/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 29 Jun 2017 16:27:05 +
Build duration:
2 min 27 sec and counting
JUnit Tests
davidedmundson retitled this revision from "WIP: Support XDG v6" to "Support
XDG v6".
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6047
To: davidedmundson, #plasma
Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreut
mart added a comment.
love the idea.
when this goes in, at least one using this should already exist, to make sure
the code gets well tested from day one.
this makes me think...
it's not exacrtly the same thing, maybe kindof a layer, but would be possible
to start from this and have
elvisangelaccio added a reviewer: Frameworks.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6008
To: elvisangelaccio, mart, #frameworks
Cc: #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/23/
Project:
Frameworks syntax-highlighting kf5-qt5 XenialQt5.7
Date of build:
Thu, 29 Jun 2017 14:00:14 +
Build duration:
1 min 46 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/23/
Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 29 Jun 2017 14:00:14 +
Build duration:
1 min 29 sec and counting
arrowdodger abandoned this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6430
To: arrowdodger
Cc: #frameworks
arrowdodger created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6430
AFFECTED FILES
data/syntax/julius.xml
To: ar
mart updated this revision to Diff 15997.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- quint32 everywhere
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6418?vs=15989&id=15997
BRANCH
mart/xdgv6
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20networkmanager-qt%20kf5-qt5%20XenialQt5.7/30/
Project:
Frameworks networkmanager-qt kf5-qt5 XenialQt5.7
Date of build:
Thu, 29 Jun 2017 11:29:19 +
Build duration:
8 min 32 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20networkmanager-qt%20kf5-qt5%20XenialQt5.7/29/
Project:
Frameworks networkmanager-qt kf5-qt5 XenialQt5.7
Date of build:
Thu, 29 Jun 2017 11:17:23 +
Build duration:
7 min 7 sec and counting
C
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20networkmanager-qt%20kf5-qt5%20XenialQt5.7/28/
Project:
Frameworks networkmanager-qt kf5-qt5 XenialQt5.7
Date of build:
Thu, 29 Jun 2017 11:09:48 +
Build duration:
7 min 33 sec and counting
mart updated this revision to Diff 15989.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- get rid of discardPing
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6418?vs=15948&id=15989
BRANCH
mart/x
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:d2a38d790914: Haskell: Add all language pragmas as
keywords. (authored by arrowdodger).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6087?vs=15982&id=
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/22/
Project:
Frameworks syntax-highlighting kf5-qt5 XenialQt5.7
Date of build:
Thu, 29 Jun 2017 09:20:19 +
Build duration:
3 min 23 sec and counting
mart added a comment.
In https://phabricator.kde.org/D6418#120319, @davidedmundson wrote:
> > for how i did the kwin part, it must be who called it with discardTimer
(this to allow kwin to receive 2 timeouts before deciding to kill the window)
>
> Ok, I see how it's meant to work but
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/22/
Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 29 Jun 2017 09:20:19 +
Build duration:
1 min 53 sec and counting
cullmann accepted this revision.
cullmann added a comment.
Feel free to push ;=)
Thanks for additions!
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6087
To: arrowdodger, #framework_syntax_hightlighting, dhaumann, cullmann
Cc: cullman
arrowdodger updated this revision to Diff 15982.
arrowdodger added a comment.
Updated reference file for autotest as well.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6087?vs=15981&id=15982
BRANCH
master
REVISION DETAIL
https://phabrica
cullmann added a comment.
Hmm, interesting, I would assume you need to update the ref given the input
did change.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6087
To: arrowdodger, #framework_syntax_hightlighting, dhaumann
Cc: cullman
arrowdodger updated this revision to Diff 15981.
arrowdodger added a comment.
Added autotests. Not sure if .ref file should be updated, as the tests pass
as they are now.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6087?vs=15772&id=15981
BR
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:c46ab3cae4fb: KKeySequenceItem: make it possible to
record Ctrl+Num+1 as a shortcut. (authored by davidedmundson).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.or
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:86bbebdee213: Start drag with press and hold on touch
events (authored by davidedmundson).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4972?vs=12273&id=1597
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Yep, using `KIO::rename` to perform a renaming sounds fully correct ;-)
One possible downside would be a kioslave that doesn't implement
SlaveBase::rename, but that's unlikely (especial
cullmann added a comment.
I would say yes.
If you have some more time, you could add an auto-test for it.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6087
To: arrowdodger, #framework_syntax_hightlighting, dhaumann
Cc: cullmann, dhau
arrowdodger added a comment.
So, can I push this?
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6087
To: arrowdodger, #framework_syntax_hightlighting, dhaumann
Cc: dhaumann, #frameworks
27 matches
Mail list logo